[Bug 770] New: usbaudio does not compile

[Bug 770] New: usbaudio does not compile

[Martin J. Bligh]

http://bugme.osdl.org/show_bug.cgi?id=770

           Summary: usbaudio does not compile
    Kernel Version: 2.5.70-bk8
            Status: NEW
          Severity: normal
             Owner: bugme-janitors@lists.osdl.org
         Submitter: a.akhavan@ndr.de


Distribution: SuSE 8.2
Hardware Environment: Acer Travelmate 800 LCi
Software Environment: gcc 3.3
Problem Description: usbaudio does not compile on 2.5.70-bk8
(I've skipped a few snapshots, so it might have been introduced at > 2.5.70-bk5)
It used to compile before. 

Error-log:
In file included from sound/usb/usbaudio.c:35:
include/linux/usb.h: In function `usb_make_path':
include/linux/usb.h:327: warning: comparison between signed and unsigned
sound/usb/usbaudio.c: In function `parse_audio_format_i_type':
sound/usb/usbaudio.c:1947: error: `iface_no' undeclared (first use in this function)
sound/usb/usbaudio.c:1947: error: (Each undeclared identifier is reported only once
sound/usb/usbaudio.c:1947: error: for each function it appears in.)
sound/usb/usbaudio.c:1947: error: `altno' undeclared (first use in this function)
sound/usb/usbaudio.c: In function `parse_audio_endpoints':
sound/usb/usbaudio.c:2172: warning: comparison between signed and unsigned
sound/usb/usbaudio.c: In function `snd_usb_audio_create':
sound/usb/usbaudio.c:2582: warning: comparison between signed and unsigned
make[2]: *** [sound/usb/usbaudio.o] Error 1
make[1]: *** [sound/usb] Error 2
make: *** [sound] Error 2


Steps to reproduce:
Pentium M + Centrino / ACPI / usb


CONFIG_SOUND=m

CONFIG_SND=m
CONFIG_SND_SEQUENCER=m
CONFIG_SND_SEQ_DUMMY=m
CONFIG_SND_OSSEMUL=y
CONFIG_SND_MIXER_OSS=m
CONFIG_SND_PCM_OSS=m
CONFIG_SND_SEQUENCER_OSS=y
CONFIG_SND_RTCTIMER=m
CONFIG_SND_VERBOSE_PRINTK=y
CONFIG_SND_DEBUG=y
CONFIG_SND_DEBUG_DETECT=y

CONFIG_SND_DUMMY=m
CONFIG_SND_VIRMIDI=m
CONFIG_SND_MTPAV=m
CONFIG_SND_SERIAL_U16550=m
CONFIG_SND_MPU401=m

CONFIG_SND_ALI5451=m
CONFIG_SND_EMU10K1=m
CONFIG_SND_YMFPCI=m
CONFIG_SND_ENS1370=m
CONFIG_SND_ENS1371=m
CONFIG_SND_INTEL8X0=m
CONFIG_SND_SONICVIBES=m
CONFIG_SND_VIA82XX=m

CONFIG_SND_USB_AUDIO=m


CONFIG_SOUND_PRIME=m
CONFIG_SOUND_BT878=m
CONFIG_SOUND_ICH=m
CONFIG_SOUND_VIA82CXXX=m
CONFIG_SOUND_OSS=m
CONFIG_SOUND_TRACEINIT=y
CONFIG_SOUND_DMAP=y

CONFIG_USB=m

CONFIG_USB_DEVICEFS=y
CONFIG_USB_BANDWIDTH=y

CONFIG_USB_EHCI_HCD=m
CONFIG_USB_OHCI_HCD=m
CONFIG_USB_UHCI_HCD=m

CONFIG_USB_AUDIO=m
CONFIG_USB_MIDI=m
CONFIG_USB_ACM=m
CONFIG_USB_PRINTER=m
CONFIG_USB_STORAGE=m
CONFIG_USB_STORAGE_DATAFAB=y
CONFIG_USB_STORAGE_FREECOM=y
CONFIG_USB_STORAGE_ISD200=y
CONFIG_USB_STORAGE_DPCM=y
CONFIG_USB_STORAGE_SDDR09=y
CONFIG_USB_STORAGE_SDDR55=y
CONFIG_USB_STORAGE_JUMPSHOT=y

CONFIG_USB_HID=m
CONFIG_USB_HIDINPUT=y
CONFIG_USB_HIDDEV=y

CONFIG_USB_AIPTEK=m
CONFIG_USB_WACOM=m
CONFIG_USB_KBTAB=m

Re: [Bug 770] New: usbaudio does not compile

[Takashi Iwai]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Hi,

At Tue, 03 Jun 2003 09:49:58 -0700,
Martin J. Bligh <mbligh@aracnet.com> wrote:
> 
> http://bugme.osdl.org/show_bug.cgi?id=770
> 
>            Summary: usbaudio does not compile
>     Kernel Version: 2.5.70-bk8
>             Status: NEW
>           Severity: normal
>              Owner: bugme-janitors@lists.osdl.org
>          Submitter: a.akhavan@ndr.de
> 
> 
> Distribution: SuSE 8.2
> Hardware Environment: Acer Travelmate 800 LCi
> Software Environment: gcc 3.3
> Problem Description: usbaudio does not compile on 2.5.70-bk8
> (I've skipped a few snapshots, so it might have been introduced at > 2.5.70-bk5)
> It used to compile before. 
> 
> Error-log:
(snip)

this bug appears only when CONFIG_SND_DEBUG_DETECT is set, so i didn't
notice that.
please apply the patch below, or simply turn off
CONFIG_SND_DEBUG_DETECT (it's anyway redundant).

-- 
Takashi Iwai <tiwai@suse.de>		SuSE Linux AG - www.suse.de
ALSA Developer				ALSA Project - www.alsa-project.org

[-- Attachment #2: usb-fix.dif --]
[-- Type: application/octet-stream, Size: 487 bytes --]

--- linux/sound/usb/usbaudio.c	2 Jun 2003 10:04:45 -0000	1.56
+++ linux/sound/usb/usbaudio.c	3 Jun 2003 10:05:59 -0000
@@ -1939,7 +1939,7 @@
 	switch (format) {
 	case 0: /* some devices don't define this correctly... */
 		snd_printdd(KERN_INFO "%d:%u:%d : format type 0 is detected, processed as PCM\n",
-			    dev->devnum, iface_no, altno);
+			    dev->devnum, fp->iface, fp->altsetting);
 		/* fall-through */
 	case USB_AUDIO_FORMAT_PCM:
 		if (sample_width > sample_bytes * 8) {