All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
@ 2022-03-30  6:13 ` Kai-Heng Feng
  0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2022-03-30  6:13 UTC (permalink / raw)
  To: tiwai
  Cc: Kai-Heng Feng, kernel test robot, Dan Carpenter, Jaroslav Kysela,
	Jeremy Szu, Werner Sembach, Hui Wang, Lucas Tanure,
	Cameron Berkenpas, Kailang Yang, Sami Loone, alsa-devel,
	linux-kernel

Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
issue") is to solve recording issue met on AL236, by matching codec
variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.

This match can be too broad and Mi Notebook Pro 2020 is broken by the
patch.

Instead, use codec ID to be narrow down the scope, in order to make
ALC256 unaffected.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2:
 Fix wrong comparison, || -> &&

 sound/pci/hda/patch_realtek.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4c33cb57963db..aace474a899de 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3617,8 +3617,8 @@ static void alc256_shutup(struct hda_codec *codec)
 	/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
 	 * when booting with headset plugged. So skip setting it for the codec alc257
 	 */
-	if (spec->codec_variant != ALC269_TYPE_ALC257 &&
-	    spec->codec_variant != ALC269_TYPE_ALC256)
+	if (codec->core.vendor_id != 0x10ec0236 &&
+	    codec->core.vendor_id != 0x10ec0257)
 		alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
 
 	if (!spec->no_shutup_pins)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
@ 2022-03-30  6:13 ` Kai-Heng Feng
  0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2022-03-30  6:13 UTC (permalink / raw)
  To: tiwai
  Cc: alsa-devel, Kailang Yang, kernel test robot, Lucas Tanure,
	Jeremy Szu, linux-kernel, Werner Sembach, Hui Wang,
	Kai-Heng Feng, Sami Loone, Cameron Berkenpas, Dan Carpenter

Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
issue") is to solve recording issue met on AL236, by matching codec
variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.

This match can be too broad and Mi Notebook Pro 2020 is broken by the
patch.

Instead, use codec ID to be narrow down the scope, in order to make
ALC256 unaffected.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2:
 Fix wrong comparison, || -> &&

 sound/pci/hda/patch_realtek.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4c33cb57963db..aace474a899de 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3617,8 +3617,8 @@ static void alc256_shutup(struct hda_codec *codec)
 	/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
 	 * when booting with headset plugged. So skip setting it for the codec alc257
 	 */
-	if (spec->codec_variant != ALC269_TYPE_ALC257 &&
-	    spec->codec_variant != ALC269_TYPE_ALC256)
+	if (codec->core.vendor_id != 0x10ec0236 &&
+	    codec->core.vendor_id != 0x10ec0257)
 		alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
 
 	if (!spec->no_shutup_pins)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
  2022-03-30  6:13 ` Kai-Heng Feng
@ 2022-03-30  8:17   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-03-30  8:17 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: tiwai, kernel test robot, Dan Carpenter, Jaroslav Kysela,
	Jeremy Szu, Werner Sembach, Hui Wang, Lucas Tanure,
	Cameron Berkenpas, Kailang Yang, Sami Loone, alsa-devel,
	linux-kernel

On Wed, 30 Mar 2022 08:13:33 +0200,
Kai-Heng Feng wrote:
> 
> Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
> issue") is to solve recording issue met on AL236, by matching codec
> variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.
> 
> This match can be too broad and Mi Notebook Pro 2020 is broken by the
> patch.
> 
> Instead, use codec ID to be narrow down the scope, in order to make
> ALC256 unaffected.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
> Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
>  Fix wrong comparison, || -> &&

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
@ 2022-03-30  8:17   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-03-30  8:17 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: alsa-devel, Kailang Yang, kernel test robot, Lucas Tanure,
	Jeremy Szu, linux-kernel, tiwai, Werner Sembach, Hui Wang,
	Sami Loone, Cameron Berkenpas, Dan Carpenter

On Wed, 30 Mar 2022 08:13:33 +0200,
Kai-Heng Feng wrote:
> 
> Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
> issue") is to solve recording issue met on AL236, by matching codec
> variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.
> 
> This match can be too broad and Mi Notebook Pro 2020 is broken by the
> patch.
> 
> Instead, use codec ID to be narrow down the scope, in order to make
> ALC256 unaffected.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
> Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
>  Fix wrong comparison, || -> &&

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-30  8:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-30  6:13 [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 Kai-Heng Feng
2022-03-30  6:13 ` Kai-Heng Feng
2022-03-30  8:17 ` Takashi Iwai
2022-03-30  8:17   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.