Re: [PATCH] ASoC: intel: atom: Fix breakage for PCM buffer address setup

[Takashi Iwai <tiwai@suse.de>]

On Thu, 19 Aug 2021 17:29:45 +0200,
Takashi Iwai wrote:
> 
> The commit 2e6b836312a4 ("ASoC: intel: atom: Fix reference to PCM
> buffer address") changed the reference of PCM buffer address to
> substream->runtime->dma_addr as the buffer address may change
> dynamically.  However, I forgot that the dma_addr field is still not
> set up for the CONTINUOUS buffer type (that this driver uses) yet in
> 5.14 and earlier kernels, and it resulted in garbage I/O.  The problem
> will be fixed in 5.15, but we need to address it quickly for now.
> 
> The fix is to deduce the address again from the DMA pointer with
> virt_to_phys(), but from the right one, substream->runtime->dma_area.
> 
> Fixes: 2e6b836312a4 ("ASoC: intel: atom: Fix reference to PCM buffer address")
> Reported-and-tested-by: Hans de Goede <hdegoede@redhat.com>
> Cc: <stable@vger.kernel.org>
> Link: https://lore.kernel.org/r/2048c6aa-2187-46bd-6772-36a4fb3c5aeb@redhat.com
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---

Mark, as it's close to the 5.14 final, exceptionally I'd like to merge
this into my tree directly now, so that it can be certainly included
in the next PR to Linus.
(Also because the commit will be reverted on for-next again, too.)

After the merge, feel free to pull my for-linus branch into yours.


thanks,

Takashi