All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: US16x08: fix value count for level meters
@ 2020-11-27 13:26 ` Hector Martin
  0 siblings, 0 replies; 3+ messages in thread
From: Hector Martin @ 2020-11-27 13:26 UTC (permalink / raw)
  To: alsa-devel; +Cc: Detlef Urban, Takashi Iwai, Hector Martin, stable

The level meter control returns 34 integers of info. This fixes:

snd-usb-audio 3-1:1.0: control 2:0:0:Level Meter:0: access overflow

Cc: stable@vger.kernel.org
Signed-off-by: Hector Martin <marcan@marcan.st>
---
 sound/usb/mixer_us16x08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
index 92b1a6d9c931..bd63a9ce6a70 100644
--- a/sound/usb/mixer_us16x08.c
+++ b/sound/usb/mixer_us16x08.c
@@ -607,7 +607,7 @@ static int snd_us16x08_eq_put(struct snd_kcontrol *kcontrol,
 static int snd_us16x08_meter_info(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_info *uinfo)
 {
-	uinfo->count = 1;
+	uinfo->count = 34;
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
 	uinfo->value.integer.max = 0x7FFF;
 	uinfo->value.integer.min = 0;
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ALSA: usb-audio: US16x08: fix value count for level meters
@ 2020-11-27 13:26 ` Hector Martin
  0 siblings, 0 replies; 3+ messages in thread
From: Hector Martin @ 2020-11-27 13:26 UTC (permalink / raw)
  To: alsa-devel; +Cc: Takashi Iwai, Detlef Urban, Hector Martin, stable

The level meter control returns 34 integers of info. This fixes:

snd-usb-audio 3-1:1.0: control 2:0:0:Level Meter:0: access overflow

Cc: stable@vger.kernel.org
Signed-off-by: Hector Martin <marcan@marcan.st>
---
 sound/usb/mixer_us16x08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
index 92b1a6d9c931..bd63a9ce6a70 100644
--- a/sound/usb/mixer_us16x08.c
+++ b/sound/usb/mixer_us16x08.c
@@ -607,7 +607,7 @@ static int snd_us16x08_eq_put(struct snd_kcontrol *kcontrol,
 static int snd_us16x08_meter_info(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_info *uinfo)
 {
-	uinfo->count = 1;
+	uinfo->count = 34;
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
 	uinfo->value.integer.max = 0x7FFF;
 	uinfo->value.integer.min = 0;
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: usb-audio: US16x08: fix value count for level meters
  2020-11-27 13:26 ` Hector Martin
  (?)
@ 2020-11-27 13:57 ` Takashi Iwai
  -1 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2020-11-27 13:57 UTC (permalink / raw)
  To: Hector Martin; +Cc: alsa-devel, Detlef Urban, stable

On Fri, 27 Nov 2020 14:26:35 +0100,
Hector Martin wrote:
> 
> The level meter control returns 34 integers of info. This fixes:
> 
> snd-usb-audio 3-1:1.0: control 2:0:0:Level Meter:0: access overflow
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Hector Martin <marcan@marcan.st>

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-27 13:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 13:26 [PATCH] ALSA: usb-audio: US16x08: fix value count for level meters Hector Martin
2020-11-27 13:26 ` Hector Martin
2020-11-27 13:57 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.