All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Guneshwor Singh <guneshwor.o.singh@intel.com>,
	Hardik T Shah <hardik.t.shah@intel.com>,
	Libin Yang <libin.yang@intel.com>,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	Vinod Koul <vinod.koul@intel.com>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	Jaroslav Kysela <perex@perex.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support
Date: Tue, 04 Jul 2017 17:28:13 +0200	[thread overview]
Message-ID: <s5hy3s4dxwy.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKMK7uE_Tb9OHKMjnNN-=Jf7VHeZTa1MaO0sL7MGsa2-e1rxZg@mail.gmail.com>

On Tue, 04 Jul 2017 17:14:39 +0200,
Daniel Vetter wrote:
> 
> On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> >> Now I took a closer look, and this appears rather like a brown paper
> >> bag bug, not about the deferred probe or module dependency.
> >> The fix patch is below.  Could you check whether it works?
> >
> > Yay, this works!
> >
> > Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Next one: i915 module reloading is broken because something is holding
> onto a module reference and doesn't drop it. Didn't check which sets
> of patches introduced this, but iirc this worked last week. Disabling
> hda-intel gets in Kconfig gets rid of the problem, so I assume
> something in the sound driver is leaking that reference ...
> 
> It's also causing lots and lots of red in our CI :( If we can't fix
> this we need to disable snd-hda-intel there too.

I spotted out a typo in my previous patch that leads to the module
reference unbalance.  The fix is  already in sound.git tree today:
  https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&id=fc18282cdcba984ab89c74d7e844c10114ae0795

The bug was introduced after 4.12.


thanks,

--
Takashi Iwai <tiwai@suse.de>

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Vinod Koul <vinod.koul@intel.com>,
	Hardik T Shah <hardik.t.shah@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Guneshwor Singh <guneshwor.o.singh@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	Jaroslav Kysela <perex@perex.cz>,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support
Date: Tue, 04 Jul 2017 17:28:13 +0200	[thread overview]
Message-ID: <s5hy3s4dxwy.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKMK7uE_Tb9OHKMjnNN-=Jf7VHeZTa1MaO0sL7MGsa2-e1rxZg@mail.gmail.com>

On Tue, 04 Jul 2017 17:14:39 +0200,
Daniel Vetter wrote:
> 
> On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> >> Now I took a closer look, and this appears rather like a brown paper
> >> bag bug, not about the deferred probe or module dependency.
> >> The fix patch is below.  Could you check whether it works?
> >
> > Yay, this works!
> >
> > Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Next one: i915 module reloading is broken because something is holding
> onto a module reference and doesn't drop it. Didn't check which sets
> of patches introduced this, but iirc this worked last week. Disabling
> hda-intel gets in Kconfig gets rid of the problem, so I assume
> something in the sound driver is leaking that reference ...
> 
> It's also causing lots and lots of red in our CI :( If we can't fix
> this we need to disable snd-hda-intel there too.

I spotted out a typo in my previous patch that leads to the module
reference unbalance.  The fix is  already in sound.git tree today:
  https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&id=fc18282cdcba984ab89c74d7e844c10114ae0795

The bug was introduced after 4.12.


thanks,

--
Takashi Iwai <tiwai@suse.de>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-07-04 15:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 15:08 [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support Daniel Vetter
2017-06-21 15:08 ` Daniel Vetter
2017-06-21 15:23 ` Chris Wilson
2017-06-21 15:23   ` Chris Wilson
2017-06-21 15:30   ` Takashi Iwai
2017-06-21 15:30     ` Takashi Iwai
2017-06-26 16:16     ` Daniel Vetter
2017-06-26 16:16       ` Daniel Vetter
2017-06-26 17:47       ` Takashi Iwai
2017-06-26 17:47         ` Takashi Iwai
2017-06-26 17:54         ` Daniel Vetter
2017-06-26 17:54           ` Daniel Vetter
2017-06-28 10:16           ` Takashi Iwai
2017-06-28 10:16             ` Takashi Iwai
2017-06-29 10:25             ` Daniel Vetter
2017-06-29 10:25               ` Daniel Vetter
2017-07-04 15:14               ` Daniel Vetter
2017-07-04 15:28                 ` Takashi Iwai [this message]
2017-07-04 15:28                   ` Takashi Iwai
2017-07-04 18:12                   ` Daniel Vetter
2017-07-04 18:12                     ` Daniel Vetter
2017-06-21 15:52 ` ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hy3s4dxwy.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=guneshwor.o.singh@intel.com \
    --cc=hardik.t.shah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=libin.yang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=subhransu.s.prusty@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.