* [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message
@ 2016-09-16 10:09 Colin King
2016-09-16 11:14 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2016-09-16 10:09 UTC (permalink / raw)
To: trivial, Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trival fix, the dev_err message is missing a \n so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/au88x0/au88x0_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
index d3125c1..e1af24f 100644
--- a/sound/pci/au88x0/au88x0_core.c
+++ b/sound/pci/au88x0/au88x0_core.c
@@ -1043,7 +1043,7 @@ static void vortex_fifo_init(vortex_t * vortex)
for (x = NR_ADB - 1; x >= 0; x--) {
hwwrite(vortex->mmio, addr, (FIFO_U0 | FIFO_U1));
if (hwread(vortex->mmio, addr) != (FIFO_U0 | FIFO_U1))
- dev_err(vortex->card->dev, "bad adb fifo reset!");
+ dev_err(vortex->card->dev, "bad adb fifo reset!\n");
vortex_fifo_clearadbdata(vortex, x, FIFO_SIZE);
addr -= 4;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message
2016-09-16 10:09 [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message Colin King
@ 2016-09-16 11:14 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2016-09-16 11:14 UTC (permalink / raw)
To: Colin King; +Cc: alsa-devel, trivial, Jaroslav Kysela, linux-kernel
On Fri, 16 Sep 2016 12:09:25 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, the dev_err message is missing a \n so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/pci/au88x0/au88x0_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
> index d3125c1..e1af24f 100644
> --- a/sound/pci/au88x0/au88x0_core.c
> +++ b/sound/pci/au88x0/au88x0_core.c
> @@ -1043,7 +1043,7 @@ static void vortex_fifo_init(vortex_t * vortex)
> for (x = NR_ADB - 1; x >= 0; x--) {
> hwwrite(vortex->mmio, addr, (FIFO_U0 | FIFO_U1));
> if (hwread(vortex->mmio, addr) != (FIFO_U0 | FIFO_U1))
> - dev_err(vortex->card->dev, "bad adb fifo reset!");
> + dev_err(vortex->card->dev, "bad adb fifo reset!\n");
> vortex_fifo_clearadbdata(vortex, x, FIFO_SIZE);
> addr -= 4;
> }
> --
> 2.9.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message
@ 2016-09-16 11:14 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2016-09-16 11:14 UTC (permalink / raw)
To: Colin King; +Cc: alsa-devel, trivial, Jaroslav Kysela, linux-kernel
On Fri, 16 Sep 2016 12:09:25 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, the dev_err message is missing a \n so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/pci/au88x0/au88x0_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
> index d3125c1..e1af24f 100644
> --- a/sound/pci/au88x0/au88x0_core.c
> +++ b/sound/pci/au88x0/au88x0_core.c
> @@ -1043,7 +1043,7 @@ static void vortex_fifo_init(vortex_t * vortex)
> for (x = NR_ADB - 1; x >= 0; x--) {
> hwwrite(vortex->mmio, addr, (FIFO_U0 | FIFO_U1));
> if (hwread(vortex->mmio, addr) != (FIFO_U0 | FIFO_U1))
> - dev_err(vortex->card->dev, "bad adb fifo reset!");
> + dev_err(vortex->card->dev, "bad adb fifo reset!\n");
> vortex_fifo_clearadbdata(vortex, x, FIFO_SIZE);
> addr -= 4;
> }
> --
> 2.9.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-16 11:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 10:09 [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message Colin King
2016-09-16 11:14 ` Takashi Iwai
2016-09-16 11:14 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.