From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - fix unused Realtek function when PM is not enabled
Date: Sun, 08 May 2022 11:11:13 +0200 [thread overview]
Message-ID: <s5hzgjsmlse.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220430193318.29024-1-rdunlap@infradead.org>
On Sat, 30 Apr 2022 21:33:18 +0200,
Randy Dunlap wrote:
>
> When CONFIG_PM is not enabled, alc_shutup() is not needed,
> so move it inside the #ifdef CONFIG_PM guard.
> Also drop some contiguous #endif / #ifdef CONFIG_PM for simplicity.
>
> Fixes this build warning:
> sound/pci/hda/patch_realtek.c:886:20: warning: unused function 'alc_shutup'
>
> Fixes: 08c189f2c552 ("ALSA: hda - Use generic parser codes for Realtek driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: alsa-devel@alsa-project.org
Thanks, applied now.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ALSA: hda - fix unused Realtek function when PM is not enabled
Date: Sun, 08 May 2022 11:11:13 +0200 [thread overview]
Message-ID: <s5hzgjsmlse.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220430193318.29024-1-rdunlap@infradead.org>
On Sat, 30 Apr 2022 21:33:18 +0200,
Randy Dunlap wrote:
>
> When CONFIG_PM is not enabled, alc_shutup() is not needed,
> so move it inside the #ifdef CONFIG_PM guard.
> Also drop some contiguous #endif / #ifdef CONFIG_PM for simplicity.
>
> Fixes this build warning:
> sound/pci/hda/patch_realtek.c:886:20: warning: unused function 'alc_shutup'
>
> Fixes: 08c189f2c552 ("ALSA: hda - Use generic parser codes for Realtek driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: alsa-devel@alsa-project.org
Thanks, applied now.
Takashi
next prev parent reply other threads:[~2022-05-08 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 19:33 [PATCH] ALSA: hda - fix unused Realtek function when PM is not enabled Randy Dunlap
2022-04-30 19:33 ` Randy Dunlap
2022-05-08 9:11 ` Takashi Iwai [this message]
2022-05-08 9:11 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzgjsmlse.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.