All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: David Rientjes <rientjes@google.com>,
	"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
	alsa-devel@alsa-project.org, bp@alien8.de, hch@infradead.org,
	hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@redhat.com,
	Pavel Machek <pavel@ucw.cz>,
	perex@perex.cz, tglx@linutronix.de, tiwai@suse.com,
	x86@kernel.org
Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash
Date: Tue, 09 Jun 2020 13:45:34 +0200	[thread overview]
Message-ID: <s5hzh9ch38h.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200609114059.GA1228@lst.de>

On Tue, 09 Jun 2020 13:40:59 +0200,
Christoph Hellwig wrote:
> 
> On Tue, Jun 09, 2020 at 01:38:46PM +0200, Takashi Iwai wrote:
> > On Tue, 09 Jun 2020 13:31:23 +0200,
> > Christoph Hellwig wrote:
> > > 
> > > On Tue, Jun 09, 2020 at 11:31:20AM +0200, Takashi Iwai wrote:
> > > > > > How would be a proper way to get the virtually mapped SG-buffer pages
> > > > > > with coherent memory?  (Also allowing user-space mmap, too)
> > > > > 
> > > > > dma_mmap_coherent / dma_mmap_attrs for userspace.  We don't really
> > > > > have a good way for kernel space mappings.
> > > > 
> > > > And that's the missing piece right now...  :-<
> > > 
> > > Can you point me to the relevant places (allocation and vmap mostly)
> > > so that I can take a look at how to fix this mess?
> > 
> > Found in sound/core/sgbuf.c.  It's specific to x86.
> 
> So it looks like we could just turn off CONFIG_SND_DMA_SGBUF and
> be done with it?  After all this works on other architectures
> just fine..

Yes, for the sound stuff, something below should make things working.
But it means that we'll lose the SG-buffer allocation and the
allocation of large buffers might fail on some machines.


Takashi

--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -192,6 +192,6 @@ config SND_VMASTER
 
 config SND_DMA_SGBUF
 	def_bool y
-	depends on X86
+	depends on X86 && BROKEN
 
 source "sound/core/seq/Kconfig"

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: alsa-devel@alsa-project.org, x86@kernel.org,
	David Rientjes <rientjes@google.com>,
	tiwai@suse.com, linux-kernel@vger.kernel.org,
	"Alex Xu \(Hello71\)" <alex_y_xu@yahoo.ca>,
	hch@infradead.org, mingo@redhat.com, bp@alien8.de,
	Pavel Machek <pavel@ucw.cz>,
	hpa@zytor.com, tglx@linutronix.de
Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash
Date: Tue, 09 Jun 2020 13:45:34 +0200	[thread overview]
Message-ID: <s5hzh9ch38h.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200609114059.GA1228@lst.de>

On Tue, 09 Jun 2020 13:40:59 +0200,
Christoph Hellwig wrote:
> 
> On Tue, Jun 09, 2020 at 01:38:46PM +0200, Takashi Iwai wrote:
> > On Tue, 09 Jun 2020 13:31:23 +0200,
> > Christoph Hellwig wrote:
> > > 
> > > On Tue, Jun 09, 2020 at 11:31:20AM +0200, Takashi Iwai wrote:
> > > > > > How would be a proper way to get the virtually mapped SG-buffer pages
> > > > > > with coherent memory?  (Also allowing user-space mmap, too)
> > > > > 
> > > > > dma_mmap_coherent / dma_mmap_attrs for userspace.  We don't really
> > > > > have a good way for kernel space mappings.
> > > > 
> > > > And that's the missing piece right now...  :-<
> > > 
> > > Can you point me to the relevant places (allocation and vmap mostly)
> > > so that I can take a look at how to fix this mess?
> > 
> > Found in sound/core/sgbuf.c.  It's specific to x86.
> 
> So it looks like we could just turn off CONFIG_SND_DMA_SGBUF and
> be done with it?  After all this works on other architectures
> just fine..

Yes, for the sound stuff, something below should make things working.
But it means that we'll lose the SG-buffer allocation and the
allocation of large buffers might fail on some machines.


Takashi

--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -192,6 +192,6 @@ config SND_VMASTER
 
 config SND_DMA_SGBUF
 	def_bool y
-	depends on X86
+	depends on X86 && BROKEN
 
 source "sound/core/seq/Kconfig"

  reply	other threads:[~2020-06-09 11:45 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 11:11 next-0519 on thinkpad x60: sound related? window manager crash Pavel Machek
2020-05-20 11:37 ` Takashi Iwai
2020-05-20 11:37   ` Takashi Iwai
2020-05-20 11:39   ` Pavel Machek
2020-05-20 11:39     ` Pavel Machek
2020-05-20 11:43     ` Takashi Iwai
2020-05-20 11:43       ` Takashi Iwai
2020-06-07 15:58 ` Alex Xu (Hello71)
2020-06-07 16:38   ` 82fef0ad811f "x86/mm: unencrypted non-blocking DMA allocations use coherent pools" was " Pavel Machek
2020-06-07 16:38     ` Pavel Machek
2020-06-07 19:41     ` David Rientjes
2020-06-07 19:41       ` David Rientjes
2020-06-07 22:53       ` Alex Xu (Hello71)
2020-06-07 22:53         ` Alex Xu (Hello71)
2020-06-08  0:57         ` David Rientjes
2020-06-08  0:57           ` David Rientjes
2020-06-08  2:13           ` Alex Xu (Hello71)
2020-06-08  2:13             ` Alex Xu (Hello71)
2020-06-08  6:19   ` Christoph Hellwig
2020-06-08  6:19     ` Christoph Hellwig
2020-06-08 13:53     ` Alex Xu (Hello71)
2020-06-08 13:53       ` Alex Xu (Hello71)
2020-06-09  2:31       ` David Rientjes
2020-06-09  2:31         ` David Rientjes
2020-06-09  5:43         ` Christoph Hellwig
2020-06-09  5:43           ` Christoph Hellwig
2020-06-09  8:05           ` Takashi Iwai
2020-06-09  8:05             ` Takashi Iwai
2020-06-09  8:43             ` Christoph Hellwig
2020-06-09  8:43               ` Christoph Hellwig
2020-06-09  9:09               ` Takashi Iwai
2020-06-09  9:09                 ` Takashi Iwai
2020-06-09  9:17                 ` Christoph Hellwig
2020-06-09  9:17                   ` Christoph Hellwig
2020-06-09  9:31                   ` Takashi Iwai
2020-06-09  9:31                     ` Takashi Iwai
2020-06-09 11:02                     ` Takashi Iwai
2020-06-09 11:02                       ` Takashi Iwai
2020-06-09 11:31                     ` Christoph Hellwig
2020-06-09 11:31                       ` Christoph Hellwig
2020-06-09 11:38                       ` Takashi Iwai
2020-06-09 11:38                         ` Takashi Iwai
2020-06-09 11:40                         ` Christoph Hellwig
2020-06-09 11:40                           ` Christoph Hellwig
2020-06-09 11:45                           ` Takashi Iwai [this message]
2020-06-09 11:45                             ` Takashi Iwai
2020-06-09 11:49                             ` Christoph Hellwig
2020-06-09 11:49                               ` Christoph Hellwig
2020-06-09 13:16                               ` Jaroslav Kysela
2020-06-09 13:16                                 ` Jaroslav Kysela
2020-06-10  5:26           ` David Rientjes
2020-06-10  5:26             ` David Rientjes
2020-06-10  7:14             ` Christoph Hellwig
2020-06-10  7:14               ` Christoph Hellwig
2020-06-09 11:47       ` Christoph Hellwig
2020-06-09 11:47         ` Christoph Hellwig
2020-06-09 15:12         ` Takashi Iwai
2020-06-09 15:12           ` Takashi Iwai
     [not found]           ` <<s5hr1uogtna.wl-tiwai@suse.de>
2020-06-11 14:51             ` Alex Xu (Hello71)
2020-06-11 14:51               ` Alex Xu (Hello71)
2020-06-11 17:11               ` Takashi Iwai
2020-06-11 17:11                 ` Takashi Iwai
2020-06-13 16:25                 ` Alex Xu (Hello71)
2020-06-13 16:25                   ` Alex Xu (Hello71)
2020-06-14  9:54                   ` Takashi Iwai
2020-06-14  9:54                     ` Takashi Iwai
2020-06-14 12:07                     ` Alex Xu (Hello71)
2020-06-14 12:07                       ` Alex Xu (Hello71)
2020-06-14 15:40                       ` Takashi Iwai
2020-06-14 15:40                         ` Takashi Iwai
2020-06-11 14:51         ` Alex Xu (Hello71)
2020-06-11 14:51           ` Alex Xu (Hello71)
     [not found] <20200520110900.GA8203@amd>
2020-05-21  7:41 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hzh9ch38h.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alex_y_xu@yahoo.ca \
    --cc=alsa-devel@alsa-project.org \
    --cc=bp@alien8.de \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=perex@perex.cz \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.