All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH alsa-lib 1/1] doc: Fix typo in PCM formats
@ 2012-03-27 15:54 Adrian Knoth
  2012-03-28 15:42 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Knoth @ 2012-03-27 15:54 UTC (permalink / raw)
  To: patch; +Cc: Adrian Knoth, alsa-devel

Of course, 24bit samples are not stored in three bits, but bytes.

Signed-off-by: Adrian Knoth <adi@drcomp.erfurt.thur.de>

diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c
index ea1afdc..18b43b3 100644
--- a/src/pcm/pcm.c
+++ b/src/pcm/pcm.c
@@ -209,13 +209,13 @@ The device is physicaly disconnected. It does not accept any I/O calls in this s
 \section pcm_formats PCM formats
 
 The full list of formats present the #snd_pcm_format_t type.
-The 24-bit linear samples uses 32-bit physical space, but the sample is
-stored in low three bits. Some hardware does not support processing of full
+The 24-bit linear samples use 32-bit physical space, but the sample is
+stored in the lower three bytes. Some hardware does not support processing of full
 range, thus you may get the significant bits for linear samples via
 #snd_pcm_hw_params_get_sbits() function. The example: ICE1712
 chips support 32-bit sample processing, but low byte is ignored (playback)
 or zero (capture). The function snd_pcm_hw_params_get_sbits()
-returns 24 in the case.
+returns 24 in this case.
 
 \section alsa_transfers ALSA transfers
 
-- 
1.7.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH alsa-lib 1/1] doc: Fix typo in PCM formats
  2012-03-27 15:54 [PATCH alsa-lib 1/1] doc: Fix typo in PCM formats Adrian Knoth
@ 2012-03-28 15:42 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2012-03-28 15:42 UTC (permalink / raw)
  To: Adrian Knoth; +Cc: alsa-devel

At Tue, 27 Mar 2012 17:54:47 +0200,
Adrian Knoth wrote:
> 
> Of course, 24bit samples are not stored in three bits, but bytes.
> 
> Signed-off-by: Adrian Knoth <adi@drcomp.erfurt.thur.de>

Applied now.  Thanks.


Takashi


> diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c
> index ea1afdc..18b43b3 100644
> --- a/src/pcm/pcm.c
> +++ b/src/pcm/pcm.c
> @@ -209,13 +209,13 @@ The device is physicaly disconnected. It does not accept any I/O calls in this s
>  \section pcm_formats PCM formats
>  
>  The full list of formats present the #snd_pcm_format_t type.
> -The 24-bit linear samples uses 32-bit physical space, but the sample is
> -stored in low three bits. Some hardware does not support processing of full
> +The 24-bit linear samples use 32-bit physical space, but the sample is
> +stored in the lower three bytes. Some hardware does not support processing of full
>  range, thus you may get the significant bits for linear samples via
>  #snd_pcm_hw_params_get_sbits() function. The example: ICE1712
>  chips support 32-bit sample processing, but low byte is ignored (playback)
>  or zero (capture). The function snd_pcm_hw_params_get_sbits()
> -returns 24 in the case.
> +returns 24 in this case.
>  
>  \section alsa_transfers ALSA transfers
>  
> -- 
> 1.7.9.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-28 15:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-27 15:54 [PATCH alsa-lib 1/1] doc: Fix typo in PCM formats Adrian Knoth
2012-03-28 15:42 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.