Re:RE: KVM Support?

Re:RE: KVM Support?

[xiuzhi]

[-- Attachment #1: Type: text/plain, Size: 3571 bytes --]

Hi Joseph, Ed,
   There was an error when I  updated the patches https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac
Would you like to give me some suggestions to debug it?
 When I logged in https://<bmc_ip>/#/kvm, The errors read:
"
WebSocket on-close event  app.89eaa0b6e5e9417cb602.js:38:675915
Failed when connecting: Connection closed (code: 1005)  app.89eaa0b6e5e9417cb602.js:38:685584
	RFB.prototype._fail https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:685584
	RFB/< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:676138
	Websock.prototype.open/this._websocket.onclose< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:778159
New state 'disconnecting', was 'connecting'.  app.89eaa0b6e5e9417cb602.js:38:684301
>> RFB.disconnect  app.89eaa0b6e5e9417cb602.js:38:680495
>> Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739659
<< Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739828
"
The line 38 of app.89eaa0b6e5e9417cb602.js is :
void 0!==module&&void 0!==exports&&module.exports===exports&&(module.exports="ui.router"),function(window,angular,undefined){"use strict";var $$UMFP,isDefined=angular.isDefined,isFunction=angular.isFunction,isString=angular.isString,isObject=angular.isObject,isArray=angular.isArray,forEach=angular.forEach,extend=angular.extend,copy=angular.copy,toJson=angular.toJson;function inherit(parent,extra){return extend(new(extend(function(){},{prototype:parent})),extra)}function merge(dst){return forEach(arguments,function(obj){obj!==dst&&forEach(obj,function(value,key){dst.hasOwnProperty(key)||(dst[key]=value)})}),dst}function objectKeys(object){if(Object.keys)return Object.keys(object);var result=[];return forEach(object,function(val,key){result.push(key)}),result}function indexOf(array,value){if(Array.prototype.indexOf)return array.indexOf(value,Number(arguments[2])||0);var len=array.length>>>0,from=Number(arguments[2])||0;for((from=from<0?Math.ceil(from):Math.floor(from))<0&&(from+=len);from<len;from++)if(from in array&&array[from]===value)return from;return-1}function inheritParams(currentParams,newParams,$current,$to) ... ...

Best,
Xiuzhi
>Hi Eddie & Ed: >Do you have any plan to support non-jpeg video stream in obmc-iKVM? >It is possible some platforms don't have hardware JPEG engine, instead have the RGB video stream. >If possible to support RGB video stream, I think it would be better if you can add the video frame differentiation in obmc-iKVM because we don't need to send the full screen >to VNC client on every request, it can reduce the buffer size at least. (libvncserver already has the video frame differentiation) >Also, I have implemented a KVM application for our platform(nuvoton evb-npcm750) which has hardware video frame differentiation and hardware hextile engine. https://github.com/Nuvoton-Israel/obmc-ikvm https://github.com/Nuvoton-Israel/linux/commit/7e90f572323e56e9425b85aafe86dfa5a35c4e7d >I also enabled ED's KVM webui and added kvmws proxy in python web server. https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac >If you can spare a few minutes to review my implementation is my pleasure. >Currently, my video driver is not v4l2, so I am going to redesign it to fit v4l2 and your obmc-iKVM, then I will try to add the RGB format support in your obmc-ikvm. >Regarding the larger binary size, I think we need to review all configurations of libvncserver and check which functions should be disabled. >Thanks, >Joseph Liu.

[-- Attachment #2: Type: text/html, Size: 4284 bytes --]

RE: Re:RE: KVM Support?

[KWLIU]

[-- Attachment #1: Type: text/plain, Size: 6171 bytes --]

Hi Xiuzhi:

I think we are using different bases of the openbmc, this patch is really working on my side
Sorry for I cannot find the exact error in your message.

Thanks,
Joseph
From: xiuzhi [mailto:1450335857@qq.com]
Sent: Tuesday, August 28, 2018 6:57 PM
To: Eddie James; Tanous, Ed; CS20 KWLiu; openbmc
Subject: Re:RE: KVM Support?

Hi Joseph, Ed,
   There was an error when I  updated the patches https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_meta-2Dopenbmc-2Dnuvoton-2Daddon_commit_140771b7e898dd5ca8f0364290cce669609088ac&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=8SWpZ_B0Z9GOpECKSppJKXXbMTo-hNO0HuXocMRt5n0&e=>

Would you like to give me some suggestions to debug it?
 When I logged in https://<bmc_ip>/#/kvm<https://%3cbmc_ip%3e/#/kvm>, The errors read:
"
WebSocket on-close event  app.89eaa0b6e5e9417cb602.js:38:675915
Failed when connecting: Connection closed (code: 1005)  app.89eaa0b6e5e9417cb602.js:38:685584
        RFB.prototype._fail https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:685584
        RFB/< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:676138
        Websock.prototype.open/this._websocket.onclose< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:778159
New state 'disconnecting', was 'connecting'.  app.89eaa0b6e5e9417cb602.js:38:684301
>> RFB.disconnect  app.89eaa0b6e5e9417cb602.js:38:680495
>> Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739659
<< Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739828
"
The line 38 of app.89eaa0b6e5e9417cb602.js is :
void 0!==module&&void 0!==exports&&module.exports===exports&&(module.exports="ui.router"),function(window,angular,undefined){"use strict";var $$UMFP,isDefined=angular.isDefined,isFunction=angular.isFunction,isString=angular.isString,isObject=angular.isObject,isArray=angular.isArray,forEach=angular.forEach,extend=angular.extend,copy=angular.copy,toJson=angular.toJson;function inherit(parent,extra){return extend(new(extend(function(){},{prototype:parent})),extra)}function merge(dst){return forEach(arguments,function(obj){obj!==dst&&forEach(obj,function(value,key){dst.hasOwnProperty(key)||(dst[key]=value)})}),dst}function objectKeys(object){if(Object.keys)return Object.keys(object);var result=[];return forEach(object,function(val,key){result.push(key)}),result}function indexOf(array,value){if(Array.prototype.indexOf)return array.indexOf(value,Number(arguments[2])||0);var len=array.length>>>0,from=Number(arguments[2])||0;for((from=from<0?Math.ceil(from):Math.floor(from))<0&&(from+=len);from<len;from++)if(from in array&&array[from]===value)return from;return-1}function inheritParams(currentParams,newParams,$current,$to) ... ...

Best,
Xiuzhi
>Hi Eddie & Ed:



>Do you have any plan to support non-jpeg video stream in obmc-iKVM?

>It is possible some platforms don't have hardware JPEG engine, instead have the RGB video stream.

>If possible to support RGB video stream, I think it would be better if you can add the video frame differentiation in obmc-iKVM because we don't need to send the full screen >to VNC client on every request, it can reduce the buffer size at least. (libvncserver already has the video frame differentiation)



>Also, I have implemented a KVM application for our platform(nuvoton evb-npcm750) which has hardware video frame differentiation and hardware hextile engine.

https://github.com/Nuvoton-Israel/obmc-ikvm<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_obmc-2Dikvm&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=92D29zgWEhIBYgHR9Q7lkZzREnMSwnqyhl1nEMyqXFM&e=>

https://github.com/Nuvoton-Israel/linux/commit/7e90f572323e56e9425b85aafe86dfa5a35c4e7d<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_linux_commit_7e90f572323e56e9425b85aafe86dfa5a35c4e7d&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=1JBlTPOERz49VFrLgiw014ZnBqab0r8xdRIe6Fee1JA&e=>



>I also enabled ED's KVM webui and added kvmws proxy in python web server.

https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_meta-2Dopenbmc-2Dnuvoton-2Daddon_commit_140771b7e898dd5ca8f0364290cce669609088ac&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=8SWpZ_B0Z9GOpECKSppJKXXbMTo-hNO0HuXocMRt5n0&e=>



>If you can spare a few minutes to review my implementation is my pleasure.



>Currently, my video driver is not v4l2, so I am going to redesign it to fit v4l2 and your obmc-iKVM, then I will try to add the RGB format support in your obmc-ikvm.



>Regarding the larger binary size, I think we need to review all configurations of libvncserver and check which functions should be disabled.



>Thanks,

>Joseph Liu.


===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

[-- Attachment #2: Type: text/html, Size: 11550 bytes --]

RE: Re:RE: KVM Support?

[Avi.Fishman]

[-- Attachment #1: Type: text/plain, Size: 8599 bytes --]

Hi Xiuzhi,

Can you take the patches and merge them to your environment?

Josef,
Maybe you need to give the commit or tag you are that above it you use your patches?

Thanks,
Avi

From: openbmc <openbmc-bounces+avifishman70=gmail.com@lists.ozlabs.org> On Behalf Of CS20 KWLiu
Sent: Wednesday, August 29, 2018 5:44 AM
To: 1450335857@qq.com; eajames@linux.vnet.ibm.com; ed.tanous@intel.com; openbmc@lists.ozlabs.org
Subject: RE: Re:RE: KVM Support?

Hi Xiuzhi:

I think we are using different bases of the openbmc, this patch is really working on my side
Sorry for I cannot find the exact error in your message.

Thanks,
Joseph
From: xiuzhi [mailto:1450335857@qq.com]
Sent: Tuesday, August 28, 2018 6:57 PM
To: Eddie James; Tanous, Ed; CS20 KWLiu; openbmc
Subject: Re:RE: KVM Support?

Hi Joseph, Ed,
   There was an error when I  updated the patches https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_meta-2Dopenbmc-2Dnuvoton-2Daddon_commit_140771b7e898dd5ca8f0364290cce669609088ac&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=8SWpZ_B0Z9GOpECKSppJKXXbMTo-hNO0HuXocMRt5n0&e=>

Would you like to give me some suggestions to debug it?
 When I logged in https://<bmc_ip>/#/kvm<https://urldefense.proofpoint.com/v2/url?u=https-3A__-253cbmc-5Fip-253e_-23_kvm&d=DwMFAg&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahPM6I78&m=xFjehOYoJW0EsYnLWkBOLeUtOCSyAFs6UdQuMvfM7y4&s=2J0BHCud5wpV8zxnLKS_sDp79AfVxVQvJ5Vk3r8dhTc&e=>, The errors read:
"
WebSocket on-close event  app.89eaa0b6e5e9417cb602.js:38:675915
Failed when connecting: Connection closed (code: 1005)  app.89eaa0b6e5e9417cb602.js:38:685584
        RFB.prototype._fail https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:685584<https://urldefense.proofpoint.com/v2/url?u=https-3A__192.168.120.132_app.89eaa0b6e5e9417cb602.js-3A38-3A685584&d=DwMFAg&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahPM6I78&m=xFjehOYoJW0EsYnLWkBOLeUtOCSyAFs6UdQuMvfM7y4&s=EgJDf5jL_gme8t1tF_wjg1-08xZxvqptSjoW3a8zohU&e=>
        RFB/< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:676138<https://urldefense.proofpoint.com/v2/url?u=https-3A__192.168.120.132_app.89eaa0b6e5e9417cb602.js-3A38-3A676138&d=DwMFAg&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahPM6I78&m=xFjehOYoJW0EsYnLWkBOLeUtOCSyAFs6UdQuMvfM7y4&s=dIWffzOhDWjQl-iTTJj_38z606ai7gLJSynBqbAZXW8&e=>
        Websock.prototype.open/this._websocket.onclose< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:778159<https://urldefense.proofpoint.com/v2/url?u=https-3A__192.168.120.132_app.89eaa0b6e5e9417cb602.js-3A38-3A778159&d=DwMFAg&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahPM6I78&m=xFjehOYoJW0EsYnLWkBOLeUtOCSyAFs6UdQuMvfM7y4&s=oJ5yHA_oCl5ihumZXKGL7rDbby1iZ0j2J4hWMLB-hEY&e=>
New state 'disconnecting', was 'connecting'.  app.89eaa0b6e5e9417cb602.js:38:684301
>> RFB.disconnect  app.89eaa0b6e5e9417cb602.js:38:680495
>> Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739659
<< Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739828
"
The line 38 of app.89eaa0b6e5e9417cb602.js is :
void 0!==module&&void 0!==exports&&module.exports===exports&&(module.exports="ui.router"),function(window,angular,undefined){"use strict";var $$UMFP,isDefined=angular.isDefined,isFunction=angular.isFunction,isString=angular.isString,isObject=angular.isObject,isArray=angular.isArray,forEach=angular.forEach,extend=angular.extend,copy=angular.copy,toJson=angular.toJson;function inherit(parent,extra){return extend(new(extend(function(){},{prototype:parent})),extra)}function merge(dst){return forEach(arguments,function(obj){obj!==dst&&forEach(obj,function(value,key){dst.hasOwnProperty(key)||(dst[key]=value)})}),dst}function objectKeys(object){if(Object.keys)return Object.keys(object);var result=[];return forEach(object,function(val,key){result.push(key)}),result}function indexOf(array,value){if(Array.prototype.indexOf)return array.indexOf(value,Number(arguments[2])||0);var len=array.length>>>0,from=Number(arguments[2])||0;for((from=from<0?Math.ceil(from):Math.floor(from))<0&&(from+=len);from<len;from++)if(from in array&&array[from]===value)return from;return-1}function inheritParams(currentParams,newParams,$current,$to) ... ...

Best,
Xiuzhi
>Hi Eddie & Ed:



>Do you have any plan to support non-jpeg video stream in obmc-iKVM?

>It is possible some platforms don't have hardware JPEG engine, instead have the RGB video stream.

>If possible to support RGB video stream, I think it would be better if you can add the video frame differentiation in obmc-iKVM because we don't need to send the full screen >to VNC client on every request, it can reduce the buffer size at least. (libvncserver already has the video frame differentiation)



>Also, I have implemented a KVM application for our platform(nuvoton evb-npcm750) which has hardware video frame differentiation and hardware hextile engine.

https://github.com/Nuvoton-Israel/obmc-ikvm<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_obmc-2Dikvm&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=92D29zgWEhIBYgHR9Q7lkZzREnMSwnqyhl1nEMyqXFM&e=>

https://github.com/Nuvoton-Israel/linux/commit/7e90f572323e56e9425b85aafe86dfa5a35c4e7d<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_linux_commit_7e90f572323e56e9425b85aafe86dfa5a35c4e7d&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=1JBlTPOERz49VFrLgiw014ZnBqab0r8xdRIe6Fee1JA&e=>



>I also enabled ED's KVM webui and added kvmws proxy in python web server.

https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvoton-2DIsrael_meta-2Dopenbmc-2Dnuvoton-2Daddon_commit_140771b7e898dd5ca8f0364290cce669609088ac&d=DwMGAw&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=Zir4Lw7xIZbwLjRk7ILcjDyeLfFVQzWjscAv2ZyvXXY&s=8SWpZ_B0Z9GOpECKSppJKXXbMTo-hNO0HuXocMRt5n0&e=>



>If you can spare a few minutes to review my implementation is my pleasure.



>Currently, my video driver is not v4l2, so I am going to redesign it to fit v4l2 and your obmc-iKVM, then I will try to add the RGB format support in your obmc-ikvm.



>Regarding the larger binary size, I think we need to review all configurations of libvncserver and check which functions should be disabled.



>Thanks,

>Joseph Liu.


===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.


===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

[-- Attachment #2: Type: text/html, Size: 16623 bytes --]

Re:RE: Re:RE: KVM Support?

[xiuzhi]

[-- Attachment #1: Type: text/plain, Size: 6902 bytes --]

Hi Avi ,Joseph,
   I checked the patches for bmc side, the rest_dbus.py on bmc was not patched sucessfully. 
The files on bmc are: 
/run/initramfs/ro/usr/lib/python2.7 /site-packages/obmc/wsgi/apps/rest_dbus.py
/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py

I patched the file on phosphor-gevent .
Now I patched  the   rest_dbus.py on phosphor-rest again,the file of bmc side has updated.
 
Now it works.



Thanks,
Xiuzhi
------------------ Original ------------------
From:  "Avi.Fishman";<Avi.Fishman@nuvoton.com>;
Date:  Aug 29, 2018
To:  "KWLIU"<KWLIU@nuvoton.com>; "xiuzhi"<1450335857@qq.com>; "eajames"<eajames@linux.vnet.ibm.com>; "ed.tanous"<ed.tanous@intel.com>; "openbmc"<openbmc@lists.ozlabs.org>; 

Subject:  RE: Re:RE: KVM Support?



  
Hi Xiuzhi,
 
 
 
Can you take the patches and merge them to your environment?
 
 
 
Josef,
 
Maybe you need to give the commit or tag you are that above it you use your patches? 
 
 
  
Thanks,
 
Avi
 
 
 
   
From: openbmc <openbmc-bounces+avifishman70=gmail.com@lists.ozlabs.org> On Behalf Of CS20 KWLiu
 Sent: Wednesday, August 29, 2018 5:44 AM
 To: 1450335857@qq.com; eajames@linux.vnet.ibm.com; ed.tanous@intel.com; openbmc@lists.ozlabs.org
 Subject: RE: Re:RE: KVM Support?
 
 
 
 
 
Hi Xiuzhi:
 
 
 
I think we are using different bases of the openbmc, this patch is really working on my side
 
Sorry for I cannot find the exact error in your message.
 
 
 
Thanks,
 
Joseph
 
From: xiuzhi [mailto:1450335857@qq.com] 
 Sent: Tuesday, August 28, 2018 6:57 PM
 To: Eddie James; Tanous, Ed; CS20 KWLiu; openbmc
 Subject: Re:RE: KVM Support?
 
 
 
Hi Joseph, Ed,
    There was an error when I  updated the patches  https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac
 Would you like to give me some suggestions to debug it?
 When I logged in https://<bmc_ip>/#/kvm, The errors read:
"
WebSocket on-close event  app.89eaa0b6e5e9417cb602.js:38:675915
Failed when connecting: Connection closed (code: 1005)  app.89eaa0b6e5e9417cb602.js:38:685584
        RFB.prototype._fail https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:685584
        RFB/< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:676138
        Websock.prototype.open/this._websocket.onclose< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:778159
New state 'disconnecting', was 'connecting'.  app.89eaa0b6e5e9417cb602.js:38:684301
>> RFB.disconnect  app.89eaa0b6e5e9417cb602.js:38:680495
>> Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739659
<< Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739828
"
The line 38 of app.89eaa0b6e5e9417cb602.js is :
void 0!==module&&void 0!==exports&&module.exports===exports&&(module.exports="ui.router"),function(window,angular,undefined){"use strict";var $$UMFP,isDefined=angular.isDefined,isFunction=angular.isFunction,isString=angular.isString,isObject=angular.isObject,isArray=angular.isArray,forEach=angular.forEach,extend=angular.extend,copy=angular.copy,toJson=angular.toJson;function inherit(parent,extra){return extend(new(extend(function(){},{prototype:parent})),extra)}function merge(dst){return forEach(arguments,function(obj){obj!==dst&&forEach(obj,function(value,key){dst.hasOwnProperty(key)||(dst[key]=value)})}),dst}function objectKeys(object){if(Object.keys)return Object.keys(object);var result=[];return forEach(object,function(val,key){result.push(key)}),result}function indexOf(array,value){if(Array.prototype.indexOf)return array.indexOf(value,Number(arguments[2])||0);var len=array.length>>>0,from=Number(arguments[2])||0;for((from=from<0?Math.ceil(from):Math.floor(from))<0&&(from+=len);from<len;from++)if(from in array&&array[from]===value)return from;return-1}function inheritParams(currentParams,newParams,$current,$to) ... ...

Best,
Xiuzhi
>Hi Eddie & Ed:   >Do you have any plan to support non-jpeg video stream in obmc-iKVM? >It is possible some platforms don't have hardware JPEG engine, instead have the RGB video stream. >If possible to support RGB video stream, I think it would be better if you can add the video frame differentiation in obmc-iKVM because we don't need to send the full screen >to VNC client on every request, it can reduce the buffer size at least. (libvncserver already has the video frame differentiation)   >Also, I have implemented a KVM application for our platform(nuvoton evb-npcm750) which has hardware video frame differentiation and hardware hextile engine. https://github.com/Nuvoton-Israel/obmc-ikvm https://github.com/Nuvoton-Israel/linux/commit/7e90f572323e56e9425b85aafe86dfa5a35c4e7d   >I also enabled ED's KVM webui and added kvmws proxy in python web server. https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac   >If you can spare a few minutes to review my implementation is my pleasure.   >Currently, my video driver is not v4l2, so I am going to redesign it to fit v4l2 and your obmc-iKVM, then I will try to add the RGB format support in your obmc-ikvm.   >Regarding the larger binary size, I think we need to review all configurations of libvncserver and check which functions should be disabled.   >Thanks, >Joseph Liu. 

 
 ===========================================================================================
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email  to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information  of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
 
 
 
 ===========================================================================================
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email  to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information  of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

[-- Attachment #2: Type: text/html, Size: 14243 bytes --]

Re:RE: Re:RE: KVM Support?

[xiuzhi]

[-- Attachment #1: Type: text/plain, Size: 7063 bytes --]

Hi  Eddie,Joseph,
    The webui can't get ikvm video when the host resolution changed .
I must kill the process :python /usr/sbin/phosphor-gevent rest_dbus.py
and restart obmc-ikvm -v /dev/video0 -i /dev/hidg0
Then the kvm on webui can get the host video image .
The system log is:
  [ 9052.912683] aspeed-video 1e700000.video: resolution changed; resetting
[ 9054.406876] aspeed-video 1e700000.video: timed out on 1st mode detect
[ 9054.413380] aspeed-video 1e700000.video: resolution changed; couldn't get new resolution


Do you have any idea to auto restart the obmc-ikvm and ?rest_dbus.py
xiuzhi
------------------ Original ------------------
From:  "Avi.Fishman";<Avi.Fishman@nuvoton.com>;
Date:  Aug 29, 2018
To:  "KWLIU"<KWLIU@nuvoton.com>; "xiuzhi"<1450335857@qq.com>; "eajames"<eajames@linux.vnet.ibm.com>; "ed.tanous"<ed.tanous@intel.com>; "openbmc"<openbmc@lists.ozlabs.org>; 

Subject:  RE: Re:RE: KVM Support?



  
Hi Xiuzhi,
 
 
 
Can you take the patches and merge them to your environment?
 
 
 
Josef,
 
Maybe you need to give the commit or tag you are that above it you use your patches? 
 
 
  
Thanks,
 
Avi
 
 
 
   
From: openbmc <openbmc-bounces+avifishman70=gmail.com@lists.ozlabs.org> On Behalf Of CS20 KWLiu
 Sent: Wednesday, August 29, 2018 5:44 AM
 To: 1450335857@qq.com; eajames@linux.vnet.ibm.com; ed.tanous@intel.com; openbmc@lists.ozlabs.org
 Subject: RE: Re:RE: KVM Support?
 
 
 
 
 
Hi Xiuzhi:
 
 
 
I think we are using different bases of the openbmc, this patch is really working on my side
 
Sorry for I cannot find the exact error in your message.
 
 
 
Thanks,
 
Joseph
 
From: xiuzhi [mailto:1450335857@qq.com] 
 Sent: Tuesday, August 28, 2018 6:57 PM
 To: Eddie James; Tanous, Ed; CS20 KWLiu; openbmc
 Subject: Re:RE: KVM Support?
 
 
 
Hi Joseph, Ed,
    There was an error when I  updated the patches  https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac
 Would you like to give me some suggestions to debug it?
 When I logged in https://<bmc_ip>/#/kvm, The errors read:
"
WebSocket on-close event  app.89eaa0b6e5e9417cb602.js:38:675915
Failed when connecting: Connection closed (code: 1005)  app.89eaa0b6e5e9417cb602.js:38:685584
        RFB.prototype._fail https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:685584
        RFB/< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:676138
        Websock.prototype.open/this._websocket.onclose< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:778159
New state 'disconnecting', was 'connecting'.  app.89eaa0b6e5e9417cb602.js:38:684301
>> RFB.disconnect  app.89eaa0b6e5e9417cb602.js:38:680495
>> Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739659
<< Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739828
"
The line 38 of app.89eaa0b6e5e9417cb602.js is :
void 0!==module&&void 0!==exports&&module.exports===exports&&(module.exports="ui.router"),function(window,angular,undefined){"use strict";var $$UMFP,isDefined=angular.isDefined,isFunction=angular.isFunction,isString=angular.isString,isObject=angular.isObject,isArray=angular.isArray,forEach=angular.forEach,extend=angular.extend,copy=angular.copy,toJson=angular.toJson;function inherit(parent,extra){return extend(new(extend(function(){},{prototype:parent})),extra)}function merge(dst){return forEach(arguments,function(obj){obj!==dst&&forEach(obj,function(value,key){dst.hasOwnProperty(key)||(dst[key]=value)})}),dst}function objectKeys(object){if(Object.keys)return Object.keys(object);var result=[];return forEach(object,function(val,key){result.push(key)}),result}function indexOf(array,value){if(Array.prototype.indexOf)return array.indexOf(value,Number(arguments[2])||0);var len=array.length>>>0,from=Number(arguments[2])||0;for((from=from<0?Math.ceil(from):Math.floor(from))<0&&(from+=len);from<len;from++)if(from in array&&array[from]===value)return from;return-1}function inheritParams(currentParams,newParams,$current,$to) ... ...

Best,
Xiuzhi
>Hi Eddie & Ed:   >Do you have any plan to support non-jpeg video stream in obmc-iKVM? >It is possible some platforms don't have hardware JPEG engine, instead have the RGB video stream. >If possible to support RGB video stream, I think it would be better if you can add the video frame differentiation in obmc-iKVM because we don't need to send the full screen >to VNC client on every request, it can reduce the buffer size at least. (libvncserver already has the video frame differentiation)   >Also, I have implemented a KVM application for our platform(nuvoton evb-npcm750) which has hardware video frame differentiation and hardware hextile engine. https://github.com/Nuvoton-Israel/obmc-ikvm https://github.com/Nuvoton-Israel/linux/commit/7e90f572323e56e9425b85aafe86dfa5a35c4e7d   >I also enabled ED's KVM webui and added kvmws proxy in python web server. https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac   >If you can spare a few minutes to review my implementation is my pleasure.   >Currently, my video driver is not v4l2, so I am going to redesign it to fit v4l2 and your obmc-iKVM, then I will try to add the RGB format support in your obmc-ikvm.   >Regarding the larger binary size, I think we need to review all configurations of libvncserver and check which functions should be disabled.   >Thanks, >Joseph Liu. 

 
 ===========================================================================================
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email  to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information  of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
 
 
 
 ===========================================================================================
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email  to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information  of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

[-- Attachment #2: Type: text/html, Size: 15180 bytes --]

Re:RE: Re:RE: KVM Support?

[xiuzhi]

[-- Attachment #1: Type: text/plain, Size: 7646 bytes --]

Hi Avi ,Joseph,
   I can't get the host screen after  updating  openbmc source to  to latest version (Oct 31 commit 7baabe48d8a2a30857994f222925505750728e39).
The  error of opening the webpage https//xxxx/#kvm   is :
Refused to load the image 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAHCAYAAAA1WQxeAAAAOklEQVQYV2P8////fwYoYGRkZAQxUcRAHJA4SB2yArgYTAdMAMRH1gA2ElkRlA03DW4nThMIuoGQLwCKQ0b4DNy9fwAAAABJRU5ErkJggg==' because it violates the following Content Security Policy directive: "default-src 'self' wss: 'unsafe-eval' 'unsafe-inline'". Note that 'img-src' was not explicitly set, so 'default-src' is used as a fallback
  
  Can you give me  advice on how to modify the 0001-Implement-KVM-in-webui.patch ?
Best,
xiuzhi


Hi Avi ,Joseph,
   I checked the patches for bmc side, the rest_dbus.py on bmc was not patched sucessfully. 
The files on bmc are: 
/run/initramfs/ro/usr/lib/python2.7 /site-packages/obmc/wsgi/apps/rest_dbus.py
/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py

I patched the file on phosphor-gevent .
Now I patched  the   rest_dbus.py on phosphor-rest again,the file of bmc side has updated.
 
Now it works.



Thanks,
Xiuzhi
------------------ Original ------------------
From:  "Avi.Fishman";<Avi.Fishman@nuvoton.com>;
Date:  Aug 29, 2018
To:  "KWLIU"<KWLIU@nuvoton.com>; "xiuzhi"<1450335857@qq.com>; "eajames"<eajames@linux.vnet.ibm.com>; "ed.tanous"<ed.tanous@intel.com>; "openbmc"<openbmc@lists.ozlabs.org>; 

Subject:  RE: Re:RE: KVM Support?



  
Hi Xiuzhi,
 
 
 
Can you take the patches and merge them to your environment?
 
 
 
Josef,
 
Maybe you need to give the commit or tag you are that above it you use your patches? 
 
 
  
Thanks,
 
Avi
 
 
 
   
From: openbmc <openbmc-bounces+avifishman70=gmail.com@lists.ozlabs.org> On Behalf Of CS20 KWLiu
 Sent: Wednesday, August 29, 2018 5:44 AM
 To: 1450335857@qq.com; eajames@linux.vnet.ibm.com; ed.tanous@intel.com; openbmc@lists.ozlabs.org
 Subject: RE: Re:RE: KVM Support?
 
 
 
 
 
Hi Xiuzhi:
 
 
 
I think we are using different bases of the openbmc, this patch is really working on my side
 
Sorry for I cannot find the exact error in your message.
 
 
 
Thanks,
 
Joseph
 
From: xiuzhi [mailto:1450335857@qq.com] 
 Sent: Tuesday, August 28, 2018 6:57 PM
 To: Eddie James; Tanous, Ed; CS20 KWLiu; openbmc
 Subject: Re:RE: KVM Support?
 
 
 
Hi Joseph, Ed,
    There was an error when I  updated the patches  https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac
 Would you like to give me some suggestions to debug it?
 When I logged in https://<bmc_ip>/#/kvm, The errors read:
"
WebSocket on-close event  app.89eaa0b6e5e9417cb602.js:38:675915
Failed when connecting: Connection closed (code: 1005)  app.89eaa0b6e5e9417cb602.js:38:685584
        RFB.prototype._fail https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:685584
        RFB/< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:676138
        Websock.prototype.open/this._websocket.onclose< https://192.168.120.132/app.89eaa0b6e5e9417cb602.js:38:778159
New state 'disconnecting', was 'connecting'.  app.89eaa0b6e5e9417cb602.js:38:684301
>> RFB.disconnect  app.89eaa0b6e5e9417cb602.js:38:680495
>> Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739659
<< Keyboard.allKeysUp  app.89eaa0b6e5e9417cb602.js:38:739828
"
The line 38 of app.89eaa0b6e5e9417cb602.js is :
void 0!==module&&void 0!==exports&&module.exports===exports&&(module.exports="ui.router"),function(window,angular,undefined){"use strict";var $$UMFP,isDefined=angular.isDefined,isFunction=angular.isFunction,isString=angular.isString,isObject=angular.isObject,isArray=angular.isArray,forEach=angular.forEach,extend=angular.extend,copy=angular.copy,toJson=angular.toJson;function inherit(parent,extra){return extend(new(extend(function(){},{prototype:parent})),extra)}function merge(dst){return forEach(arguments,function(obj){obj!==dst&&forEach(obj,function(value,key){dst.hasOwnProperty(key)||(dst[key]=value)})}),dst}function objectKeys(object){if(Object.keys)return Object.keys(object);var result=[];return forEach(object,function(val,key){result.push(key)}),result}function indexOf(array,value){if(Array.prototype.indexOf)return array.indexOf(value,Number(arguments[2])||0);var len=array.length>>>0,from=Number(arguments[2])||0;for((from=from<0?Math.ceil(from):Math.floor(from))<0&&(from+=len);from<len;from++)if(from in array&&array[from]===value)return from;return-1}function inheritParams(currentParams,newParams,$current,$to) ... ...

Best,
Xiuzhi
>Hi Eddie & Ed:   >Do you have any plan to support non-jpeg video stream in obmc-iKVM? >It is possible some platforms don't have hardware JPEG engine, instead have the RGB video stream. >If possible to support RGB video stream, I think it would be better if you can add the video frame differentiation in obmc-iKVM because we don't need to send the full screen >to VNC client on every request, it can reduce the buffer size at least. (libvncserver already has the video frame differentiation)   >Also, I have implemented a KVM application for our platform(nuvoton evb-npcm750) which has hardware video frame differentiation and hardware hextile engine. https://github.com/Nuvoton-Israel/obmc-ikvm https://github.com/Nuvoton-Israel/linux/commit/7e90f572323e56e9425b85aafe86dfa5a35c4e7d   >I also enabled ED's KVM webui and added kvmws proxy in python web server. https://github.com/Nuvoton-Israel/meta-openbmc-nuvoton-addon/commit/140771b7e898dd5ca8f0364290cce669609088ac   >If you can spare a few minutes to review my implementation is my pleasure.   >Currently, my video driver is not v4l2, so I am going to redesign it to fit v4l2 and your obmc-iKVM, then I will try to add the RGB format support in your obmc-ikvm.   >Regarding the larger binary size, I think we need to review all configurations of libvncserver and check which functions should be disabled.   >Thanks, >Joseph Liu. 

 
 ===========================================================================================
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email  to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information  of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
 
 
 
 ===========================================================================================
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email  to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information  of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

[-- Attachment #2: Type: text/html, Size: 15545 bytes --]