soc camera driver module may case memory leak

soc camera driver module may case memory leak

[=?gb18030?B?1Nm72MrX?=]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 106 bytes --]

Dear sir:
soc camera driver module may case memory leak

https://bugzilla.kernel.org/show_bug.cgi?id=49991

Re: soc camera driver module may case memory leak

[Guennadi Liakhovetski]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=utf-8, Size: 1016 bytes --]

Hi

On Mon, 5 Nov 2012, å~F~Må~[~^é¦~V wrote:

> Dear sir:
> why not call "videobuf_mmap_free",when device close call "soc_camera_close" in linux-2.6.x;

I haven't found any version, where this has been done. I don't think this 
is needed, because videobuf mmap allocations will be freed automatically 
upon the last close(). Please, dismiss your bugzilla entry.

Thanks
Guennadi

> do the same in linux-3.x.x?
> video capture flow:
> 1)open
> 2)set fmt
> 3)request buffer-->__videobuf_mmap_setup-->videobuf_alloc_vb(q)
> 4)mmap
> 5)enqueue, dequeue
> 6)unmap
> 7)close--->soc_camera_close-->?should call:videobuf_mmap_free
> NOTE:
> I have reviewed all the code, found:soc_camera_driver device driver coders has no way(callback function) to call videobuf_mmap_free; it will case memory leak.N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±™çbj)í…æèw*\x1fjg¬±¨\x1e¶‰šŽŠÝ¢j/êäz¹Þ–Šà2ŠÞ™¨è­Ú&¢)ß¡«a¶Ú\x7fþø\x1e®G«éh®\x0fæj:+v‰¨Šwè†Ù¥

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

soc camera driver module may case memory leak

[再回首]

Dear sir:
why not call "videobuf_mmap_free",when device close call "soc_camera_close" in linux-2.6.x;do the same in linux-3.x.x?
video capture flow:
1)open
2)set fmt
3)request buffer-->__videobuf_mmap_setup-->videobuf_alloc_vb(q)
4)mmap
5)enqueue, dequeue
6)unmap
7)close--->soc_camera_close-->?should call:videobuf_mmap_free
NOTE:
I have reviewed all the code, found:soc_camera_driver device driver coders has no way(callback function) to call videobuf_mmap_free; it will case memory leak.