From: nh26223@qq.com To: nh26223@qq.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, mike.kravetz@oracle.com, akpm@linux-foundation.org, sj@kernel.org, Baolin Wang <baolin.wang@linux.alibaba.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 1/3] arm64/hugetlb: Introduce new huge_ptep_get_access_flags() interface Date: Mon, 09 May 2022 12:10:17 +0800 [thread overview] Message-ID: <tencent_4743B3E2F61F15E3BBF4251CAF3C0810B207@qq.com> (raw) In-Reply-To: <5e33cf5e-2c48-89fe-3447-2f29c7844928@linux.alibaba.com> ----------------8<--------------- > >> > >> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > >> index ca8e65c..ce39699 100644 > >> --- a/arch/arm64/mm/hugetlbpage.c > >> +++ b/arch/arm64/mm/hugetlbpage.c > >> @@ -158,6 +158,30 @@ static inline int num_contig_ptes(unsigned long > >> size, > >> size_t *pgsize) return contig_ptes; > >> > >> } > >> > >> +pte_t huge_ptep_get_access_flags(pte_t *ptep, unsigned long sz) > > > > The function name looks to me that it returns access flags of PTE. > > Yes, not a good name. That's why this is a RFC patch set to get more > suggestion :) > > Maybe huge_ptep_get_with_access_flags()? or do you have some better idea? I don't have either. "Naming is hard". :) > >> diff --git a/include/asm-generic/hugetlb.h > >> b/include/asm-generic/hugetlb.h > >> index a57d667..bb77fb0 100644 > >> --- a/include/asm-generic/hugetlb.h > >> +++ b/include/asm-generic/hugetlb.h > >> @@ -150,6 +150,13 @@ static inline pte_t huge_ptep_get(pte_t *ptep) > >> > >> } > >> #endif > >> > >> +#ifndef __HAVE_ARCH_HUGE_PTEP_GET_ACCESS_FLAGS > >> +static inline pte_t huge_ptep_get_access_flags(pte_t *ptep, unsigned > >> long > >> sz) +{ > >> + return ptep_get(ptep); > > > > Should be: > > return huge_ptep_get(ptep) ? > > I don't think so. If no ARCH-specific definition, the > huge_ptep_get_access_flags() implementation should be same as > huge_ptep_get(). Thanks for your comments. If no __HAVE_ARCH_HUGE_PTEP_GET, huge_ptep_get() is same as ptep_get(). Or it's not possible no __HAVE_ARCH_HUGE_PTEP_GET_ACCESS_FLAGS but with __HAVE_ARCH_HUGE_PTEP_GET? Regards Yin, Fengwei > > #ifndef __HAVE_ARCH_HUGE_PTEP_GET > static inline pte_t huge_ptep_get(pte_t *ptep) > { > return ptep_get(ptep); > } > #endif
WARNING: multiple messages have this Message-ID (diff)
From: nh26223@qq.com To: nh26223@qq.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, mike.kravetz@oracle.com, akpm@linux-foundation.org, sj@kernel.org, Baolin Wang <baolin.wang@linux.alibaba.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 1/3] arm64/hugetlb: Introduce new huge_ptep_get_access_flags() interface Date: Mon, 09 May 2022 12:10:17 +0800 [thread overview] Message-ID: <tencent_4743B3E2F61F15E3BBF4251CAF3C0810B207@qq.com> (raw) In-Reply-To: <5e33cf5e-2c48-89fe-3447-2f29c7844928@linux.alibaba.com> ----------------8<--------------- > >> > >> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > >> index ca8e65c..ce39699 100644 > >> --- a/arch/arm64/mm/hugetlbpage.c > >> +++ b/arch/arm64/mm/hugetlbpage.c > >> @@ -158,6 +158,30 @@ static inline int num_contig_ptes(unsigned long > >> size, > >> size_t *pgsize) return contig_ptes; > >> > >> } > >> > >> +pte_t huge_ptep_get_access_flags(pte_t *ptep, unsigned long sz) > > > > The function name looks to me that it returns access flags of PTE. > > Yes, not a good name. That's why this is a RFC patch set to get more > suggestion :) > > Maybe huge_ptep_get_with_access_flags()? or do you have some better idea? I don't have either. "Naming is hard". :) > >> diff --git a/include/asm-generic/hugetlb.h > >> b/include/asm-generic/hugetlb.h > >> index a57d667..bb77fb0 100644 > >> --- a/include/asm-generic/hugetlb.h > >> +++ b/include/asm-generic/hugetlb.h > >> @@ -150,6 +150,13 @@ static inline pte_t huge_ptep_get(pte_t *ptep) > >> > >> } > >> #endif > >> > >> +#ifndef __HAVE_ARCH_HUGE_PTEP_GET_ACCESS_FLAGS > >> +static inline pte_t huge_ptep_get_access_flags(pte_t *ptep, unsigned > >> long > >> sz) +{ > >> + return ptep_get(ptep); > > > > Should be: > > return huge_ptep_get(ptep) ? > > I don't think so. If no ARCH-specific definition, the > huge_ptep_get_access_flags() implementation should be same as > huge_ptep_get(). Thanks for your comments. If no __HAVE_ARCH_HUGE_PTEP_GET, huge_ptep_get() is same as ptep_get(). Or it's not possible no __HAVE_ARCH_HUGE_PTEP_GET_ACCESS_FLAGS but with __HAVE_ARCH_HUGE_PTEP_GET? Regards Yin, Fengwei > > #ifndef __HAVE_ARCH_HUGE_PTEP_GET > static inline pte_t huge_ptep_get(pte_t *ptep) > { > return ptep_get(ptep); > } > #endif _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-09 4:10 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-08 8:58 [RFC PATCH 0/3] Introduce new huge_ptep_get_access_flags() interface Baolin Wang 2022-05-08 8:58 ` Baolin Wang 2022-05-08 8:58 ` [RFC PATCH 1/3] arm64/hugetlb: " Baolin Wang 2022-05-08 8:58 ` Baolin Wang 2022-05-08 13:14 ` nh26223 2022-05-08 13:14 ` nh26223 2022-05-09 1:19 ` Baolin Wang 2022-05-09 1:19 ` Baolin Wang 2022-05-09 4:10 ` nh26223 [this message] 2022-05-09 4:10 ` nh26223 2022-05-09 4:19 ` Baolin Wang 2022-05-09 4:19 ` Baolin Wang 2022-05-08 8:58 ` [RFC PATCH 2/3] fs/proc/task_mmu: Change to use huge_ptep_get_access_flags() Baolin Wang 2022-05-08 8:58 ` Baolin Wang 2022-05-08 8:58 ` [RFC PATCH 3/3] mm/damon/vaddr: " Baolin Wang 2022-05-08 8:58 ` Baolin Wang 2022-05-08 12:41 ` kernel test robot 2022-05-08 15:26 ` [RFC PATCH 0/3] Introduce new huge_ptep_get_access_flags() interface Muchun Song 2022-05-08 15:26 ` Muchun Song 2022-05-09 1:34 ` Baolin Wang 2022-05-09 1:34 ` Baolin Wang 2022-05-08 17:08 ` Matthew Wilcox 2022-05-08 17:08 ` Matthew Wilcox 2022-05-09 1:53 ` Baolin Wang 2022-05-09 1:53 ` Baolin Wang 2022-05-09 2:54 ` Muchun Song 2022-05-09 2:54 ` Muchun Song
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_4743B3E2F61F15E3BBF4251CAF3C0810B207@qq.com \ --to=nh26223@qq.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=baolin.wang@linux.alibaba.com \ --cc=catalin.marinas@arm.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mike.kravetz@oracle.com \ --cc=sj@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.