* [PATCH] nfs: nfs4clinet: check the return value of kstrdup()
@ 2021-12-13 3:00 Xiaoke Wang
2021-12-16 16:39 ` Anna Schumaker
0 siblings, 1 reply; 2+ messages in thread
From: Xiaoke Wang @ 2021-12-13 3:00 UTC (permalink / raw)
To: trond.myklebust, anna.schumaker; +Cc: linux-nfs, linux-kernel, Xiaoke Wang
kstrdup() returns NULL when some internal memory errors happen, it is
better to check the return value of it so to catch the memory error in
time.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
---
fs/nfs/nfs4client.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
index af57332..89f13e0 100644
--- a/fs/nfs/nfs4client.c
+++ b/fs/nfs/nfs4client.c
@@ -1372,5 +1372,8 @@ int nfs4_update_server(struct nfs_server *server, const char *hostname,
server->nfs_client->cl_hostname = kstrdup(hostname, GFP_KERNEL);
nfs_server_insert_lists(server);
+ if (server->nfs_client->cl_hostname == NULL)
+ return -ENOMEM;
+
return nfs_probe_destination(server);
}
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs: nfs4clinet: check the return value of kstrdup()
2021-12-13 3:00 [PATCH] nfs: nfs4clinet: check the return value of kstrdup() Xiaoke Wang
@ 2021-12-16 16:39 ` Anna Schumaker
0 siblings, 0 replies; 2+ messages in thread
From: Anna Schumaker @ 2021-12-16 16:39 UTC (permalink / raw)
To: Xiaoke Wang
Cc: Trond Myklebust, Linux NFS Mailing List, Linux Kernel Mailing List
Hi Xiaoke,
On Mon, Dec 13, 2021 at 2:54 AM Xiaoke Wang <xkernel.wang@foxmail.com> wrote:
>
> kstrdup() returns NULL when some internal memory errors happen, it is
> better to check the return value of it so to catch the memory error in
> time.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> fs/nfs/nfs4client.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
> index af57332..89f13e0 100644
> --- a/fs/nfs/nfs4client.c
> +++ b/fs/nfs/nfs4client.c
> @@ -1372,5 +1372,8 @@ int nfs4_update_server(struct nfs_server *server, const char *hostname,
> server->nfs_client->cl_hostname = kstrdup(hostname, GFP_KERNEL);
> nfs_server_insert_lists(server);
>
> + if (server->nfs_client->cl_hostname == NULL)
> + return -ENOMEM;
> +
Checking the return of kstrdup() makes sense, but I think this should
right after the kstrdup() call and still under that if block.
Anna
> return nfs_probe_destination(server);
> }
> --
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 3:00 [PATCH] nfs: nfs4clinet: check the return value of kstrdup() Xiaoke Wang
2021-12-16 16:39 ` Anna Schumaker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.