All of lore.kernel.org
 help / color / mirror / Atom feed
* [tip:x86/urgent] x86, cpufeature: Suppress compiler warning with gcc 3.x
       [not found] <201008300127.o7U1RC6Z044051@www262.sakura.ne.jp>
@ 2010-09-13 21:54 ` tip-bot for Tetsuo Handa
  0 siblings, 0 replies; only message in thread
From: tip-bot for Tetsuo Handa @ 2010-09-13 21:54 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, penguin-kernel, tglx, hpa

Commit-ID:  2fd818642a3c3a257f3b1262145a52bc1bfebd26
Gitweb:     http://git.kernel.org/tip/2fd818642a3c3a257f3b1262145a52bc1bfebd26
Author:     Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
AuthorDate: Mon, 30 Aug 2010 09:45:40 +0900
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Mon, 13 Sep 2010 14:48:41 -0700

x86, cpufeature: Suppress compiler warning with gcc 3.x

Gcc 3.x generates a warning

  arch/x86/include/asm/cpufeature.h: In function `__static_cpu_has':
  arch/x86/include/asm/cpufeature.h:326: warning: asm operand 1 probably doesn't match constraints

on each file.
But static_cpu_has() for gcc 3.x does not need __static_cpu_has().

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
LKML-Reference: <201008300127.o7U1RC6Z044051@www262.sakura.ne.jp>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/include/asm/cpufeature.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index 781a50b..c6fbb7b 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -296,6 +296,7 @@ extern const char * const x86_power_flags[32];
 
 #endif /* CONFIG_X86_64 */
 
+#if __GNUC__ >= 4
 /*
  * Static testing of CPU features.  Used the same as boot_cpu_has().
  * These are only valid after alternatives have run, but will statically
@@ -304,7 +305,7 @@ extern const char * const x86_power_flags[32];
  */
 static __always_inline __pure bool __static_cpu_has(u16 bit)
 {
-#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)
+#if __GNUC__ > 4 || __GNUC_MINOR__ >= 5
 		asm goto("1: jmp %l[t_no]\n"
 			 "2:\n"
 			 ".section .altinstructions,\"a\"\n"
@@ -345,7 +346,6 @@ static __always_inline __pure bool __static_cpu_has(u16 bit)
 #endif
 }
 
-#if __GNUC__ >= 4
 #define static_cpu_has(bit)					\
 (								\
 	__builtin_constant_p(boot_cpu_has(bit)) ?		\

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-09-13 21:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <201008300127.o7U1RC6Z044051@www262.sakura.ne.jp>
2010-09-13 21:54 ` [tip:x86/urgent] x86, cpufeature: Suppress compiler warning with gcc 3.x tip-bot for Tetsuo Handa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.