All of lore.kernel.org
 help / color / mirror / Atom feed
* [tip:perf/core] tools lib traceevent: Add missing break in make_bprint_args
@ 2012-07-06 11:20 tip-bot for Peter Huewe
  0 siblings, 0 replies; only message in thread
From: tip-bot for Peter Huewe @ 2012-07-06 11:20 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, rostedt, peterhuewe, tglx, namhyung

Commit-ID:  c9bbabe32a231b5caa8c42fa6783405346983c59
Gitweb:     http://git.kernel.org/tip/c9bbabe32a231b5caa8c42fa6783405346983c59
Author:     Peter Huewe <peterhuewe@gmx.de>
AuthorDate: Tue, 24 Apr 2012 23:19:40 +0200
Committer:  Namhyung Kim <namhyung@kernel.org>
CommitDate: Wed, 4 Jul 2012 13:40:31 +0900

tools lib traceevent: Add missing break in make_bprint_args

In the current code we assign vsize=8 and then fall through to the
default and assign vsize=1. -> probably the break is missing here,
otherwise we can remove the case.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/n/tip-3fxjy46h2tr9pl0spv7tems6@git.kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/lib/traceevent/event-parse.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 8630160..f880db4 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -3594,6 +3594,7 @@ static struct print_arg *make_bprint_args(char *fmt, void *data, int size, struc
 					break;
 				case 2:
 					vsize = 8;
+					break;
 				default:
 					vsize = ls; /* ? */
 					break;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-06 11:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-06 11:20 [tip:perf/core] tools lib traceevent: Add missing break in make_bprint_args tip-bot for Peter Huewe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.