From: tip-bot for Markus Elfring <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: wangnan0@huawei.com, ravi.bangoria@linux.vnet.ibm.com,
acme@redhat.com, peterz@infradead.org, hekuang@huawei.com,
alexander.shishkin@linux.intel.com, mingo@kernel.org,
milian.wolff@kdab.com, elfring@users.sourceforge.net,
mhiramat@kernel.org, hpa@zytor.com, adrian.hunter@intel.com,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Subject: [tip:perf/core] perf probe: Delete an unnecessary check in try_to_find_absolute_address()
Date: Thu, 26 Jan 2017 07:28:39 -0800 [thread overview]
Message-ID: <tip-42e233cacc052bd545417c68155f2b9abd1bab72@git.kernel.org> (raw)
In-Reply-To: <a3f2473b-6383-a326-bce0-b826423608b8@users.sourceforge.net>
Commit-ID: 42e233cacc052bd545417c68155f2b9abd1bab72
Gitweb: http://git.kernel.org/tip/42e233cacc052bd545417c68155f2b9abd1bab72
Author: Markus Elfring <elfring@users.sourceforge.net>
AuthorDate: Mon, 23 Jan 2017 14:54:26 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 26 Jan 2017 11:42:55 -0300
perf probe: Delete an unnecessary check in try_to_find_absolute_address()
Remove a condition check which is unnecessary at the end
because this source code place should usually only be reached
with a non-zero pointer.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/a3f2473b-6383-a326-bce0-b826423608b8@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/probe-event.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 4a57c8a..cdfc468 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -3004,10 +3004,8 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev,
return 1;
errout:
- if (*tevs) {
- clear_probe_trace_events(*tevs, 1);
- *tevs = NULL;
- }
+ clear_probe_trace_events(*tevs, 1);
+ *tevs = NULL;
return err;
}
next prev parent reply other threads:[~2017-01-26 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 15:20 [PATCH 0/4] perf: Fine-tuning for three function implementations SF Markus Elfring
2017-01-23 15:20 ` SF Markus Elfring
2017-01-23 15:22 ` [PATCH 1/4] perf probe: Delete an unnecessary check in try_to_find_absolute_address() SF Markus Elfring
2017-01-23 15:22 ` SF Markus Elfring
2017-01-23 22:48 ` Masami Hiramatsu
2017-01-23 22:48 ` Masami Hiramatsu
2017-01-26 15:28 ` tip-bot for Markus Elfring [this message]
2017-01-23 15:24 ` [PATCH 2/4] perf probe: Delete an unnecessary assignment " SF Markus Elfring
2017-01-23 15:24 ` SF Markus Elfring
2017-01-23 22:47 ` Masami Hiramatsu
2017-01-23 22:47 ` Masami Hiramatsu
2017-01-26 15:29 ` [tip:perf/core] " tip-bot for Markus Elfring
2017-01-23 15:25 ` [PATCH 3/4] perf session: Move an error code assignment in __perf_session__set_tracepoints_handlers() SF Markus Elfring
2017-01-23 15:25 ` [PATCH 3/4] perf session: Move an error code assignment in __perf_session__set_tracepoints_handlers( SF Markus Elfring
2017-01-23 22:56 ` [PATCH 3/4] perf session: Move an error code assignment in __perf_session__set_tracepoints_handlers() Masami Hiramatsu
2017-01-23 22:56 ` [PATCH 3/4] perf session: Move an error code assignment in __perf_session__set_tracepoints_handl Masami Hiramatsu
2017-01-23 15:26 ` [PATCH 4/4] perf strlist: Move an error code assignment in strlist__parse_list_entry() SF Markus Elfring
2017-01-23 15:26 ` SF Markus Elfring
2017-01-23 23:32 ` Masami Hiramatsu
2017-01-23 23:32 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-42e233cacc052bd545417c68155f2b9abd1bab72@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=elfring@users.sourceforge.net \
--cc=hekuang@huawei.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.