All of lore.kernel.org
 help / color / mirror / Atom feed
* [patchlet] perf_counter tools: add --input=file option to builtin-sched.c
@ 2009-09-18  6:22 Mike Galbraith
  2009-09-18  6:37 ` Ingo Molnar
  2009-09-18  6:39 ` [tip:perfcounters/core] perf sched: Add " tip-bot for Mike Galbraith
  0 siblings, 2 replies; 3+ messages in thread
From: Mike Galbraith @ 2009-09-18  6:22 UTC (permalink / raw)
  To: LKML; +Cc: Peter Zijlstra, Ingo Molnar


perf_counter tools: add --input=file option to builtin-sched.c.

perf sched record passes unparsed args on to perf record, so specifying an output
file via perf sched record -o FILE (cmd) just works.  Ergo, provide an option to
specify input file as well.

Also add the missing 'map' command to help.

Signed-off-by: Mike Galbraith <efault@gmx.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <new-submission>

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 9e04827..275d79c 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1859,11 +1859,13 @@ static void __cmd_replay(void)
 
 
 static const char * const sched_usage[] = {
-	"perf sched [<options>] {record|latency|replay|trace}",
+	"perf sched [<options>] {record|latency|map|replay|trace}",
 	NULL
 };
 
 static const struct option sched_options[] = {
+	OPT_STRING('i', "input", &input_name, "file",
+		    "input file name"),
 	OPT_BOOLEAN('v', "verbose", &verbose,
 		    "be more verbose (show symbol address, etc)"),
 	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [patchlet] perf_counter tools: add --input=file option to builtin-sched.c
  2009-09-18  6:22 [patchlet] perf_counter tools: add --input=file option to builtin-sched.c Mike Galbraith
@ 2009-09-18  6:37 ` Ingo Molnar
  2009-09-18  6:39 ` [tip:perfcounters/core] perf sched: Add " tip-bot for Mike Galbraith
  1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-09-18  6:37 UTC (permalink / raw)
  To: Mike Galbraith; +Cc: LKML, Peter Zijlstra, Paul Mackerras


* Mike Galbraith <efault@gmx.de> wrote:

> perf_counter tools: add --input=file option to builtin-sched.c.
> 
> perf sched record passes unparsed args on to perf record, so 
> specifying an output file via perf sched record -o FILE (cmd) just 
> works.  Ergo, provide an option to specify input file as well.

Indeed, that's very useful when one keeps older (or different) traces 
around, renamed from perf.data to something else. It basically pushes 
the file based 'perf session' concept to perf sched as well.

> Also add the missing 'map' command to help.

Applied your fixes/enhancements to tip:perfcounters/core, thanks Mike!

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:perfcounters/core] perf sched: Add --input=file option to builtin-sched.c
  2009-09-18  6:22 [patchlet] perf_counter tools: add --input=file option to builtin-sched.c Mike Galbraith
  2009-09-18  6:37 ` Ingo Molnar
@ 2009-09-18  6:39 ` tip-bot for Mike Galbraith
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Mike Galbraith @ 2009-09-18  6:39 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, a.p.zijlstra, efault, tglx, mingo

Commit-ID:  4b77a7297795229eca96c41e1709a3c87909fabe
Gitweb:     http://git.kernel.org/tip/4b77a7297795229eca96c41e1709a3c87909fabe
Author:     Mike Galbraith <efault@gmx.de>
AuthorDate: Fri, 18 Sep 2009 08:22:24 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 18 Sep 2009 08:36:06 +0200

perf sched: Add --input=file option to builtin-sched.c

perf sched record passes unparsed args on to perf record, so
specifying an output file via perf sched record -o FILE (cmd) just
works.  Ergo, provide an option to specify input file as well.

Also add the missing 'map' command to help.

Signed-off-by: Mike Galbraith <efault@gmx.de>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1253254944.20589.11.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 tools/perf/builtin-sched.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 9e04827..275d79c 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1859,11 +1859,13 @@ static void __cmd_replay(void)
 
 
 static const char * const sched_usage[] = {
-	"perf sched [<options>] {record|latency|replay|trace}",
+	"perf sched [<options>] {record|latency|map|replay|trace}",
 	NULL
 };
 
 static const struct option sched_options[] = {
+	OPT_STRING('i', "input", &input_name, "file",
+		    "input file name"),
 	OPT_BOOLEAN('v', "verbose", &verbose,
 		    "be more verbose (show symbol address, etc)"),
 	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-09-18  6:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-18  6:22 [patchlet] perf_counter tools: add --input=file option to builtin-sched.c Mike Galbraith
2009-09-18  6:37 ` Ingo Molnar
2009-09-18  6:39 ` [tip:perfcounters/core] perf sched: Add " tip-bot for Mike Galbraith

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.