* [PATCH] cpu/hotplug: Fix state name in takedown_cpu comment
@ 2017-12-06 10:59 Brendan Jackman
2017-12-06 17:19 ` Ingo Molnar
2017-12-06 20:27 ` [tip:core/urgent] cpu/hotplug: Fix state name in takedown_cpu() comment tip-bot for Brendan Jackman
0 siblings, 2 replies; 3+ messages in thread
From: Brendan Jackman @ 2017-12-06 10:59 UTC (permalink / raw)
To: Thomas Gleixner, linux-kernel
Cc: Ingo Molnar, Peter Zijlstra, Sebastian Andrzej Siewior,
Boris Ostrovsky, Dietmar Eggemann, Quentin Perret
CPUHP_AP_SCHED_MIGRATE_DYING doesn't exist, it looks like this was
supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback
i.e. sched_cpu_dying.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Quentin Perret <quentin.perret@arm.com>
---
kernel/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 04892a82f6ac..944c7efdf092 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -780,8 +780,8 @@ static int takedown_cpu(unsigned int cpu)
BUG_ON(cpu_online(cpu));
/*
- * The CPUHP_AP_SCHED_MIGRATE_DYING callback will have removed all
- * runnable tasks from the cpu, there's only the idle task left now
+ * The teardown callback for CPUHP_AP_SCHED_STARTING will have removed
+ * all runnable tasks from the cpu, there's only the idle task left now
* that the migration thread is done doing the stop_machine thing.
*
* Wait for the stop thread to go away.
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpu/hotplug: Fix state name in takedown_cpu comment
2017-12-06 10:59 [PATCH] cpu/hotplug: Fix state name in takedown_cpu comment Brendan Jackman
@ 2017-12-06 17:19 ` Ingo Molnar
2017-12-06 20:27 ` [tip:core/urgent] cpu/hotplug: Fix state name in takedown_cpu() comment tip-bot for Brendan Jackman
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2017-12-06 17:19 UTC (permalink / raw)
To: Brendan Jackman
Cc: Thomas Gleixner, linux-kernel, Peter Zijlstra,
Sebastian Andrzej Siewior, Boris Ostrovsky, Dietmar Eggemann,
Quentin Perret
* Brendan Jackman <brendan.jackman@arm.com> wrote:
> CPUHP_AP_SCHED_MIGRATE_DYING doesn't exist, it looks like this was
> supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback
> i.e. sched_cpu_dying.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Cc: Quentin Perret <quentin.perret@arm.com>
I've added:
Signed-off-by: Brendan Jackman <brendan.jackman@arm.com>
... to the commit, which SOB you intended to include I guess, right?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:core/urgent] cpu/hotplug: Fix state name in takedown_cpu() comment
2017-12-06 10:59 [PATCH] cpu/hotplug: Fix state name in takedown_cpu comment Brendan Jackman
2017-12-06 17:19 ` Ingo Molnar
@ 2017-12-06 20:27 ` tip-bot for Brendan Jackman
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Brendan Jackman @ 2017-12-06 20:27 UTC (permalink / raw)
To: linux-tip-commits
Cc: bigeasy, brendan.jackman, peterz, quentin.perret, tglx,
dietmar.eggemann, boris.ostrovsky, mingo, linux-kernel, torvalds,
hpa
Commit-ID: 5b1ead6800cb2241aeadcba32736c5836e59c7e1
Gitweb: https://git.kernel.org/tip/5b1ead6800cb2241aeadcba32736c5836e59c7e1
Author: Brendan Jackman <brendan.jackman@arm.com>
AuthorDate: Wed, 6 Dec 2017 10:59:11 +0000
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 6 Dec 2017 19:28:45 +0100
cpu/hotplug: Fix state name in takedown_cpu() comment
CPUHP_AP_SCHED_MIGRATE_DYING doesn't exist, it looks like this was
supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback,
i.e. sched_cpu_dying().
Signed-off-by: Brendan Jackman <brendan.jackman@arm.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Quentin Perret <quentin.perret@arm.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20171206105911.28093-1-brendan.jackman@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 04892a8..2a885c5 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -780,8 +780,8 @@ static int takedown_cpu(unsigned int cpu)
BUG_ON(cpu_online(cpu));
/*
- * The CPUHP_AP_SCHED_MIGRATE_DYING callback will have removed all
- * runnable tasks from the cpu, there's only the idle task left now
+ * The teardown callback for CPUHP_AP_SCHED_STARTING will have removed
+ * all runnable tasks from the CPU, there's only the idle task left now
* that the migration thread is done doing the stop_machine thing.
*
* Wait for the stop thread to go away.
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-06 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 10:59 [PATCH] cpu/hotplug: Fix state name in takedown_cpu comment Brendan Jackman
2017-12-06 17:19 ` Ingo Molnar
2017-12-06 20:27 ` [tip:core/urgent] cpu/hotplug: Fix state name in takedown_cpu() comment tip-bot for Brendan Jackman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.