* Re: [patch] sched: fix checking task hot
[not found] <20140607090452.4696E301D2@webmail.sinamail.sina.com.cn>
@ 2014-06-10 9:00 ` Peter Zijlstra
2014-06-19 12:36 ` [tip:sched/core] sched: Fix CACHE_HOT_BUDY condition tip-bot for Hillf Danton
1 sibling, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2014-06-10 9:00 UTC (permalink / raw)
To: zhdxzx; +Cc: linux-kernel, Mike Galbraith, Ingo Molnar, dhillf, hillf.zj
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
Could you change your mailer to send 'normal' email?
Content-Type: text/plain; charset=GBK
Content-Transfer-Encoding: base64
The actual email is one big block of base64 garbage, not something I can
apply.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:sched/core] sched: Fix CACHE_HOT_BUDY condition
[not found] <20140607090452.4696E301D2@webmail.sinamail.sina.com.cn>
2014-06-10 9:00 ` [patch] sched: fix checking task hot Peter Zijlstra
@ 2014-06-19 12:36 ` tip-bot for Hillf Danton
1 sibling, 0 replies; 2+ messages in thread
From: tip-bot for Hillf Danton @ 2014-06-19 12:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, mgalbraith, hpa, mingo, torvalds, peterz, dhillf,
tglx, hillf.zj
Commit-ID: 5d5e2b1bcbdc996e72815c03fdc5ea82c4642397
Gitweb: http://git.kernel.org/tip/5d5e2b1bcbdc996e72815c03fdc5ea82c4642397
Author: Hillf Danton <dhillf@gmail.com>
AuthorDate: Tue, 10 Jun 2014 10:58:43 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 18 Jun 2014 18:29:59 +0200
sched: Fix CACHE_HOT_BUDY condition
When computing cache hot, we should check if the migration dst cpu is idle,
instead of the current cpu. Though they are same in normal balancing, that
is false nowadays in nohz idle balancing at least.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Mike Galbraith <mgalbraith@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140607090452.4696E301D2@webmail.sinamail.sina.com.cn
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/fair.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3fa3e18..1f9c457 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5095,8 +5095,7 @@ static void move_task(struct task_struct *p, struct lb_env *env)
/*
* Is this task likely cache-hot:
*/
-static int
-task_hot(struct task_struct *p, u64 now)
+static int task_hot(struct task_struct *p, struct lb_env *env)
{
s64 delta;
@@ -5109,7 +5108,7 @@ task_hot(struct task_struct *p, u64 now)
/*
* Buddy candidates are cache hot:
*/
- if (sched_feat(CACHE_HOT_BUDDY) && this_rq()->nr_running &&
+ if (sched_feat(CACHE_HOT_BUDDY) && env->dst_rq->nr_running &&
(&p->se == cfs_rq_of(&p->se)->next ||
&p->se == cfs_rq_of(&p->se)->last))
return 1;
@@ -5119,7 +5118,7 @@ task_hot(struct task_struct *p, u64 now)
if (sysctl_sched_migration_cost == 0)
return 0;
- delta = now - p->se.exec_start;
+ delta = rq_clock_task(env->src_rq) - p->se.exec_start;
return delta < (s64)sysctl_sched_migration_cost;
}
@@ -5273,7 +5272,7 @@ int can_migrate_task(struct task_struct *p, struct lb_env *env)
* 2) task is cache cold, or
* 3) too many balance attempts have failed.
*/
- tsk_cache_hot = task_hot(p, rq_clock_task(env->src_rq));
+ tsk_cache_hot = task_hot(p, env);
if (!tsk_cache_hot)
tsk_cache_hot = migrate_degrades_locality(p, env);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-19 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20140607090452.4696E301D2@webmail.sinamail.sina.com.cn>
2014-06-10 9:00 ` [patch] sched: fix checking task hot Peter Zijlstra
2014-06-19 12:36 ` [tip:sched/core] sched: Fix CACHE_HOT_BUDY condition tip-bot for Hillf Danton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.