All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] x86,nmi: Fix the type of nmiaction.flags field
@ 2012-04-27 20:40 Betty Dall
  2012-05-08  4:06 ` [tip:core/locking] x86/nmi: Fix the type of the nmiaction. flags field tip-bot for Betty Dall
  0 siblings, 1 reply; 2+ messages in thread
From: Betty Dall @ 2012-04-27 20:40 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86
  Cc: Don Zickus, linux-kernel, Betty Dall

This patch changes the type of the struct nmiaction flags field to
unsigned long from unsigned int. All the usages of the flags field
are unsigned long already. There is only one flag used currently,
NMI_FLAG_FIRST, but having the wrong size could cause a truncation
bug in the future on 64 bit architectures.

v1->v2: The structure moved from nmi.c to nmi.h in the tip git tree
so I am anticipating a merge conflict with the first patch sent by
Don Zickus.

Signed-off-by: Betty Dall <betty.dall@hp.com>
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
 arch/x86/include/asm/nmi.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/nmi.h b/arch/x86/include/asm/nmi.h
index a1a836c..0e3793b 100644
--- a/arch/x86/include/asm/nmi.h
+++ b/arch/x86/include/asm/nmi.h
@@ -40,7 +40,7 @@ typedef int (*nmi_handler_t)(unsigned int, struct pt_regs *);
 struct nmiaction {
 	struct list_head	list;
 	nmi_handler_t		handler;
-	unsigned int		flags;
+	unsigned long		flags;
 	const char		*name;
 };
 
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:core/locking] x86/nmi: Fix the type of the nmiaction. flags field
  2012-04-27 20:40 [PATCH v2] x86,nmi: Fix the type of nmiaction.flags field Betty Dall
@ 2012-05-08  4:06 ` tip-bot for Betty Dall
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Betty Dall @ 2012-05-08  4:06 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, tglx, betty.dall, dzickus

Commit-ID:  6ff968cca1dfebd4b6fcade87c11658dbfc96932
Gitweb:     http://git.kernel.org/tip/6ff968cca1dfebd4b6fcade87c11658dbfc96932
Author:     Betty Dall <betty.dall@hp.com>
AuthorDate: Fri, 27 Apr 2012 14:40:55 -0600
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 7 May 2012 12:32:11 +0200

x86/nmi: Fix the type of the nmiaction.flags field

This patch changes the type of the struct nmiaction flags field
to unsigned long from unsigned int. All the usages of the flags
field are unsigned long already. There is only one flag used
currently, NMI_FLAG_FIRST, but having the wrong size could cause
a truncation bug in the future on 64 bit architectures.

Signed-off-by: Betty Dall <betty.dall@hp.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Link: http://lkml.kernel.org/r/1335559255-13454-1-git-send-email-betty.dall@hp.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/nmi.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/nmi.h b/arch/x86/include/asm/nmi.h
index a1a836c..0e3793b 100644
--- a/arch/x86/include/asm/nmi.h
+++ b/arch/x86/include/asm/nmi.h
@@ -40,7 +40,7 @@ typedef int (*nmi_handler_t)(unsigned int, struct pt_regs *);
 struct nmiaction {
 	struct list_head	list;
 	nmi_handler_t		handler;
-	unsigned int		flags;
+	unsigned long		flags;
 	const char		*name;
 };
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-08  4:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-27 20:40 [PATCH v2] x86,nmi: Fix the type of nmiaction.flags field Betty Dall
2012-05-08  4:06 ` [tip:core/locking] x86/nmi: Fix the type of the nmiaction. flags field tip-bot for Betty Dall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.