All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] sched/fair: Make sync_entity_load_avg and remove_entity_load_avg static
@ 2019-03-20 13:38 Yue Haibing
  2019-04-03  8:42 ` [tip:sched/core] sched/fair: Make sync_entity_load_avg() and remove_entity_load_avg() static tip-bot for YueHaibing
  2019-04-03 10:48 ` tip-bot for YueHaibing
  0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-20 13:38 UTC (permalink / raw)
  To: mingo, peterz; +Cc: linux-kernel, YueHaibing

From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warnigs:

kernel/sched/fair.c:3570:6: warning: symbol 'sync_entity_load_avg' was not declared. Should it be static?
kernel/sched/fair.c:3583:6: warning: symbol 'remove_entity_load_avg' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 kernel/sched/fair.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index fdab7eb..5c42291 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3567,7 +3567,7 @@ static inline u64 cfs_rq_last_update_time(struct cfs_rq *cfs_rq)
  * Synchronize entity load avg of dequeued entity without locking
  * the previous rq.
  */
-void sync_entity_load_avg(struct sched_entity *se)
+static void sync_entity_load_avg(struct sched_entity *se)
 {
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 	u64 last_update_time;
@@ -3580,7 +3580,7 @@ void sync_entity_load_avg(struct sched_entity *se)
  * Task first catches up with cfs_rq, and then subtract
  * itself from the cfs_rq (task must be off the queue now).
  */
-void remove_entity_load_avg(struct sched_entity *se)
+static void remove_entity_load_avg(struct sched_entity *se)
 {
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 	unsigned long flags;
-- 
2.7.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [tip:sched/core] sched/fair: Make sync_entity_load_avg() and remove_entity_load_avg() static
  2019-03-20 13:38 [PATCH -next] sched/fair: Make sync_entity_load_avg and remove_entity_load_avg static Yue Haibing
@ 2019-04-03  8:42 ` tip-bot for YueHaibing
  2019-04-03 10:48 ` tip-bot for YueHaibing
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for YueHaibing @ 2019-04-03  8:42 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: efault, tglx, linux-kernel, peterz, torvalds, yuehaibing, mingo, hpa

Commit-ID:  ed1681a83e3530445a595231419305c863b7fb7f
Gitweb:     https://git.kernel.org/tip/ed1681a83e3530445a595231419305c863b7fb7f
Author:     YueHaibing <yuehaibing@huawei.com>
AuthorDate: Wed, 20 Mar 2019 21:38:39 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 3 Apr 2019 09:51:05 +0200

sched/fair: Make sync_entity_load_avg() and remove_entity_load_avg() static

Fix these sparse warnigs:

  kernel/sched/fair.c:3570:6: warning: symbol 'sync_entity_load_avg' was not declared. Should it be static?
  kernel/sched/fair.c:3583:6: warning: symbol 'remove_entity_load_avg' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190320133839.21392-1-yuehaibing@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d4cce633eac8..f766c3364246 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3567,7 +3567,7 @@ static inline u64 cfs_rq_last_update_time(struct cfs_rq *cfs_rq)
  * Synchronize entity load avg of dequeued entity without locking
  * the previous rq.
  */
-void sync_entity_load_avg(struct sched_entity *se)
+static void sync_entity_load_avg(struct sched_entity *se)
 {
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 	u64 last_update_time;
@@ -3580,7 +3580,7 @@ void sync_entity_load_avg(struct sched_entity *se)
  * Task first catches up with cfs_rq, and then subtract
  * itself from the cfs_rq (task must be off the queue now).
  */
-void remove_entity_load_avg(struct sched_entity *se)
+static void remove_entity_load_avg(struct sched_entity *se)
 {
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 	unsigned long flags;

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [tip:sched/core] sched/fair: Make sync_entity_load_avg() and remove_entity_load_avg() static
  2019-03-20 13:38 [PATCH -next] sched/fair: Make sync_entity_load_avg and remove_entity_load_avg static Yue Haibing
  2019-04-03  8:42 ` [tip:sched/core] sched/fair: Make sync_entity_load_avg() and remove_entity_load_avg() static tip-bot for YueHaibing
@ 2019-04-03 10:48 ` tip-bot for YueHaibing
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for YueHaibing @ 2019-04-03 10:48 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: efault, torvalds, yuehaibing, tglx, linux-kernel, peterz, mingo, hpa

Commit-ID:  71b47eaf6fb29b7f9722dc1646c26eb8a96e0a6d
Gitweb:     https://git.kernel.org/tip/71b47eaf6fb29b7f9722dc1646c26eb8a96e0a6d
Author:     YueHaibing <yuehaibing@huawei.com>
AuthorDate: Wed, 20 Mar 2019 21:38:39 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 3 Apr 2019 12:34:31 +0200

sched/fair: Make sync_entity_load_avg() and remove_entity_load_avg() static

Fix these sparse warnigs:

  kernel/sched/fair.c:3570:6: warning: symbol 'sync_entity_load_avg' was not declared. Should it be static?
  kernel/sched/fair.c:3583:6: warning: symbol 'remove_entity_load_avg' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190320133839.21392-1-yuehaibing@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 40bd1e27b1b7..ed7f5f8107b7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3567,7 +3567,7 @@ static inline u64 cfs_rq_last_update_time(struct cfs_rq *cfs_rq)
  * Synchronize entity load avg of dequeued entity without locking
  * the previous rq.
  */
-void sync_entity_load_avg(struct sched_entity *se)
+static void sync_entity_load_avg(struct sched_entity *se)
 {
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 	u64 last_update_time;
@@ -3580,7 +3580,7 @@ void sync_entity_load_avg(struct sched_entity *se)
  * Task first catches up with cfs_rq, and then subtract
  * itself from the cfs_rq (task must be off the queue now).
  */
-void remove_entity_load_avg(struct sched_entity *se)
+static void remove_entity_load_avg(struct sched_entity *se)
 {
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 	unsigned long flags;

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-03 10:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 13:38 [PATCH -next] sched/fair: Make sync_entity_load_avg and remove_entity_load_avg static Yue Haibing
2019-04-03  8:42 ` [tip:sched/core] sched/fair: Make sync_entity_load_avg() and remove_entity_load_avg() static tip-bot for YueHaibing
2019-04-03 10:48 ` tip-bot for YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.