* [PATCH] sched: reorder lb_env struct members to reduce its size
@ 2012-06-19 12:17 Prashanth Nageshappa
2012-07-06 6:21 ` [tip:sched/core] sched: Reorder 'struct lb_env' " tip-bot for Prashanth Nageshappa
2012-07-24 14:19 ` tip-bot for Prashanth Nageshappa
0 siblings, 2 replies; 3+ messages in thread
From: Prashanth Nageshappa @ 2012-06-19 12:17 UTC (permalink / raw)
To: Peter Zijlstra, mingo, LKML, roland, Srivatsa Vaddagiri, efault,
Ingo Molnar
Members of lb_env struct are not in appropriate order to reuse compiler
added padding on 64bit architectures. In this patch we reorder those struct
members and help reduce the size of the structure from 96 bytes to 80
bytes on 64 bit architectures.
Suggested-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Signed-off-by: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
---
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 939fd63..96e36fb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3102,18 +3102,18 @@ static unsigned long __read_mostly max_load_balance_interval = HZ/10;
struct lb_env {
struct sched_domain *sd;
- int src_cpu;
struct rq *src_rq;
+ int src_cpu;
int dst_cpu;
struct rq *dst_rq;
enum cpu_idle_type idle;
long imbalance;
- unsigned int flags;
struct list_head *tasks;
+ unsigned int flags;
unsigned int loop;
unsigned int loop_break;
unsigned int loop_max;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:sched/core] sched: Reorder 'struct lb_env' members to reduce its size
2012-06-19 12:17 [PATCH] sched: reorder lb_env struct members to reduce its size Prashanth Nageshappa
@ 2012-07-06 6:21 ` tip-bot for Prashanth Nageshappa
2012-07-24 14:19 ` tip-bot for Prashanth Nageshappa
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Prashanth Nageshappa @ 2012-07-06 6:21 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, vatsa, hpa, mingo, a.p.zijlstra, tglx, prashanth
Commit-ID: 95f302e4d0833dd604210fbb415629ac3662cd39
Gitweb: http://git.kernel.org/tip/95f302e4d0833dd604210fbb415629ac3662cd39
Author: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
AuthorDate: Tue, 19 Jun 2012 17:47:34 +0530
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 5 Jul 2012 21:09:08 +0200
sched: Reorder 'struct lb_env' members to reduce its size
Members of 'struct lb_env' are not in appropriate order to reuse compiler
added padding on 64bit architectures. In this patch we reorder those struct
members and help reduce the size of the structure from 96 bytes to 80
bytes on 64 bit architectures.
Suggested-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Signed-off-by: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/4FE06DDE.7000403@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/fair.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3704ad3..39b5771 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3088,18 +3088,18 @@ static unsigned long __read_mostly max_load_balance_interval = HZ/10;
struct lb_env {
struct sched_domain *sd;
- int src_cpu;
struct rq *src_rq;
+ int src_cpu;
int dst_cpu;
struct rq *dst_rq;
enum cpu_idle_type idle;
long imbalance;
- unsigned int flags;
struct list_head *tasks;
+ unsigned int flags;
unsigned int loop;
unsigned int loop_break;
unsigned int loop_max;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:sched/core] sched: Reorder 'struct lb_env' members to reduce its size
2012-06-19 12:17 [PATCH] sched: reorder lb_env struct members to reduce its size Prashanth Nageshappa
2012-07-06 6:21 ` [tip:sched/core] sched: Reorder 'struct lb_env' " tip-bot for Prashanth Nageshappa
@ 2012-07-24 14:19 ` tip-bot for Prashanth Nageshappa
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Prashanth Nageshappa @ 2012-07-24 14:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, vatsa, hpa, mingo, a.p.zijlstra, tglx, prashanth
Commit-ID: 85c1e7dae165acd004429f81fe52bfbf55b57a98
Gitweb: http://git.kernel.org/tip/85c1e7dae165acd004429f81fe52bfbf55b57a98
Author: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
AuthorDate: Tue, 19 Jun 2012 17:47:34 +0530
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 24 Jul 2012 13:55:20 +0200
sched: Reorder 'struct lb_env' members to reduce its size
Members of 'struct lb_env' are not in appropriate order to reuse compiler
added padding on 64bit architectures. In this patch we reorder those struct
members and help reduce the size of the structure from 96 bytes to 80
bytes on 64 bit architectures.
Suggested-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Signed-off-by: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/4FE06DDE.7000403@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/fair.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index dd00aaf..9361669 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3058,8 +3058,8 @@ static unsigned long __read_mostly max_load_balance_interval = HZ/10;
struct lb_env {
struct sched_domain *sd;
- int src_cpu;
struct rq *src_rq;
+ int src_cpu;
int dst_cpu;
struct rq *dst_rq;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-24 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-19 12:17 [PATCH] sched: reorder lb_env struct members to reduce its size Prashanth Nageshappa
2012-07-06 6:21 ` [tip:sched/core] sched: Reorder 'struct lb_env' " tip-bot for Prashanth Nageshappa
2012-07-24 14:19 ` tip-bot for Prashanth Nageshappa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.