* [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed
@ 2015-08-22 8:10 Guenter Roeck
2015-08-22 9:00 ` [tip:timers/core] hrtimer: Handle failure of tick_init_highres() gracefully tip-bot for Guenter Roeck
2015-08-22 21:25 ` [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Luiz Capitulino
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2015-08-22 8:10 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel, Guenter Roeck, Luiz Capitulino
Commit 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
drops the return code of hrtimer_switch_to_hres(). While doing so, it also
drops the return statement itself on failure. This may cause a system hang.
Seen when running arm:multi_v7_defconfig in qemu with devicetree file
vexpress-v2p-ca9.
Fixes: 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
kernel/time/hrtimer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index 5c4fe50e47d3..457a373e2181 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -695,6 +695,7 @@ static void hrtimer_switch_to_hres(void)
if (tick_init_highres()) {
printk(KERN_WARNING "Could not switch to high resolution "
"mode on CPU %d\n", base->cpu);
+ return;
}
base->hres_active = 1;
hrtimer_resolution = HIGH_RES_NSEC;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:timers/core] hrtimer: Handle failure of tick_init_highres() gracefully
2015-08-22 8:10 [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Guenter Roeck
@ 2015-08-22 9:00 ` tip-bot for Guenter Roeck
2015-08-22 21:25 ` [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Luiz Capitulino
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Guenter Roeck @ 2015-08-22 9:00 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, linux-kernel, lcapitulino, mingo, hpa, linux
Commit-ID: 85e1cd6e769dfc84995270d0a4838021fcb8602d
Gitweb: http://git.kernel.org/tip/85e1cd6e769dfc84995270d0a4838021fcb8602d
Author: Guenter Roeck <linux@roeck-us.net>
AuthorDate: Sat, 22 Aug 2015 01:10:47 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sat, 22 Aug 2015 10:57:50 +0200
hrtimer: Handle failure of tick_init_highres() gracefully
Commit 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
drops the return code of hrtimer_switch_to_hres(). While doing so, it also
drops the return statement itself on failure. This may cause a system hang.
Seen when running arm:multi_v7_defconfig in qemu with devicetree file
vexpress-v2p-ca9.
Fixes: 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Link: http://lkml.kernel.org/r/1440231047-16256-1-git-send-email-linux@roeck-us.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/hrtimer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index 5c4fe50..457a373 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -695,6 +695,7 @@ static void hrtimer_switch_to_hres(void)
if (tick_init_highres()) {
printk(KERN_WARNING "Could not switch to high resolution "
"mode on CPU %d\n", base->cpu);
+ return;
}
base->hres_active = 1;
hrtimer_resolution = HIGH_RES_NSEC;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed
2015-08-22 8:10 [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Guenter Roeck
2015-08-22 9:00 ` [tip:timers/core] hrtimer: Handle failure of tick_init_highres() gracefully tip-bot for Guenter Roeck
@ 2015-08-22 21:25 ` Luiz Capitulino
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Capitulino @ 2015-08-22 21:25 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Thomas Gleixner, linux-kernel
On Sat, 22 Aug 2015 01:10:47 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> Commit 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
> drops the return code of hrtimer_switch_to_hres(). While doing so, it also
> drops the return statement itself on failure. This may cause a system hang.
> Seen when running arm:multi_v7_defconfig in qemu with devicetree file
> vexpress-v2p-ca9.
>
> Fixes: 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Thanks for catching it Guenter!
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> kernel/time/hrtimer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
> index 5c4fe50e47d3..457a373e2181 100644
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -695,6 +695,7 @@ static void hrtimer_switch_to_hres(void)
> if (tick_init_highres()) {
> printk(KERN_WARNING "Could not switch to high resolution "
> "mode on CPU %d\n", base->cpu);
> + return;
> }
> base->hres_active = 1;
> hrtimer_resolution = HIGH_RES_NSEC;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-22 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-22 8:10 [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Guenter Roeck
2015-08-22 9:00 ` [tip:timers/core] hrtimer: Handle failure of tick_init_highres() gracefully tip-bot for Guenter Roeck
2015-08-22 21:25 ` [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Luiz Capitulino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.