From: "tip-bot for Marcin Ślusarz" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
acme@redhat.com, mingo@kernel.org, namhyung@kernel.org,
marcin.slusarz@gmail.com
Subject: [tip:perf/core] perf tools: handle spaces in file names obtained from /proc/pid/maps
Date: Tue, 9 Feb 2016 04:14:05 -0800 [thread overview]
Message-ID: <tip-89fee59b504f86925894fcc9ba79d5c933842f93@git.kernel.org> (raw)
In-Reply-To: <20160119190303.GA17579@marcin-Inspiron-7720>
Commit-ID: 89fee59b504f86925894fcc9ba79d5c933842f93
Gitweb: http://git.kernel.org/tip/89fee59b504f86925894fcc9ba79d5c933842f93
Author: Marcin Ślusarz <marcin.slusarz@gmail.com>
AuthorDate: Tue, 19 Jan 2016 20:03:03 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 5 Feb 2016 09:39:56 -0300
perf tools: handle spaces in file names obtained from /proc/pid/maps
Steam frequently puts game binaries in folders with spaces.
Note: "(deleted)" markers are now treated as part of the file name.
Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Fixes: 6064803313ba ("perf tools: Use sscanf for parsing /proc/pid/maps")
Link: http://lkml.kernel.org/r/20160119190303.GA17579@marcin-Inspiron-7720
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 85155e9..7bad5c3 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -282,7 +282,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
strcpy(execname, "");
/* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */
- n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
+ n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n",
&event->mmap2.start, &event->mmap2.len, prot,
&event->mmap2.pgoff, &event->mmap2.maj,
&event->mmap2.min,
prev parent reply other threads:[~2016-02-09 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 3:03 [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps Marcin Ślusarz
2016-01-04 1:25 ` Namhyung Kim
2016-01-07 23:16 ` Marcin Ślusarz
2016-01-09 9:42 ` Namhyung Kim
2016-01-19 19:03 ` [PATCH v2] " Marcin Ślusarz
2016-02-04 22:39 ` Marcin Ślusarz
2016-02-05 12:42 ` Arnaldo Carvalho de Melo
2016-02-09 12:14 ` tip-bot for Marcin Ślusarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-89fee59b504f86925894fcc9ba79d5c933842f93@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.