All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: "Marcin Ślusarz" <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps
Date: Fri, 5 Feb 2016 10:42:30 -0200	[thread overview]
Message-ID: <20160205124230.GA15395@redhat.com> (raw)
In-Reply-To: <20160204223925.GA19157@marcin-Inspiron-7720>

Em Thu, Feb 04, 2016 at 11:39:25PM +0100, Marcin Ślusarz escreveu:
> On Tue, Jan 19, 2016 at 08:03:03PM +0100, Marcin Ślusarz wrote:
> > Steam frequently puts game binaries in folders with spaces.
> > 
> > Note: "(deleted)" markers are now treated as part of the file name.
> > 
> > It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
> > ("perf tools: Use sscanf for parsing /proc/pid/maps").
> > 
> > Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> > Acked-by: Namhyung Kim <namhyung@kernel.org>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Gentle ping ;)

Thanks for being gentle, appreciated ;-)

Applied to perf/core,

- Arnaldo
 
> > ---
> >  tools/perf/util/event.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> > index 8b10621..956187b 100644
> > --- a/tools/perf/util/event.c
> > +++ b/tools/perf/util/event.c
> > @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
> >  		strcpy(execname, "");
> >  
> >  		/* 00400000-0040c000 r-xp 00000000 fd:01 41038  /bin/cat */
> > -		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
> > +		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n",
> >  		       &event->mmap2.start, &event->mmap2.len, prot,
> >  		       &event->mmap2.pgoff, &event->mmap2.maj,
> >  		       &event->mmap2.min,
> > -- 
> > 2.1.4
> > 

  reply	other threads:[~2016-02-05 12:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01  3:03 [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps Marcin Ślusarz
2016-01-04  1:25 ` Namhyung Kim
2016-01-07 23:16   ` Marcin Ślusarz
2016-01-09  9:42     ` Namhyung Kim
2016-01-19 19:03       ` [PATCH v2] " Marcin Ślusarz
2016-02-04 22:39         ` Marcin Ślusarz
2016-02-05 12:42           ` Arnaldo Carvalho de Melo [this message]
2016-02-09 12:14         ` [tip:perf/core] " tip-bot for Marcin Ślusarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160205124230.GA15395@redhat.com \
    --to=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.