[PATCH] perf tools: replace assignment with comparison on assert check

[PATCH] perf tools: replace assignment with comparison on assert check

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The current assert check is checking an assignment, which will always
be true.  Instead, the assert should be checking if scale is equal
to 0.122

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 tools/perf/tests/event_update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c
index 012eab5..63ecf21 100644
--- a/tools/perf/tests/event_update.c
+++ b/tools/perf/tests/event_update.c
@@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused,
 
 	TEST_ASSERT_VAL("wrong id", ev->id == 123);
 	TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE);
-	TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123);
+	TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123);
 	return 0;
 }
 
-- 
2.7.4

Re: [PATCH] perf tools: replace assignment with comparison on assert check

[Masami Hiramatsu]

On Sat, 23 Apr 2016 14:45:54 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The current assert check is checking an assignment, which will always
> be true.  Instead, the assert should be checking if scale is equal
> to 0.122
> 

Looks good to me.

Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  tools/perf/tests/event_update.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c
> index 012eab5..63ecf21 100644
> --- a/tools/perf/tests/event_update.c
> +++ b/tools/perf/tests/event_update.c
> @@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused,
>  
>  	TEST_ASSERT_VAL("wrong id", ev->id == 123);
>  	TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE);
> -	TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123);
> +	TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123);
>  	return 0;
>  }
>  
> -- 
> 2.7.4
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

[tip:perf/core] perf tests: Replace assignment with comparison on assert check

[tip-bot for Colin Ian King]

Commit-ID:  8daef508b0a144970e5cbc587525c351663fec63
Gitweb:     http://git.kernel.org/tip/8daef508b0a144970e5cbc587525c351663fec63
Author:     Colin Ian King <colin.king@canonical.com>
AuthorDate: Sat, 23 Apr 2016 14:45:54 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 25 Apr 2016 20:24:26 -0300

perf tests: Replace assignment with comparison on assert check

The current assert check is checking an assignment, which will always be
true.  Instead, the assert should be checking if scale is equal to 0.122

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1461419154-16918-1-git-send-email-colin.king@canonical.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/event_update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c
index 012eab5..63ecf21 100644
--- a/tools/perf/tests/event_update.c
+++ b/tools/perf/tests/event_update.c
@@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused,
 
 	TEST_ASSERT_VAL("wrong id", ev->id == 123);
 	TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE);
-	TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123);
+	TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123);
 	return 0;
 }