* [PATCH] tracing: remove format attribute of inline function
@ 2009-04-17 21:17 Steven Rostedt
2009-04-18 7:14 ` Ingo Molnar
2009-04-18 16:28 ` [tip:tracing/core] " tip-bot for Steven Rostedt
0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2009-04-17 21:17 UTC (permalink / raw)
To: LKML; +Cc: Ingo Molnar, Andrew Morton, Frédéric Weisbecker
Due to a cut and paste error, I added the gcc attribute for printf
format to the static inline stub of trace_seq_printf.
This will cause a compile failure.
[ Impact: fix compiler error when CONFIG_TRACING is off ]
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index 15ca2c7..37db9bd 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -42,7 +42,6 @@ extern int trace_seq_path(struct trace_seq *s, struct path *path);
#else /* CONFIG_TRACING */
static inline int trace_seq_printf(struct trace_seq *s, const char *fmt, ...)
- __attribute__ ((format (printf, 2, 3)))
{
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: remove format attribute of inline function
2009-04-17 21:17 [PATCH] tracing: remove format attribute of inline function Steven Rostedt
@ 2009-04-18 7:14 ` Ingo Molnar
2009-04-18 16:28 ` [tip:tracing/core] " tip-bot for Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-04-18 7:14 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Andrew Morton, Frédéric Weisbecker
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Due to a cut and paste error, I added the gcc attribute for printf
> format to the static inline stub of trace_seq_printf.
>
> This will cause a compile failure.
>
> [ Impact: fix compiler error when CONFIG_TRACING is off ]
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Applied, thanks Steve!
We also need to make CONFIG_TRACING an interactive option as well
which i suggested before, so that people can enable/disable this
stuff in a convenient summary way, even if they have KERNEL_DEBUG
enabled otherwise.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:tracing/core] tracing: remove format attribute of inline function
2009-04-17 21:17 [PATCH] tracing: remove format attribute of inline function Steven Rostedt
2009-04-18 7:14 ` Ingo Molnar
@ 2009-04-18 16:28 ` tip-bot for Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Steven Rostedt @ 2009-04-18 16:28 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, fweisbec, rostedt, akpm, tglx, mingo
Commit-ID: 8e668b5b3455207e4540fc7ccab9ecf70142f288
Gitweb: http://git.kernel.org/tip/8e668b5b3455207e4540fc7ccab9ecf70142f288
Author: Steven Rostedt <rostedt@goodmis.org>
AuthorDate: Fri, 17 Apr 2009 17:17:55 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 18 Apr 2009 09:49:10 +0200
tracing: remove format attribute of inline function
Due to a cut and paste error, I added the gcc attribute for printf
format to the static inline stub of trace_seq_printf.
This will cause a compile failure.
[ Impact: fix compiler error when CONFIG_TRACING is off ]
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: =?ISO-8859-15?Q?Fr=E9d=E9ric_Weisbecker?= <fweisbec@gmail.com>
LKML-Reference: <alpine.DEB.2.00.0904171717080.1016@gandalf.stny.rr.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/trace_seq.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index 15ca2c7..37db9bd 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -42,7 +42,6 @@ extern int trace_seq_path(struct trace_seq *s, struct path *path);
#else /* CONFIG_TRACING */
static inline int trace_seq_printf(struct trace_seq *s, const char *fmt, ...)
- __attribute__ ((format (printf, 2, 3)))
{
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-18 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-17 21:17 [PATCH] tracing: remove format attribute of inline function Steven Rostedt
2009-04-18 7:14 ` Ingo Molnar
2009-04-18 16:28 ` [tip:tracing/core] " tip-bot for Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.