* [PATCH] ACPI, x86: Extended error log driver depends on CONFIG_X86_LOCAL_APIC
@ 2013-11-08 22:03 Luck, Tony
2013-11-11 17:51 ` [tip:x86/mce] ACPI, x86: Fix extended error log driver to depend " tip-bot for Luck, Tony
0 siblings, 1 reply; 2+ messages in thread
From: Luck, Tony @ 2013-11-08 22:03 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Chen Gong, Rafael J. Wysocki, linux-acpi, linux-kernel
Randconfig build by Fengguang's robot army reported:
drivers/built-in.o: In function `extlog_print':
>> acpi_extlog.c:(.text+0xcc719): undefined reference to `boot_cpu_physical_apicid'
The config had CONFIG_SMP=n so we picked up this defintion from <asm/cpu.h>:
#define cpu_physical_id(cpu) boot_cpu_physical_apicid
But boot_cpu_physical_apicid is defined in arch/x86/kernel/apic/apic.c
which is only built if CONFIG_X86_LOCAL_APIC=y
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Ingo: This belongs on top of x86/mce branch
drivers/acpi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 08eadb4a57cb..e11faae81ed9 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -374,7 +374,7 @@ source "drivers/acpi/apei/Kconfig"
config ACPI_EXTLOG
tristate "Extended Error Log support"
- depends on X86_MCE
+ depends on X86_MCE && X86_LOCAL_APIC
select EFI
select UEFI_CPER
default n
--
1.8.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/mce] ACPI, x86: Fix extended error log driver to depend on CONFIG_X86_LOCAL_APIC
2013-11-08 22:03 [PATCH] ACPI, x86: Extended error log driver depends on CONFIG_X86_LOCAL_APIC Luck, Tony
@ 2013-11-11 17:51 ` tip-bot for Luck, Tony
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Luck, Tony @ 2013-11-11 17:51 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, tony.luck, gong.chen, tglx, rjw, fengguang.wu
Commit-ID: 9ebddac7ea2a1f4b4ce3335a78312a58dfaadb4d
Gitweb: http://git.kernel.org/tip/9ebddac7ea2a1f4b4ce3335a78312a58dfaadb4d
Author: Luck, Tony <tony.luck@intel.com>
AuthorDate: Fri, 8 Nov 2013 14:03:33 -0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 11 Nov 2013 10:21:29 +0100
ACPI, x86: Fix extended error log driver to depend on CONFIG_X86_LOCAL_APIC
Randconfig build by Fengguang's robot army reported:
drivers/built-in.o: In function `extlog_print':
>> acpi_extlog.c:(.text+0xcc719): undefined reference to `boot_cpu_physical_apicid'
The config had CONFIG_SMP=n so we picked up this definition from:
<asm/cpu.h>: #define cpu_physical_id(cpu) boot_cpu_physical_apicid
But boot_cpu_physical_apicid is defined in arch/x86/kernel/apic/apic.c
which is only built if CONFIG_X86_LOCAL_APIC=y.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Cc: Chen Gong <gong.chen@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/6be3afdcad7968f7fb7c0b681e547b3e872e44dd.1383947368.git.tony.luck@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
drivers/acpi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 08eadb4..e11faae 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -374,7 +374,7 @@ source "drivers/acpi/apei/Kconfig"
config ACPI_EXTLOG
tristate "Extended Error Log support"
- depends on X86_MCE
+ depends on X86_MCE && X86_LOCAL_APIC
select EFI
select UEFI_CPER
default n
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-11 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-08 22:03 [PATCH] ACPI, x86: Extended error log driver depends on CONFIG_X86_LOCAL_APIC Luck, Tony
2013-11-11 17:51 ` [tip:x86/mce] ACPI, x86: Fix extended error log driver to depend " tip-bot for Luck, Tony
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.