* [PATCH v2] x86: fix kernel crash on boot due to NULL dereference
@ 2014-07-21 8:38 Andy Shevchenko
2014-07-21 8:46 ` Jiang Liu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Shevchenko @ 2014-07-21 8:38 UTC (permalink / raw)
To: Jiang Liu, Thomas Gleixner, H . Peter Anvin, x86, linux-kernel,
David Cohen
Cc: Andy Shevchenko
The patch "x86, irq: Count legacy IRQs by legacy_pic->nr_legacy_irqs instead of
NR_IRQS_LEGACY" (linux-next commit 95d76acc7518d566df18d67c1343bb375b78d1f3)
removed reserved interrupts for the platforms that do not have a legacy IOAPIC.
Meanwhile it breaks to boot the Intel MID platforms such as Medfield.
[ 0.000000] BUG: unable to handle kernel NULL pointer dereference at 0000003a
[ 0.000000] IP: [<c107079a>] setup_irq+0xf/0x4d
[ 0.000000] *pdpt = 0000000000000000 *pde = 9bbf32453167e510
[ 0.000000] Oops: 0000 [#1] PREEMPT SMP
[ 0.000000] Modules linked in:
[ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16.0-rc5-next-20140717-00043-g6ab7e8d-dirty #497
[ 0.000000] task: c184bc80 ti: c183e000 task.ti: c183e000
[ 0.000000] EIP: 0060:[<c107079a>] EFLAGS: 00210046 CPU: 0
[ 0.000000] EIP is at setup_irq+0xf/0x4d
[ 0.000000] EAX: 00000000 EBX: 00000002 ECX: 00000000 EDX: 00000002
[ 0.000000] ESI: 000000d5 EDI: c184e280 EBP: c183ffc0 ESP: c183ffb4
[ 0.000000] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[ 0.000000] CR0: 8005003b CR2: 0000003a CR3: 0195b000 CR4: 000006b0
[ 0.000000] Stack:
[ 0.000000] 00000100 000000d5 c195c800 c183ffd0 c18eff07 c1935100 00010800 c183ffd8
[ 0.000000] c18efca0 c183ffe8 c18ec92e c1935100 00020800 c183fff8 c18ec2b4 00020800
[ 0.000000] c195c800 025e5003 00000000
[ 0.000000] Call Trace:
[ 0.000000] [<c18eff07>] native_init_IRQ+0x265/0x273
[ 0.000000] [<c18efca0>] init_IRQ+0x2c/0x2e
[ 0.000000] [<c18ec92e>] start_kernel+0x1e4/0x32a
[ 0.000000] [<c18ec2b4>] i386_start_kernel+0x82/0x86
[ 0.000000] Code: eb 05 bf ea ff ff ff 8b 83 c4 00 00 00 e8 f6 a3 01 00 8d 65 f4 89 f8 5b 5e 5f 5d c3 55 89 e5 57 89 d7 56 53 89 c3 e8 4b e4 ff ff <f6> 40 3a 02 89 c6 74 16 b8 2b 3e 77 c1 ba 0a 05 00 00 e8 83 60
[ 0.000000] EIP: [<c107079a>] setup_irq+0xf/0x4d SS:ESP 0068:c183ffb4
[ 0.000000] CR2: 000000000000003a
[ 0.000000] ---[ end trace cb88537fdc8fa200 ]---
[ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
[ 0.000000] ---[ end Kernel panic - not syncing: Attempted to kill the idle task!
The culprit is an uncoditional setting of the IRQ2 which is used as cascade IRQ
on legacy platforms. It seems we have to check if we have enough legacy IRQs
reserved before we can call setup_irq().
The proposed patch adds such check there and in setup_default_timer_irq().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Since v1:
- add check to setup_default_timer_irq() as well
- adjust spelling in commit message
arch/x86/kernel/irqinit.c | 2 +-
arch/x86/kernel/time.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c
index 1e6cff5..44f1ed4 100644
--- a/arch/x86/kernel/irqinit.c
+++ b/arch/x86/kernel/irqinit.c
@@ -203,7 +203,7 @@ void __init native_init_IRQ(void)
set_intr_gate(i, interrupt[i - FIRST_EXTERNAL_VECTOR]);
}
- if (!acpi_ioapic && !of_ioapic)
+ if (!acpi_ioapic && !of_ioapic && nr_legacy_irqs())
setup_irq(2, &irq2);
#ifdef CONFIG_X86_32
diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
index bf7ef5c..0fa2960 100644
--- a/arch/x86/kernel/time.c
+++ b/arch/x86/kernel/time.c
@@ -68,6 +68,8 @@ static struct irqaction irq0 = {
void __init setup_default_timer_irq(void)
{
+ if (!nr_legacy_irqs())
+ return;
setup_irq(0, &irq0);
}
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] x86: fix kernel crash on boot due to NULL dereference
2014-07-21 8:38 [PATCH v2] x86: fix kernel crash on boot due to NULL dereference Andy Shevchenko
@ 2014-07-21 8:46 ` Jiang Liu
2014-08-22 12:03 ` Andy Shevchenko
2014-08-25 20:42 ` [tip:x86/urgent] x86: Fix non-PC platform " tip-bot for Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: Jiang Liu @ 2014-07-21 8:46 UTC (permalink / raw)
To: Andy Shevchenko, Thomas Gleixner, H . Peter Anvin, x86,
linux-kernel, David Cohen
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
On 2014/7/21 16:38, Andy Shevchenko wrote:
> The patch "x86, irq: Count legacy IRQs by legacy_pic->nr_legacy_irqs instead of
> NR_IRQS_LEGACY" (linux-next commit 95d76acc7518d566df18d67c1343bb375b78d1f3)
> removed reserved interrupts for the platforms that do not have a legacy IOAPIC.
> Meanwhile it breaks to boot the Intel MID platforms such as Medfield.
>
> [ 0.000000] BUG: unable to handle kernel NULL pointer dereference at 0000003a
> [ 0.000000] IP: [<c107079a>] setup_irq+0xf/0x4d
> [ 0.000000] *pdpt = 0000000000000000 *pde = 9bbf32453167e510
> [ 0.000000] Oops: 0000 [#1] PREEMPT SMP
> [ 0.000000] Modules linked in:
> [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16.0-rc5-next-20140717-00043-g6ab7e8d-dirty #497
> [ 0.000000] task: c184bc80 ti: c183e000 task.ti: c183e000
> [ 0.000000] EIP: 0060:[<c107079a>] EFLAGS: 00210046 CPU: 0
> [ 0.000000] EIP is at setup_irq+0xf/0x4d
> [ 0.000000] EAX: 00000000 EBX: 00000002 ECX: 00000000 EDX: 00000002
> [ 0.000000] ESI: 000000d5 EDI: c184e280 EBP: c183ffc0 ESP: c183ffb4
> [ 0.000000] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
> [ 0.000000] CR0: 8005003b CR2: 0000003a CR3: 0195b000 CR4: 000006b0
> [ 0.000000] Stack:
> [ 0.000000] 00000100 000000d5 c195c800 c183ffd0 c18eff07 c1935100 00010800 c183ffd8
> [ 0.000000] c18efca0 c183ffe8 c18ec92e c1935100 00020800 c183fff8 c18ec2b4 00020800
> [ 0.000000] c195c800 025e5003 00000000
> [ 0.000000] Call Trace:
> [ 0.000000] [<c18eff07>] native_init_IRQ+0x265/0x273
> [ 0.000000] [<c18efca0>] init_IRQ+0x2c/0x2e
> [ 0.000000] [<c18ec92e>] start_kernel+0x1e4/0x32a
> [ 0.000000] [<c18ec2b4>] i386_start_kernel+0x82/0x86
> [ 0.000000] Code: eb 05 bf ea ff ff ff 8b 83 c4 00 00 00 e8 f6 a3 01 00 8d 65 f4 89 f8 5b 5e 5f 5d c3 55 89 e5 57 89 d7 56 53 89 c3 e8 4b e4 ff ff <f6> 40 3a 02 89 c6 74 16 b8 2b 3e 77 c1 ba 0a 05 00 00 e8 83 60
> [ 0.000000] EIP: [<c107079a>] setup_irq+0xf/0x4d SS:ESP 0068:c183ffb4
> [ 0.000000] CR2: 000000000000003a
> [ 0.000000] ---[ end trace cb88537fdc8fa200 ]---
> [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
> [ 0.000000] ---[ end Kernel panic - not syncing: Attempted to kill the idle task!
>
> The culprit is an uncoditional setting of the IRQ2 which is used as cascade IRQ
> on legacy platforms. It seems we have to check if we have enough legacy IRQs
> reserved before we can call setup_irq().
>
> The proposed patch adds such check there and in setup_default_timer_irq().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Since v1:
> - add check to setup_default_timer_irq() as well
> - adjust spelling in commit message
> arch/x86/kernel/irqinit.c | 2 +-
> arch/x86/kernel/time.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c
> index 1e6cff5..44f1ed4 100644
> --- a/arch/x86/kernel/irqinit.c
> +++ b/arch/x86/kernel/irqinit.c
> @@ -203,7 +203,7 @@ void __init native_init_IRQ(void)
> set_intr_gate(i, interrupt[i - FIRST_EXTERNAL_VECTOR]);
> }
>
> - if (!acpi_ioapic && !of_ioapic)
> + if (!acpi_ioapic && !of_ioapic && nr_legacy_irqs())
> setup_irq(2, &irq2);
>
> #ifdef CONFIG_X86_32
> diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
> index bf7ef5c..0fa2960 100644
> --- a/arch/x86/kernel/time.c
> +++ b/arch/x86/kernel/time.c
> @@ -68,6 +68,8 @@ static struct irqaction irq0 = {
>
> void __init setup_default_timer_irq(void)
> {
> + if (!nr_legacy_irqs())
> + return;
> setup_irq(0, &irq0);
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] x86: fix kernel crash on boot due to NULL dereference
2014-07-21 8:38 [PATCH v2] x86: fix kernel crash on boot due to NULL dereference Andy Shevchenko
2014-07-21 8:46 ` Jiang Liu
@ 2014-08-22 12:03 ` Andy Shevchenko
2014-08-25 20:42 ` [tip:x86/urgent] x86: Fix non-PC platform " tip-bot for Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2014-08-22 12:03 UTC (permalink / raw)
To: Jiang Liu
Cc: Thomas Gleixner, H . Peter Anvin, x86, linux-kernel, David Cohen
On Mon, 2014-07-21 at 11:38 +0300, Andy Shevchenko wrote:
> The patch "x86, irq: Count legacy IRQs by legacy_pic->nr_legacy_irqs instead of
> NR_IRQS_LEGACY" (linux-next commit 95d76acc7518d566df18d67c1343bb375b78d1f3)
> removed reserved interrupts for the platforms that do not have a legacy IOAPIC.
> Meanwhile it breaks to boot the Intel MID platforms such as Medfield.
Guys, this is the material for 3.17-rc2. We still as of today have the
same issue.
Please, apply if have no objections.
>
> [ 0.000000] BUG: unable to handle kernel NULL pointer dereference at 0000003a
> [ 0.000000] IP: [<c107079a>] setup_irq+0xf/0x4d
> [ 0.000000] *pdpt = 0000000000000000 *pde = 9bbf32453167e510
> [ 0.000000] Oops: 0000 [#1] PREEMPT SMP
> [ 0.000000] Modules linked in:
> [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16.0-rc5-next-20140717-00043-g6ab7e8d-dirty #497
> [ 0.000000] task: c184bc80 ti: c183e000 task.ti: c183e000
> [ 0.000000] EIP: 0060:[<c107079a>] EFLAGS: 00210046 CPU: 0
> [ 0.000000] EIP is at setup_irq+0xf/0x4d
> [ 0.000000] EAX: 00000000 EBX: 00000002 ECX: 00000000 EDX: 00000002
> [ 0.000000] ESI: 000000d5 EDI: c184e280 EBP: c183ffc0 ESP: c183ffb4
> [ 0.000000] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
> [ 0.000000] CR0: 8005003b CR2: 0000003a CR3: 0195b000 CR4: 000006b0
> [ 0.000000] Stack:
> [ 0.000000] 00000100 000000d5 c195c800 c183ffd0 c18eff07 c1935100 00010800 c183ffd8
> [ 0.000000] c18efca0 c183ffe8 c18ec92e c1935100 00020800 c183fff8 c18ec2b4 00020800
> [ 0.000000] c195c800 025e5003 00000000
> [ 0.000000] Call Trace:
> [ 0.000000] [<c18eff07>] native_init_IRQ+0x265/0x273
> [ 0.000000] [<c18efca0>] init_IRQ+0x2c/0x2e
> [ 0.000000] [<c18ec92e>] start_kernel+0x1e4/0x32a
> [ 0.000000] [<c18ec2b4>] i386_start_kernel+0x82/0x86
> [ 0.000000] Code: eb 05 bf ea ff ff ff 8b 83 c4 00 00 00 e8 f6 a3 01 00 8d 65 f4 89 f8 5b 5e 5f 5d c3 55 89 e5 57 89 d7 56 53 89 c3 e8 4b e4 ff ff <f6> 40 3a 02 89 c6 74 16 b8 2b 3e 77 c1 ba 0a 05 00 00 e8 83 60
> [ 0.000000] EIP: [<c107079a>] setup_irq+0xf/0x4d SS:ESP 0068:c183ffb4
> [ 0.000000] CR2: 000000000000003a
> [ 0.000000] ---[ end trace cb88537fdc8fa200 ]---
> [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
> [ 0.000000] ---[ end Kernel panic - not syncing: Attempted to kill the idle task!
>
> The culprit is an uncoditional setting of the IRQ2 which is used as cascade IRQ
> on legacy platforms. It seems we have to check if we have enough legacy IRQs
> reserved before we can call setup_irq().
>
> The proposed patch adds such check there and in setup_default_timer_irq().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Since v1:
> - add check to setup_default_timer_irq() as well
> - adjust spelling in commit message
> arch/x86/kernel/irqinit.c | 2 +-
> arch/x86/kernel/time.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c
> index 1e6cff5..44f1ed4 100644
> --- a/arch/x86/kernel/irqinit.c
> +++ b/arch/x86/kernel/irqinit.c
> @@ -203,7 +203,7 @@ void __init native_init_IRQ(void)
> set_intr_gate(i, interrupt[i - FIRST_EXTERNAL_VECTOR]);
> }
>
> - if (!acpi_ioapic && !of_ioapic)
> + if (!acpi_ioapic && !of_ioapic && nr_legacy_irqs())
> setup_irq(2, &irq2);
>
> #ifdef CONFIG_X86_32
> diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
> index bf7ef5c..0fa2960 100644
> --- a/arch/x86/kernel/time.c
> +++ b/arch/x86/kernel/time.c
> @@ -68,6 +68,8 @@ static struct irqaction irq0 = {
>
> void __init setup_default_timer_irq(void)
> {
> + if (!nr_legacy_irqs())
> + return;
> setup_irq(0, &irq0);
> }
>
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86: Fix non-PC platform kernel crash on boot due to NULL dereference
2014-07-21 8:38 [PATCH v2] x86: fix kernel crash on boot due to NULL dereference Andy Shevchenko
2014-07-21 8:46 ` Jiang Liu
2014-08-22 12:03 ` Andy Shevchenko
@ 2014-08-25 20:42 ` tip-bot for Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Andy Shevchenko @ 2014-08-25 20:42 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, jiang.liu, hpa, mingo, david.a.cohen, tglx,
andriy.shevchenko
Commit-ID: a90b858cfe27a576f7e44a456af2ee432404ee8f
Gitweb: http://git.kernel.org/tip/a90b858cfe27a576f7e44a456af2ee432404ee8f
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Mon, 21 Jul 2014 11:38:40 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 25 Aug 2014 22:36:57 +0200
x86: Fix non-PC platform kernel crash on boot due to NULL dereference
Upstream commit:
95d76acc7518d5 ("x86, irq: Count legacy IRQs by legacy_pic->nr_legacy_irqs instead of NR_IRQS_LEGACY")
removed reserved interrupts for the platforms that do not have a legacy IOAPIC.
Which breaks the boot on Intel MID platforms such as Medfield:
BUG: unable to handle kernel NULL pointer dereference at 0000003a
IP: [<c107079a>] setup_irq+0xf/0x4d [ 0.000000] *pdpt = 0000000000000000 *pde = 9bbf32453167e510
The culprit is an uncoditional setting of IRQ2 which is used
as cascade IRQ on legacy platforms. It seems we have to check
if we have enough legacy IRQs reserved before we can call
setup_irq().
The fix adds such check in native_init_IRQ() and in setup_default_timer_irq().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Cc: David Cohen <david.a.cohen@linux.intel.com>
Link: http://lkml.kernel.org/r/1405931920-12871-1-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/irqinit.c | 2 +-
arch/x86/kernel/time.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c
index 1e6cff5..44f1ed4 100644
--- a/arch/x86/kernel/irqinit.c
+++ b/arch/x86/kernel/irqinit.c
@@ -203,7 +203,7 @@ void __init native_init_IRQ(void)
set_intr_gate(i, interrupt[i - FIRST_EXTERNAL_VECTOR]);
}
- if (!acpi_ioapic && !of_ioapic)
+ if (!acpi_ioapic && !of_ioapic && nr_legacy_irqs())
setup_irq(2, &irq2);
#ifdef CONFIG_X86_32
diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
index bf7ef5c..0fa2960 100644
--- a/arch/x86/kernel/time.c
+++ b/arch/x86/kernel/time.c
@@ -68,6 +68,8 @@ static struct irqaction irq0 = {
void __init setup_default_timer_irq(void)
{
+ if (!nr_legacy_irqs())
+ return;
setup_irq(0, &irq0);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-25 20:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-21 8:38 [PATCH v2] x86: fix kernel crash on boot due to NULL dereference Andy Shevchenko
2014-07-21 8:46 ` Jiang Liu
2014-08-22 12:03 ` Andy Shevchenko
2014-08-25 20:42 ` [tip:x86/urgent] x86: Fix non-PC platform " tip-bot for Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.