All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] sched: cleanup: remove unused variable in try_to_wake_up()
@ 2010-03-06 11:17 ` Dan Carpenter
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-03-06 11:17 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Peter Zijlstra, Andreas Herrmann, Thomas Gleixner,
	Gautham R Shenoy, linux-kernel, kernel-janitors, efault

We haven't used the "orig_rq" variable since 
055a00865d "Fix/add missing update_rq_clock() calls"

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/sched.c b/kernel/sched.c
index abb36b1..523c750 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2359,7 +2359,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 {
 	int cpu, orig_cpu, this_cpu, success = 0;
 	unsigned long flags;
-	struct rq *rq, *orig_rq;
+	struct rq *rq;
 
 	if (!sched_feat(SYNC_WAKEUPS))
 		wake_flags &= ~WF_SYNC;
@@ -2367,7 +2367,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 	this_cpu = get_cpu();
 
 	smp_wmb();
-	rq = orig_rq = task_rq_lock(p, &flags);
+	rq = task_rq_lock(p, &flags);
 	update_rq_clock(rq);
 	if (!(p->state & state))
 		goto out;

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [patch] sched: cleanup: remove unused variable in try_to_wake_up()
@ 2010-03-06 11:17 ` Dan Carpenter
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-03-06 11:17 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Peter Zijlstra, Andreas Herrmann, Thomas Gleixner,
	Gautham R Shenoy, linux-kernel, kernel-janitors, efault

We haven't used the "orig_rq" variable since 
055a00865d "Fix/add missing update_rq_clock() calls"

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/sched.c b/kernel/sched.c
index abb36b1..523c750 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2359,7 +2359,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 {
 	int cpu, orig_cpu, this_cpu, success = 0;
 	unsigned long flags;
-	struct rq *rq, *orig_rq;
+	struct rq *rq;
 
 	if (!sched_feat(SYNC_WAKEUPS))
 		wake_flags &= ~WF_SYNC;
@@ -2367,7 +2367,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 	this_cpu = get_cpu();
 
 	smp_wmb();
-	rq = orig_rq = task_rq_lock(p, &flags);
+	rq = task_rq_lock(p, &flags);
 	update_rq_clock(rq);
 	if (!(p->state & state))
 		goto out;

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [tip:sched/core] sched: Cleanup: remove unused variable in try_to_wake_up()
  2010-03-06 11:17 ` Dan Carpenter
  (?)
@ 2010-03-11 14:39 ` tip-bot for Dan Carpenter
  -1 siblings, 0 replies; 3+ messages in thread
From: tip-bot for Dan Carpenter @ 2010-03-11 14:39 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, ego, hpa, mingo, andreas.herrmann3, peterz,
	error27, tglx, mingo

Commit-ID:  ab3b3aa5dd01b3aaa6b15caee113b21b1b6520c4
Gitweb:     http://git.kernel.org/tip/ab3b3aa5dd01b3aaa6b15caee113b21b1b6520c4
Author:     Dan Carpenter <error27@gmail.com>
AuthorDate: Sat, 6 Mar 2010 14:17:52 +0300
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 11 Mar 2010 13:59:59 +0100

sched: Cleanup: remove unused variable in try_to_wake_up()

We haven't used the "orig_rq" variable since
055a00865d "Fix/add missing update_rq_clock() calls"

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Gautham R Shenoy <ego@in.ibm.com>
Cc: efault@gmx.de
LKML-Reference: <20100306111752.GL4958@bicker>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 6a212c9..2c1db81 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2359,7 +2359,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 {
 	int cpu, orig_cpu, this_cpu, success = 0;
 	unsigned long flags;
-	struct rq *rq, *orig_rq;
+	struct rq *rq;
 
 	if (!sched_feat(SYNC_WAKEUPS))
 		wake_flags &= ~WF_SYNC;
@@ -2367,7 +2367,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 	this_cpu = get_cpu();
 
 	smp_wmb();
-	rq = orig_rq = task_rq_lock(p, &flags);
+	rq = task_rq_lock(p, &flags);
 	update_rq_clock(rq);
 	if (!(p->state & state))
 		goto out;

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-11 14:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-06 11:17 [patch] sched: cleanup: remove unused variable in try_to_wake_up() Dan Carpenter
2010-03-06 11:17 ` Dan Carpenter
2010-03-11 14:39 ` [tip:sched/core] sched: Cleanup: " tip-bot for Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.