* [PATCH] leds/trigger/cpu: move from CPU_STARTING to ONLINE level
@ 2016-07-20 15:24 Sebastian Andrzej Siewior
2016-07-21 6:48 ` Jacek Anaszewski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-07-20 15:24 UTC (permalink / raw)
To: linux-kernel
Cc: mingo, Sebastian Andrzej Siewior, Jacek Anaszewski,
Linus Torvalds, Linus Walleij, Paul Gortmaker, Peter Zijlstra,
Richard Purdie, Thomas Gleixner, linux-leds, rt
There is no need the ledtriger to be called *that* early in the hotplug
process (+ with disabled interrupts). As explained by Jacek Anaszewski [0]
there is no need for it.
Therefore this patch moves it to the ONLINE/PREPARE_DOWN level using the
dynamic registration for the id.
[0] https://lkml.kernel.org/r/578C92BC.2070603@samsung.com
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-leds@vger.kernel.org
Cc: rt@linutronix.de
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/leds/trigger/ledtrig-cpu.c | 16 ++++++++--------
include/linux/cpuhotplug.h | 1 -
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/trigger/ledtrig-cpu.c b/drivers/leds/trigger/ledtrig-cpu.c
index 4a6a182d0a88..22f0634dd3fa 100644
--- a/drivers/leds/trigger/ledtrig-cpu.c
+++ b/drivers/leds/trigger/ledtrig-cpu.c
@@ -92,13 +92,13 @@ static struct syscore_ops ledtrig_cpu_syscore_ops = {
.resume = ledtrig_cpu_syscore_resume,
};
-static int ledtrig_starting_cpu(unsigned int cpu)
+static int ledtrig_online_cpu(unsigned int cpu)
{
ledtrig_cpu(CPU_LED_START);
return 0;
}
-static int ledtrig_dying_cpu(unsigned int cpu)
+static int ledtrig_prepare_down_cpu(unsigned int cpu)
{
ledtrig_cpu(CPU_LED_STOP);
return 0;
@@ -107,6 +107,7 @@ static int ledtrig_dying_cpu(unsigned int cpu)
static int __init ledtrig_cpu_init(void)
{
int cpu;
+ int ret;
/* Supports up to 9999 cpu cores */
BUILD_BUG_ON(CONFIG_NR_CPUS > 9999);
@@ -126,12 +127,11 @@ static int __init ledtrig_cpu_init(void)
register_syscore_ops(&ledtrig_cpu_syscore_ops);
- /*
- * FIXME: Why needs this to happen in the interrupt disabled
- * low level bringup phase of a cpu?
- */
- cpuhp_setup_state(CPUHP_AP_LEDTRIG_STARTING, "AP_LEDTRIG_STARTING",
- ledtrig_starting_cpu, ledtrig_dying_cpu);
+ ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "AP_LEDTRIG_STARTING",
+ ledtrig_online_cpu, ledtrig_prepare_down_cpu);
+ if (ret < 0)
+ pr_err("CPU hotplug notifier for ledtrig-cpu could not be registered: %d\n",
+ ret);
pr_info("ledtrig-cpu: registered to indicate activity on CPUs\n");
diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
index 09ef54bcba39..282800b42627 100644
--- a/include/linux/cpuhotplug.h
+++ b/include/linux/cpuhotplug.h
@@ -65,7 +65,6 @@ enum cpuhp_state {
CPUHP_AP_ARM_CORESIGHT_STARTING,
CPUHP_AP_ARM_CORESIGHT4_STARTING,
CPUHP_AP_ARM64_ISNDEP_STARTING,
- CPUHP_AP_LEDTRIG_STARTING,
CPUHP_AP_SMPCFD_DYING,
CPUHP_AP_X86_TBOOT_DYING,
CPUHP_AP_NOTIFY_STARTING,
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] leds/trigger/cpu: move from CPU_STARTING to ONLINE level
2016-07-20 15:24 [PATCH] leds/trigger/cpu: move from CPU_STARTING to ONLINE level Sebastian Andrzej Siewior
@ 2016-07-21 6:48 ` Jacek Anaszewski
2016-07-22 15:24 ` Linus Walleij
2016-07-22 19:58 ` [tip:smp/hotplug] leds/trigger/cpu: Move " tip-bot for Sebastian Andrzej Siewior
2 siblings, 0 replies; 4+ messages in thread
From: Jacek Anaszewski @ 2016-07-21 6:48 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-kernel, mingo, Linus Torvalds, Linus Walleij,
Paul Gortmaker, Peter Zijlstra, Richard Purdie, Thomas Gleixner,
linux-leds, rt
Hi Sebastian,
On 07/20/2016 05:24 PM, Sebastian Andrzej Siewior wrote:
> There is no need the ledtriger to be called *that* early in the hotplug
> process (+ with disabled interrupts). As explained by Jacek Anaszewski [0]
> there is no need for it.
> Therefore this patch moves it to the ONLINE/PREPARE_DOWN level using the
> dynamic registration for the id.
>
> [0] https://lkml.kernel.org/r/578C92BC.2070603@samsung.com
>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-leds@vger.kernel.org
> Cc: rt@linutronix.de
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/leds/trigger/ledtrig-cpu.c | 16 ++++++++--------
> include/linux/cpuhotplug.h | 1 -
> 2 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-cpu.c b/drivers/leds/trigger/ledtrig-cpu.c
> index 4a6a182d0a88..22f0634dd3fa 100644
> --- a/drivers/leds/trigger/ledtrig-cpu.c
> +++ b/drivers/leds/trigger/ledtrig-cpu.c
> @@ -92,13 +92,13 @@ static struct syscore_ops ledtrig_cpu_syscore_ops = {
> .resume = ledtrig_cpu_syscore_resume,
> };
>
> -static int ledtrig_starting_cpu(unsigned int cpu)
> +static int ledtrig_online_cpu(unsigned int cpu)
> {
> ledtrig_cpu(CPU_LED_START);
> return 0;
> }
>
> -static int ledtrig_dying_cpu(unsigned int cpu)
> +static int ledtrig_prepare_down_cpu(unsigned int cpu)
> {
> ledtrig_cpu(CPU_LED_STOP);
> return 0;
> @@ -107,6 +107,7 @@ static int ledtrig_dying_cpu(unsigned int cpu)
> static int __init ledtrig_cpu_init(void)
> {
> int cpu;
> + int ret;
>
> /* Supports up to 9999 cpu cores */
> BUILD_BUG_ON(CONFIG_NR_CPUS > 9999);
> @@ -126,12 +127,11 @@ static int __init ledtrig_cpu_init(void)
>
> register_syscore_ops(&ledtrig_cpu_syscore_ops);
>
> - /*
> - * FIXME: Why needs this to happen in the interrupt disabled
> - * low level bringup phase of a cpu?
> - */
> - cpuhp_setup_state(CPUHP_AP_LEDTRIG_STARTING, "AP_LEDTRIG_STARTING",
> - ledtrig_starting_cpu, ledtrig_dying_cpu);
> + ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "AP_LEDTRIG_STARTING",
> + ledtrig_online_cpu, ledtrig_prepare_down_cpu);
> + if (ret < 0)
> + pr_err("CPU hotplug notifier for ledtrig-cpu could not be registered: %d\n",
> + ret);
>
> pr_info("ledtrig-cpu: registered to indicate activity on CPUs\n");
>
> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> index 09ef54bcba39..282800b42627 100644
> --- a/include/linux/cpuhotplug.h
> +++ b/include/linux/cpuhotplug.h
> @@ -65,7 +65,6 @@ enum cpuhp_state {
> CPUHP_AP_ARM_CORESIGHT_STARTING,
> CPUHP_AP_ARM_CORESIGHT4_STARTING,
> CPUHP_AP_ARM64_ISNDEP_STARTING,
> - CPUHP_AP_LEDTRIG_STARTING,
> CPUHP_AP_SMPCFD_DYING,
> CPUHP_AP_X86_TBOOT_DYING,
> CPUHP_AP_NOTIFY_STARTING,
>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds/trigger/cpu: move from CPU_STARTING to ONLINE level
2016-07-20 15:24 [PATCH] leds/trigger/cpu: move from CPU_STARTING to ONLINE level Sebastian Andrzej Siewior
2016-07-21 6:48 ` Jacek Anaszewski
@ 2016-07-22 15:24 ` Linus Walleij
2016-07-22 19:58 ` [tip:smp/hotplug] leds/trigger/cpu: Move " tip-bot for Sebastian Andrzej Siewior
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2016-07-22 15:24 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-kernel, Ingo Molnar, Jacek Anaszewski, Linus Torvalds,
Paul Gortmaker, Peter Zijlstra, Richard Purdie, Thomas Gleixner,
linux-leds, rt
On Wed, Jul 20, 2016 at 5:24 PM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> There is no need the ledtriger to be called *that* early in the hotplug
> process (+ with disabled interrupts). As explained by Jacek Anaszewski [0]
> there is no need for it.
> Therefore this patch moves it to the ONLINE/PREPARE_DOWN level using the
> dynamic registration for the id.
>
> [0] https://lkml.kernel.org/r/578C92BC.2070603@samsung.com
>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-leds@vger.kernel.org
> Cc: rt@linutronix.de
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Read back on the discussion, this change makes all kind of sense.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:smp/hotplug] leds/trigger/cpu: Move from CPU_STARTING to ONLINE level
2016-07-20 15:24 [PATCH] leds/trigger/cpu: move from CPU_STARTING to ONLINE level Sebastian Andrzej Siewior
2016-07-21 6:48 ` Jacek Anaszewski
2016-07-22 15:24 ` Linus Walleij
@ 2016-07-22 19:58 ` tip-bot for Sebastian Andrzej Siewior
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Sebastian Andrzej Siewior @ 2016-07-22 19:58 UTC (permalink / raw)
To: linux-tip-commits
Cc: rpurdie, j.anaszewski, bigeasy, paul.gortmaker, peterz,
linus.walleij, mingo, tglx, hpa, linux-kernel, torvalds
Commit-ID: cd894f149732a06ba4b2ccdc4cb86edf7ff68620
Gitweb: http://git.kernel.org/tip/cd894f149732a06ba4b2ccdc4cb86edf7ff68620
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
AuthorDate: Wed, 20 Jul 2016 17:24:55 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 22 Jul 2016 21:53:18 +0200
leds/trigger/cpu: Move from CPU_STARTING to ONLINE level
There is no need the ledtriger to be called *that* early in the hotplug
process (+ with disabled interrupts). As explained by Jacek Anaszewski [0]
there is no need for it.
Therefore this patch moves it to the ONLINE/PREPARE_DOWN level using the
dynamic registration for the id.
[0] https://lkml.kernel.org/r/578C92BC.2070603@samsung.com
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: rt@linutronix.de
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-leds@vger.kernel.org
Link: http://lkml.kernel.org/r/1469028295-14702-1-git-send-email-bigeasy@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/leds/trigger/ledtrig-cpu.c | 16 ++++++++--------
include/linux/cpuhotplug.h | 1 -
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/trigger/ledtrig-cpu.c b/drivers/leds/trigger/ledtrig-cpu.c
index 4a6a182..22f0634 100644
--- a/drivers/leds/trigger/ledtrig-cpu.c
+++ b/drivers/leds/trigger/ledtrig-cpu.c
@@ -92,13 +92,13 @@ static struct syscore_ops ledtrig_cpu_syscore_ops = {
.resume = ledtrig_cpu_syscore_resume,
};
-static int ledtrig_starting_cpu(unsigned int cpu)
+static int ledtrig_online_cpu(unsigned int cpu)
{
ledtrig_cpu(CPU_LED_START);
return 0;
}
-static int ledtrig_dying_cpu(unsigned int cpu)
+static int ledtrig_prepare_down_cpu(unsigned int cpu)
{
ledtrig_cpu(CPU_LED_STOP);
return 0;
@@ -107,6 +107,7 @@ static int ledtrig_dying_cpu(unsigned int cpu)
static int __init ledtrig_cpu_init(void)
{
int cpu;
+ int ret;
/* Supports up to 9999 cpu cores */
BUILD_BUG_ON(CONFIG_NR_CPUS > 9999);
@@ -126,12 +127,11 @@ static int __init ledtrig_cpu_init(void)
register_syscore_ops(&ledtrig_cpu_syscore_ops);
- /*
- * FIXME: Why needs this to happen in the interrupt disabled
- * low level bringup phase of a cpu?
- */
- cpuhp_setup_state(CPUHP_AP_LEDTRIG_STARTING, "AP_LEDTRIG_STARTING",
- ledtrig_starting_cpu, ledtrig_dying_cpu);
+ ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "AP_LEDTRIG_STARTING",
+ ledtrig_online_cpu, ledtrig_prepare_down_cpu);
+ if (ret < 0)
+ pr_err("CPU hotplug notifier for ledtrig-cpu could not be registered: %d\n",
+ ret);
pr_info("ledtrig-cpu: registered to indicate activity on CPUs\n");
diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
index 5015f46..6d405db 100644
--- a/include/linux/cpuhotplug.h
+++ b/include/linux/cpuhotplug.h
@@ -66,7 +66,6 @@ enum cpuhp_state {
CPUHP_AP_ARM_CORESIGHT_STARTING,
CPUHP_AP_ARM_CORESIGHT4_STARTING,
CPUHP_AP_ARM64_ISNDEP_STARTING,
- CPUHP_AP_LEDTRIG_STARTING,
CPUHP_AP_SMPCFD_DYING,
CPUHP_AP_X86_TBOOT_DYING,
CPUHP_AP_NOTIFY_STARTING,
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-22 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-20 15:24 [PATCH] leds/trigger/cpu: move from CPU_STARTING to ONLINE level Sebastian Andrzej Siewior
2016-07-21 6:48 ` Jacek Anaszewski
2016-07-22 15:24 ` Linus Walleij
2016-07-22 19:58 ` [tip:smp/hotplug] leds/trigger/cpu: Move " tip-bot for Sebastian Andrzej Siewior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.