All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Nicolas Pitre <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	torvalds@linux-foundation.org, peterz@infradead.org,
	nicolas.pitre@linaro.org, akpm@linux-foundation.org,
	nico@linaro.org, tglx@linutronix.de
Subject: [tip:sched/core] sched/idle: Move cpu/idle.c to sched/idle.c
Date: Tue, 11 Feb 2014 04:18:49 -0800	[thread overview]
Message-ID: <tip-cf37b6b48428d6be8f8762b3599d529c44644fb2@git.kernel.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1401301102210.1652@knanqh.ubzr>

Commit-ID:  cf37b6b48428d6be8f8762b3599d529c44644fb2
Gitweb:     http://git.kernel.org/tip/cf37b6b48428d6be8f8762b3599d529c44644fb2
Author:     Nicolas Pitre <nicolas.pitre@linaro.org>
AuthorDate: Sun, 26 Jan 2014 23:42:01 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 11 Feb 2014 09:58:30 +0100

sched/idle: Move cpu/idle.c to sched/idle.c

Integration of cpuidle with the scheduler requires that the idle loop be
closely integrated with the scheduler proper. Moving cpu/idle.c into the
sched directory will allow for a smoother integration, and eliminate a
subdirectory which contained only one source file.

Signed-off-by: Nicolas Pitre <nico@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/alpine.LFD.2.11.1401301102210.1652@knanqh.ubzr
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/Makefile              |  1 -
 kernel/cpu/Makefile          |  1 -
 kernel/sched/Makefile        |  2 +-
 kernel/{cpu => sched}/idle.c | 17 +++++++----------
 4 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/kernel/Makefile b/kernel/Makefile
index bc010ee..6f1c7e5 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -22,7 +22,6 @@ obj-y += sched/
 obj-y += locking/
 obj-y += power/
 obj-y += printk/
-obj-y += cpu/
 obj-y += irq/
 obj-y += rcu/
 
diff --git a/kernel/cpu/Makefile b/kernel/cpu/Makefile
deleted file mode 100644
index 59ab052..0000000
--- a/kernel/cpu/Makefile
+++ /dev/null
@@ -1 +0,0 @@
-obj-y	= idle.o
diff --git a/kernel/sched/Makefile b/kernel/sched/Makefile
index 9a95c8c..ab32b7b 100644
--- a/kernel/sched/Makefile
+++ b/kernel/sched/Makefile
@@ -13,7 +13,7 @@ endif
 
 obj-y += core.o proc.o clock.o cputime.o
 obj-y += idle_task.o fair.o rt.o deadline.o stop_task.o
-obj-y += wait.o completion.o
+obj-y += wait.o completion.o idle.o
 obj-$(CONFIG_SMP) += cpupri.o cpudeadline.o
 obj-$(CONFIG_SCHED_AUTOGROUP) += auto_group.o
 obj-$(CONFIG_SCHEDSTATS) += stats.o
diff --git a/kernel/cpu/idle.c b/kernel/sched/idle.c
similarity index 91%
copy from kernel/cpu/idle.c
copy to kernel/sched/idle.c
index b7976a1..14ca434 100644
--- a/kernel/cpu/idle.c
+++ b/kernel/sched/idle.c
@@ -108,17 +108,14 @@ static void cpu_idle_loop(void)
 				__current_set_polling();
 			}
 			arch_cpu_idle_exit();
+			/*
+			 * We need to test and propagate the TIF_NEED_RESCHED
+			 * bit here because we might not have send the
+			 * reschedule IPI to idle tasks.
+			 */
+			if (tif_need_resched())
+				set_preempt_need_resched();
 		}
-
-		/*
-		 * Since we fell out of the loop above, we know
-		 * TIF_NEED_RESCHED must be set, propagate it into
-		 * PREEMPT_NEED_RESCHED.
-		 *
-		 * This is required because for polling idle loops we will
-		 * not have had an IPI to fold the state for us.
-		 */
-		preempt_set_need_resched();
 		tick_nohz_idle_exit();
 		schedule_preempt_disabled();
 	}

  parent reply	other threads:[~2014-02-11 12:19 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 17:45 [PATCH v2 0/6] setting the table for integration of cpuidle with the scheduler Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 20:31   ` Nicolas Pitre
2014-01-29 20:31     ` Nicolas Pitre
2014-01-29 20:31     ` Nicolas Pitre
2014-01-29 20:31     ` Nicolas Pitre
2014-01-30  3:38     ` Preeti U Murthy
2014-01-30  3:50       ` Preeti U Murthy
2014-01-30  3:38       ` Preeti U Murthy
2014-01-30  3:38       ` Preeti U Murthy
2014-01-30  5:28       ` Nicolas Pitre
2014-01-30  5:28         ` Nicolas Pitre
2014-01-30  5:28         ` Nicolas Pitre
2014-01-30  5:28         ` Nicolas Pitre
2014-01-30  5:50         ` Preeti U Murthy
2014-01-30  5:53           ` Preeti U Murthy
2014-01-30  5:50           ` Preeti U Murthy
2014-01-30  5:50           ` Preeti U Murthy
2014-01-30 13:44         ` Daniel Lezcano
2014-01-30 13:44           ` Daniel Lezcano
2014-01-30 13:44           ` Daniel Lezcano
2014-01-30 13:44           ` Daniel Lezcano
2014-01-30 16:07           ` Nicolas Pitre
2014-01-30 16:07             ` Nicolas Pitre
2014-01-30 16:07             ` Nicolas Pitre
2014-01-30 16:07             ` Nicolas Pitre
2014-01-30 17:28             ` Daniel Lezcano
2014-01-30 17:28               ` Daniel Lezcano
2014-01-30 17:28               ` Daniel Lezcano
2014-01-30 17:28               ` Daniel Lezcano
2014-01-30 18:06               ` Peter Zijlstra
2014-01-30 18:06                 ` Peter Zijlstra
2014-01-30 18:06                 ` Peter Zijlstra
2014-01-30 18:06                 ` Peter Zijlstra
2014-01-30 19:24               ` Nicolas Pitre
2014-01-30 19:24                 ` Nicolas Pitre
2014-01-30 19:24                 ` Nicolas Pitre
2014-01-30 19:24                 ` Nicolas Pitre
2014-02-11 12:17     ` [tip:sched/core] sched/idle: Move " tip-bot for Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 2/6] ARM: remove redundant cpuidle_idle_call() Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 3/6] PPC: " Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 4/6] SH: " Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 5/6] X86: " Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 19:02   ` Olof Johansson
2014-01-29 19:02     ` Olof Johansson
2014-01-29 19:02     ` Olof Johansson
2014-01-29 19:02     ` Olof Johansson
2014-01-29 19:02     ` Olof Johansson
2014-01-29 20:14     ` Nicolas Pitre
2014-01-29 20:14       ` Nicolas Pitre
2014-01-29 20:14       ` Nicolas Pitre
2014-01-29 20:14       ` Nicolas Pitre
2014-01-29 20:14       ` Nicolas Pitre
2014-01-30  9:24       ` Peter Zijlstra
2014-01-30  9:24         ` Peter Zijlstra
2014-01-30  9:24         ` Peter Zijlstra
2014-01-30  9:24         ` Peter Zijlstra
2014-01-30  9:24         ` Peter Zijlstra
2014-01-29 17:45 ` [PATCH v2 6/6] cpu/idle.c: move to sched/idle.c Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-29 17:45   ` Nicolas Pitre
2014-01-30 15:25   ` Peter Zijlstra
2014-01-30 15:25     ` Peter Zijlstra
2014-01-30 15:25     ` Peter Zijlstra
2014-01-30 15:25     ` Peter Zijlstra
2014-01-30 15:25     ` Peter Zijlstra
2014-01-30 16:03     ` Nicolas Pitre
2014-01-30 16:03       ` Nicolas Pitre
2014-01-30 16:03       ` Nicolas Pitre
2014-01-30 16:03       ` Nicolas Pitre
2014-01-30 16:27       ` Peter Zijlstra
2014-01-30 16:27         ` Peter Zijlstra
2014-01-30 16:27         ` Peter Zijlstra
2014-01-30 16:27         ` Peter Zijlstra
2014-01-30 16:27         ` Peter Zijlstra
2014-01-30 16:41         ` Joe Perches
2014-01-30 16:41           ` Joe Perches
2014-01-30 16:41           ` Joe Perches
2014-01-30 16:41           ` Joe Perches
2014-01-30 16:52           ` Peter Zijlstra
2014-01-30 16:52             ` Peter Zijlstra
2014-01-30 16:52             ` Peter Zijlstra
2014-01-30 16:52             ` Peter Zijlstra
2014-01-30 16:52             ` Peter Zijlstra
2014-02-06 14:09         ` Nicolas Pitre
2014-02-06 14:09           ` Nicolas Pitre
2014-02-06 14:09           ` Nicolas Pitre
2014-02-06 14:09           ` Nicolas Pitre
2014-02-06 16:43           ` Peter Zijlstra
2014-02-06 16:43             ` Peter Zijlstra
2014-02-06 16:43             ` Peter Zijlstra
2014-02-06 16:43             ` Peter Zijlstra
2014-02-07 11:09             ` Nicolas Pitre
2014-02-07 11:09               ` Nicolas Pitre
2014-02-07 11:09               ` Nicolas Pitre
2014-02-07 11:09               ` Nicolas Pitre
2014-02-07 12:32               ` Peter Zijlstra
2014-02-07 12:32                 ` Peter Zijlstra
2014-02-07 12:32                 ` Peter Zijlstra
2014-02-07 12:32                 ` Peter Zijlstra
2014-02-07 12:32                 ` Peter Zijlstra
2014-02-11 12:18       ` tip-bot for Nicolas Pitre [this message]
2014-01-30  9:28 ` [PATCH v2 0/6] setting the table for integration of cpuidle with the scheduler Peter Zijlstra
2014-01-30  9:28   ` Peter Zijlstra
2014-01-30  9:28   ` Peter Zijlstra
2014-01-30  9:28   ` Peter Zijlstra
2014-01-30  9:28   ` Peter Zijlstra
2014-01-30 13:31   ` Nicolas Pitre
2014-01-30 13:31     ` Nicolas Pitre
2014-01-30 13:31     ` Nicolas Pitre
2014-01-30 13:31     ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-cf37b6b48428d6be8f8762b3599d529c44644fb2@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nico@linaro.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.