All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] softirq: use _RET_IP_
@ 2013-04-30 18:46 Davidlohr Bueso
  2013-05-07  0:03 ` Frederic Weisbecker
  2013-06-28 12:15 ` [tip:irq/core] softirq: Use _RET_IP_ tip-bot for Davidlohr Bueso
  0 siblings, 2 replies; 3+ messages in thread
From: Davidlohr Bueso @ 2013-04-30 18:46 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Frederic Weisbecker, Thomas Gleixner, LKML

From: Davidlohr Bueso <davidlohr.bueso@hp.com>

Use the already defined macro to pass the function return address.

Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
---
 kernel/softirq.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 14d7758..8cd0d58 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -127,8 +127,7 @@ static inline void __local_bh_disable(unsigned long ip, unsigned int cnt)
 
 void local_bh_disable(void)
 {
-	__local_bh_disable((unsigned long)__builtin_return_address(0),
-				SOFTIRQ_DISABLE_OFFSET);
+	__local_bh_disable(_RET_IP_, SOFTIRQ_DISABLE_OFFSET);
 }
 
 EXPORT_SYMBOL(local_bh_disable);
@@ -139,7 +138,7 @@ static void __local_bh_enable(unsigned int cnt)
 	WARN_ON_ONCE(!irqs_disabled());
 
 	if (softirq_count() == cnt)
-		trace_softirqs_on((unsigned long)__builtin_return_address(0));
+		trace_softirqs_on(_RET_IP_);
 	sub_preempt_count(cnt);
 }
 
@@ -184,7 +183,7 @@ static inline void _local_bh_enable_ip(unsigned long ip)
 
 void local_bh_enable(void)
 {
-	_local_bh_enable_ip((unsigned long)__builtin_return_address(0));
+	_local_bh_enable_ip(_RET_IP_);
 }
 EXPORT_SYMBOL(local_bh_enable);
 
@@ -223,8 +222,7 @@ asmlinkage void __do_softirq(void)
 	pending = local_softirq_pending();
 	account_irq_enter_time(current);
 
-	__local_bh_disable((unsigned long)__builtin_return_address(0),
-				SOFTIRQ_OFFSET);
+	__local_bh_disable(_RET_IP_, SOFTIRQ_OFFSET);
 	lockdep_softirq_enter();
 
 	cpu = smp_processor_id();
-- 
1.7.11.7




^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] softirq: use _RET_IP_
  2013-04-30 18:46 [PATCH] softirq: use _RET_IP_ Davidlohr Bueso
@ 2013-05-07  0:03 ` Frederic Weisbecker
  2013-06-28 12:15 ` [tip:irq/core] softirq: Use _RET_IP_ tip-bot for Davidlohr Bueso
  1 sibling, 0 replies; 3+ messages in thread
From: Frederic Weisbecker @ 2013-05-07  0:03 UTC (permalink / raw)
  To: Davidlohr Bueso; +Cc: Andrew Morton, Thomas Gleixner, LKML

On Tue, Apr 30, 2013 at 11:46:09AM -0700, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <davidlohr.bueso@hp.com>
> 
> Use the already defined macro to pass the function return address.
> 
> Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>

Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip:irq/core] softirq: Use _RET_IP_
  2013-04-30 18:46 [PATCH] softirq: use _RET_IP_ Davidlohr Bueso
  2013-05-07  0:03 ` Frederic Weisbecker
@ 2013-06-28 12:15 ` tip-bot for Davidlohr Bueso
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Davidlohr Bueso @ 2013-06-28 12:15 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, fweisbec, davidlohr.bueso, tglx

Commit-ID:  d2e08473f2488d53a71c2f53455f934ec6c44c53
Gitweb:     http://git.kernel.org/tip/d2e08473f2488d53a71c2f53455f934ec6c44c53
Author:     Davidlohr Bueso <davidlohr.bueso@hp.com>
AuthorDate: Tue, 30 Apr 2013 11:46:09 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 28 Jun 2013 14:10:57 +0200

softirq: Use _RET_IP_

Use the already defined macro to pass the function return address.

Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/1367347569.1784.3.camel@buesod1.americas.hpqcorp.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/softirq.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index b5197dc..a5f8836 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -127,8 +127,7 @@ static inline void __local_bh_disable(unsigned long ip, unsigned int cnt)
 
 void local_bh_disable(void)
 {
-	__local_bh_disable((unsigned long)__builtin_return_address(0),
-				SOFTIRQ_DISABLE_OFFSET);
+	__local_bh_disable(_RET_IP_, SOFTIRQ_DISABLE_OFFSET);
 }
 
 EXPORT_SYMBOL(local_bh_disable);
@@ -139,7 +138,7 @@ static void __local_bh_enable(unsigned int cnt)
 	WARN_ON_ONCE(!irqs_disabled());
 
 	if (softirq_count() == cnt)
-		trace_softirqs_on((unsigned long)__builtin_return_address(0));
+		trace_softirqs_on(_RET_IP_);
 	sub_preempt_count(cnt);
 }
 
@@ -184,7 +183,7 @@ static inline void _local_bh_enable_ip(unsigned long ip)
 
 void local_bh_enable(void)
 {
-	_local_bh_enable_ip((unsigned long)__builtin_return_address(0));
+	_local_bh_enable_ip(_RET_IP_);
 }
 EXPORT_SYMBOL(local_bh_enable);
 
@@ -223,8 +222,7 @@ asmlinkage void __do_softirq(void)
 	pending = local_softirq_pending();
 	account_irq_enter_time(current);
 
-	__local_bh_disable((unsigned long)__builtin_return_address(0),
-				SOFTIRQ_OFFSET);
+	__local_bh_disable(_RET_IP_, SOFTIRQ_OFFSET);
 	lockdep_softirq_enter();
 
 	cpu = smp_processor_id();

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-28 12:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-30 18:46 [PATCH] softirq: use _RET_IP_ Davidlohr Bueso
2013-05-07  0:03 ` Frederic Weisbecker
2013-06-28 12:15 ` [tip:irq/core] softirq: Use _RET_IP_ tip-bot for Davidlohr Bueso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.