* [PATCH] kexec: Remove obsolete flag 'in_crash_kexec'
@ 2015-10-05 18:35 ` Minfei Huang
0 siblings, 0 replies; 5+ messages in thread
From: Minfei Huang @ 2015-10-05 18:35 UTC (permalink / raw)
To: dzickus, cpw, akpm, tglx; +Cc: mhuang, x86, kexec, linux-kernel, Minfei Huang
From: Minfei Huang <mnfhuang@gmail.com>
Previously, UV NMI used 'in_crash_kexec' flag to be sure that we are in
kdump kernel or not in commit 5edd19af18a36a4e22c570b1b969179e0ca1fe4c
("x86, UV: Make kdump avoid stack dumps"). But this flags is removed in
commit 9c48f1c629ecfa114850c03f875c6691003214de ("x86, nmi: Wire up NMI
handlers to new routines").
Since it isn't used any more, remove it.
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
arch/x86/include/asm/kdebug.h | 6 ------
arch/x86/kernel/crash.c | 3 ---
2 files changed, 9 deletions(-)
diff --git a/arch/x86/include/asm/kdebug.h b/arch/x86/include/asm/kdebug.h
index b130d59..e5f5dc9 100644
--- a/arch/x86/include/asm/kdebug.h
+++ b/arch/x86/include/asm/kdebug.h
@@ -29,11 +29,5 @@ extern void show_trace(struct task_struct *t, struct pt_regs *regs,
extern void __show_regs(struct pt_regs *regs, int all);
extern unsigned long oops_begin(void);
extern void oops_end(unsigned long, struct pt_regs *, int signr);
-#ifdef CONFIG_KEXEC_CORE
-extern int in_crash_kexec;
-#else
-/* no crash dump is ever in progress if no crash kernel can be kexec'd */
-#define in_crash_kexec 0
-#endif
#endif /* _ASM_X86_KDEBUG_H */
diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 74ca2fe..2c1910f 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -75,8 +75,6 @@ struct crash_memmap_data {
unsigned int type;
};
-int in_crash_kexec;
-
/*
* This is used to VMCLEAR all VMCSs loaded on the
* processor. And when loading kvm_intel module, the
@@ -132,7 +130,6 @@ static void kdump_nmi_callback(int cpu, struct pt_regs *regs)
static void kdump_nmi_shootdown_cpus(void)
{
- in_crash_kexec = 1;
nmi_shootdown_cpus(kdump_nmi_callback);
disable_local_APIC();
--
2.4.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] kexec: Remove obsolete flag 'in_crash_kexec'
2015-10-05 18:35 ` Minfei Huang
@ 2015-10-05 19:12 ` Don Zickus
-1 siblings, 0 replies; 5+ messages in thread
From: Don Zickus @ 2015-10-05 19:12 UTC (permalink / raw)
To: Minfei Huang; +Cc: cpw, akpm, tglx, linux-kernel, x86, kexec, Minfei Huang
On Tue, Oct 06, 2015 at 02:35:55AM +0800, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@gmail.com>
>
> Previously, UV NMI used 'in_crash_kexec' flag to be sure that we are in
> kdump kernel or not in commit 5edd19af18a36a4e22c570b1b969179e0ca1fe4c
> ("x86, UV: Make kdump avoid stack dumps"). But this flags is removed in
> commit 9c48f1c629ecfa114850c03f875c6691003214de ("x86, nmi: Wire up NMI
> handlers to new routines").
Sounds right.
Acked-by: Don Zickus <dzickus@redhat.com>
>
> Since it isn't used any more, remove it.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
> arch/x86/include/asm/kdebug.h | 6 ------
> arch/x86/kernel/crash.c | 3 ---
> 2 files changed, 9 deletions(-)
>
> diff --git a/arch/x86/include/asm/kdebug.h b/arch/x86/include/asm/kdebug.h
> index b130d59..e5f5dc9 100644
> --- a/arch/x86/include/asm/kdebug.h
> +++ b/arch/x86/include/asm/kdebug.h
> @@ -29,11 +29,5 @@ extern void show_trace(struct task_struct *t, struct pt_regs *regs,
> extern void __show_regs(struct pt_regs *regs, int all);
> extern unsigned long oops_begin(void);
> extern void oops_end(unsigned long, struct pt_regs *, int signr);
> -#ifdef CONFIG_KEXEC_CORE
> -extern int in_crash_kexec;
> -#else
> -/* no crash dump is ever in progress if no crash kernel can be kexec'd */
> -#define in_crash_kexec 0
> -#endif
>
> #endif /* _ASM_X86_KDEBUG_H */
> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index 74ca2fe..2c1910f 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -75,8 +75,6 @@ struct crash_memmap_data {
> unsigned int type;
> };
>
> -int in_crash_kexec;
> -
> /*
> * This is used to VMCLEAR all VMCSs loaded on the
> * processor. And when loading kvm_intel module, the
> @@ -132,7 +130,6 @@ static void kdump_nmi_callback(int cpu, struct pt_regs *regs)
>
> static void kdump_nmi_shootdown_cpus(void)
> {
> - in_crash_kexec = 1;
> nmi_shootdown_cpus(kdump_nmi_callback);
>
> disable_local_APIC();
> --
> 2.4.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] kexec: Remove obsolete flag 'in_crash_kexec'
@ 2015-10-05 19:12 ` Don Zickus
0 siblings, 0 replies; 5+ messages in thread
From: Don Zickus @ 2015-10-05 19:12 UTC (permalink / raw)
To: Minfei Huang; +Cc: x86, kexec, linux-kernel, cpw, Minfei Huang, akpm, tglx
On Tue, Oct 06, 2015 at 02:35:55AM +0800, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@gmail.com>
>
> Previously, UV NMI used 'in_crash_kexec' flag to be sure that we are in
> kdump kernel or not in commit 5edd19af18a36a4e22c570b1b969179e0ca1fe4c
> ("x86, UV: Make kdump avoid stack dumps"). But this flags is removed in
> commit 9c48f1c629ecfa114850c03f875c6691003214de ("x86, nmi: Wire up NMI
> handlers to new routines").
Sounds right.
Acked-by: Don Zickus <dzickus@redhat.com>
>
> Since it isn't used any more, remove it.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
> arch/x86/include/asm/kdebug.h | 6 ------
> arch/x86/kernel/crash.c | 3 ---
> 2 files changed, 9 deletions(-)
>
> diff --git a/arch/x86/include/asm/kdebug.h b/arch/x86/include/asm/kdebug.h
> index b130d59..e5f5dc9 100644
> --- a/arch/x86/include/asm/kdebug.h
> +++ b/arch/x86/include/asm/kdebug.h
> @@ -29,11 +29,5 @@ extern void show_trace(struct task_struct *t, struct pt_regs *regs,
> extern void __show_regs(struct pt_regs *regs, int all);
> extern unsigned long oops_begin(void);
> extern void oops_end(unsigned long, struct pt_regs *, int signr);
> -#ifdef CONFIG_KEXEC_CORE
> -extern int in_crash_kexec;
> -#else
> -/* no crash dump is ever in progress if no crash kernel can be kexec'd */
> -#define in_crash_kexec 0
> -#endif
>
> #endif /* _ASM_X86_KDEBUG_H */
> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index 74ca2fe..2c1910f 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -75,8 +75,6 @@ struct crash_memmap_data {
> unsigned int type;
> };
>
> -int in_crash_kexec;
> -
> /*
> * This is used to VMCLEAR all VMCSs loaded on the
> * processor. And when loading kvm_intel module, the
> @@ -132,7 +130,6 @@ static void kdump_nmi_callback(int cpu, struct pt_regs *regs)
>
> static void kdump_nmi_shootdown_cpus(void)
> {
> - in_crash_kexec = 1;
> nmi_shootdown_cpus(kdump_nmi_callback);
>
> disable_local_APIC();
> --
> 2.4.0
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:x86/boot] x86/kexec: Remove obsolete 'in_crash_kexec' flag
2015-10-05 18:35 ` Minfei Huang
(?)
(?)
@ 2015-10-12 7:45 ` tip-bot for Minfei Huang
-1 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Minfei Huang @ 2015-10-12 7:45 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, dzickus, hpa, torvalds, mingo, mnfhuang, linux-kernel, peterz
Commit-ID: e9c40d257fdd58c5cc97d3fe3aa141dd23ee5e9d
Gitweb: http://git.kernel.org/tip/e9c40d257fdd58c5cc97d3fe3aa141dd23ee5e9d
Author: Minfei Huang <mnfhuang@gmail.com>
AuthorDate: Tue, 6 Oct 2015 02:35:55 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 12 Oct 2015 09:43:11 +0200
x86/kexec: Remove obsolete 'in_crash_kexec' flag
Previously, UV NMI used the 'in_crash_kexec' flag to determine whether
we are in a kdump kernel or not:
5edd19af18a36a4 ("x86, UV: Make kdump avoid stack dumps")
But this flags was removed in the following commit:
9c48f1c629ecfa1 ("x86, nmi: Wire up NMI handlers to new routines")
Since it isn't used any more, remove it.
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: cpw@sgi.com
Cc: kexec@lists.infradead.org
Cc: mhuang@redhat.com
Link: http://lkml.kernel.org/r/1444070155-17934-1-git-send-email-mhuang@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/kdebug.h | 6 ------
arch/x86/kernel/crash.c | 3 ---
2 files changed, 9 deletions(-)
diff --git a/arch/x86/include/asm/kdebug.h b/arch/x86/include/asm/kdebug.h
index b130d59..e5f5dc9 100644
--- a/arch/x86/include/asm/kdebug.h
+++ b/arch/x86/include/asm/kdebug.h
@@ -29,11 +29,5 @@ extern void show_trace(struct task_struct *t, struct pt_regs *regs,
extern void __show_regs(struct pt_regs *regs, int all);
extern unsigned long oops_begin(void);
extern void oops_end(unsigned long, struct pt_regs *, int signr);
-#ifdef CONFIG_KEXEC_CORE
-extern int in_crash_kexec;
-#else
-/* no crash dump is ever in progress if no crash kernel can be kexec'd */
-#define in_crash_kexec 0
-#endif
#endif /* _ASM_X86_KDEBUG_H */
diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 74ca2fe..2c1910f 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -75,8 +75,6 @@ struct crash_memmap_data {
unsigned int type;
};
-int in_crash_kexec;
-
/*
* This is used to VMCLEAR all VMCSs loaded on the
* processor. And when loading kvm_intel module, the
@@ -132,7 +130,6 @@ static void kdump_nmi_callback(int cpu, struct pt_regs *regs)
static void kdump_nmi_shootdown_cpus(void)
{
- in_crash_kexec = 1;
nmi_shootdown_cpus(kdump_nmi_callback);
disable_local_APIC();
^ permalink raw reply related [flat|nested] 5+ messages in thread