All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	markus@trippelsdorf.de, a.p.zijlstra@chello.nl,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/urgent] sched: Fix cross-cpu clock sync on remote wakeups
Date: Tue, 31 May 2011 12:31:20 GMT	[thread overview]
Message-ID: <tip-f01114cb59d670e9b4f2c335930dd57db96e9360@git.kernel.org> (raw)
In-Reply-To: <1306835745.2353.3.camel@twins>

Commit-ID:  f01114cb59d670e9b4f2c335930dd57db96e9360
Gitweb:     http://git.kernel.org/tip/f01114cb59d670e9b4f2c335930dd57db96e9360
Author:     Peter Zijlstra <a.p.zijlstra@chello.nl>
AuthorDate: Tue, 31 May 2011 12:26:55 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 31 May 2011 14:19:56 +0200

sched: Fix cross-cpu clock sync on remote wakeups

Markus reported that commit 317f394160e ("sched: Move the second half
of ttwu() to the remote cpu") caused some accounting funnies on his AMD
Phenom II X4, such as weird 'top' results.

It turns out that this is due to non-synced TSC and the queued remote
wakeups stopped coupeling the two relevant cpu clocks, which leads to
wakeups seeing time jumps, which in turn lead to skewed runtime stats.

Add an explicit call to sched_clock_cpu() to couple the per-cpu clocks
to restore the normal flow of time.

Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1306835745.2353.3.camel@twins
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index cbb3a0e..49cc70b 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2600,6 +2600,7 @@ static void ttwu_queue(struct task_struct *p, int cpu)
 
 #if defined(CONFIG_SMP)
 	if (sched_feat(TTWU_QUEUE) && cpu != smp_processor_id()) {
+		sched_clock_cpu(cpu); /* sync clocks x-cpu */
 		ttwu_queue_remote(p, cpu);
 		return;
 	}

  parent reply	other threads:[~2011-05-31 12:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 17:39 Very high CPU values in top on idle system (3.0-rc1) Markus Trippelsdorf
2011-05-30 18:05 ` Peter Zijlstra
2011-05-30 18:23   ` Markus Trippelsdorf
2011-05-30 20:45     ` Markus Trippelsdorf
2011-05-30 22:12       ` Peter Zijlstra
2011-05-31  9:55         ` Peter Zijlstra
2011-05-31 10:04           ` Markus Trippelsdorf
2011-05-31 12:31           ` tip-bot for Peter Zijlstra [this message]
2011-05-31 12:56             ` [tip:sched/urgent] sched: Fix cross-cpu clock sync on remote wakeups Borislav Petkov
2011-05-31 13:11               ` Peter Zijlstra
2011-06-01  7:05                 ` Borislav Petkov
2011-06-01 10:36                   ` Peter Zijlstra
2011-06-01 15:50                     ` Borislav Petkov
2011-06-02  7:52                       ` Yong Zhang
2011-06-02 13:04                         ` Peter Zijlstra
2011-06-02 14:23                           ` Yong Zhang
2011-06-02 15:48                             ` Peter Zijlstra
2011-06-03  6:49                               ` Yong Zhang
2011-06-07 13:12                               ` Borislav Petkov
2011-06-07 13:16                                 ` Peter Zijlstra
2011-06-03  9:57                             ` Milton Miller
2011-06-03 10:36                               ` Peter Zijlstra
2011-06-03 10:55                                 ` Peter Zijlstra
2011-06-03 10:58                                   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-f01114cb59d670e9b4f2c335930dd57db96e9360@git.kernel.org \
    --to=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.