All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Dewet Thibaut <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: bp@suse.de, tony.luck@intel.com, linux-kernel@vger.kernel.org,
	linux-edac@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de,
	thibaut.dewet@nokia.com, alexander.sverdlin@nokia.com,
	hpa@zytor.com
Subject: [tip:x86/urgent] x86/MCE: Remove min interval polling limitation
Date: Tue, 17 Jul 2018 07:54:52 -0700	[thread overview]
Message-ID: <tip-fd4054b31af283af9ec44895e561bbb3449ad81d@git.kernel.org> (raw)
In-Reply-To: <20180716084927.24869-1-alexander.sverdlin@nokia.com>

Commit-ID:  fd4054b31af283af9ec44895e561bbb3449ad81d
Gitweb:     https://git.kernel.org/tip/fd4054b31af283af9ec44895e561bbb3449ad81d
Author:     Dewet Thibaut <thibaut.dewet@nokia.com>
AuthorDate: Mon, 16 Jul 2018 10:49:27 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 17 Jul 2018 16:50:17 +0200

x86/MCE: Remove min interval polling limitation

commit b3b7c4795c ("x86/MCE: Serialize sysfs changes") introduced a min
interval limitation when setting the check interval for polled MCEs.
However, the logic is that 0 disables polling for corrected MCEs, see
Documentation/x86/x86_64/machinecheck. The limitation prevents disabling.

Remove this limitation and allow the value 0 to disable polling again.

Fixes: b3b7c4795c ("x86/MCE: Serialize sysfs changes")
Signed-off-by: Dewet Thibaut <thibaut.dewet@nokia.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
[ Massage commit message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180716084927.24869-1-alexander.sverdlin@nokia.com
---
 arch/x86/kernel/cpu/mcheck/mce.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index c102ad51025e..8c50754c09c1 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2165,9 +2165,6 @@ static ssize_t store_int_with_restart(struct device *s,
 	if (check_interval == old_check_interval)
 		return ret;
 
-	if (check_interval < 1)
-		check_interval = 1;
-
 	mutex_lock(&mce_sysfs_mutex);
 	mce_restart();
 	mutex_unlock(&mce_sysfs_mutex);

WARNING: multiple messages have this Message-ID (diff)
From: tip-bot for Borislav Petkov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: bp@suse.de, tony.luck@intel.com, linux-kernel@vger.kernel.org,
	linux-edac@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de,
	thibaut.dewet@nokia.com, alexander.sverdlin@nokia.com,
	hpa@zytor.com
Subject: [tip:x86/urgent] x86/MCE: Remove min interval polling limitation
Date: Tue, 17 Jul 2018 07:54:52 -0700	[thread overview]
Message-ID: <tip-fd4054b31af283af9ec44895e561bbb3449ad81d@git.kernel.org> (raw)

Commit-ID:  fd4054b31af283af9ec44895e561bbb3449ad81d
Gitweb:     https://git.kernel.org/tip/fd4054b31af283af9ec44895e561bbb3449ad81d
Author:     Dewet Thibaut <thibaut.dewet@nokia.com>
AuthorDate: Mon, 16 Jul 2018 10:49:27 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 17 Jul 2018 16:50:17 +0200

x86/MCE: Remove min interval polling limitation

commit b3b7c4795c ("x86/MCE: Serialize sysfs changes") introduced a min
interval limitation when setting the check interval for polled MCEs.
However, the logic is that 0 disables polling for corrected MCEs, see
Documentation/x86/x86_64/machinecheck. The limitation prevents disabling.

Remove this limitation and allow the value 0 to disable polling again.

Fixes: b3b7c4795c ("x86/MCE: Serialize sysfs changes")
Signed-off-by: Dewet Thibaut <thibaut.dewet@nokia.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
[ Massage commit message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180716084927.24869-1-alexander.sverdlin@nokia.com
---
 arch/x86/kernel/cpu/mcheck/mce.c | 3 ---
 1 file changed, 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index c102ad51025e..8c50754c09c1 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2165,9 +2165,6 @@ static ssize_t store_int_with_restart(struct device *s,
 	if (check_interval == old_check_interval)
 		return ret;
 
-	if (check_interval < 1)
-		check_interval = 1;
-
 	mutex_lock(&mce_sysfs_mutex);
 	mce_restart();
 	mutex_unlock(&mce_sysfs_mutex);

  reply	other threads:[~2018-07-17 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16  8:49 x86/MCE: Remove min interval limitation Alexander Sverdlin
2018-07-16  8:49 ` [PATCH] " Alexander Sverdlin
2018-07-17 14:54 ` tip-bot for Dewet Thibaut [this message]
2018-07-17 14:54   ` [tip:x86/urgent] x86/MCE: Remove min interval polling limitation tip-bot for Borislav Petkov
2018-07-17 16:00 ` tip-bot for Dewet Thibaut
2018-07-17 16:00   ` tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-fd4054b31af283af9ec44895e561bbb3449ad81d@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thibaut.dewet@nokia.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.