All of lore.kernel.org
 help / color / mirror / Atom feed
* [tip:perf/core] perf header: Display feature name on write failure
@ 2016-10-24 18:55 tip-bot for Jiri Olsa
  0 siblings, 0 replies; only message in thread
From: tip-bot for Jiri Olsa @ 2016-10-24 18:55 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: jolsa, acme, tglx, adrian.hunter, hpa, linux-kernel, dsahern,
	wangnan0, namhyung, mingo

Commit-ID:  0c2aff4c78e83f3185bf5affa434618815ab77bf
Gitweb:     http://git.kernel.org/tip/0c2aff4c78e83f3185bf5affa434618815ab77bf
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Mon, 10 Oct 2016 09:38:02 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 24 Oct 2016 11:07:34 -0300

perf header: Display feature name on write failure

Display name of feature instead of just the number
during recording data.

Before:
  failed to write feature 13

Now:
  failed to write feature HEADER_CPU_TOPOLOGY

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-k9d9trozi5kkx737cy8n5xh5@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/header.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index d6310c6..d89c9c7 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -2290,7 +2290,7 @@ static int do_write_feat(int fd, struct perf_header *h, int type,
 
 		err = feat_ops[type].write(fd, h, evlist);
 		if (err < 0) {
-			pr_debug("failed to write feature %d\n", type);
+			pr_debug("failed to write feature %s\n", feat_ops[type].name);
 
 			/* undo anything written */
 			lseek(fd, (*p)->offset, SEEK_SET);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-24 18:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24 18:55 [tip:perf/core] perf header: Display feature name on write failure tip-bot for Jiri Olsa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.