* [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
@ 2020-09-26 9:55 Dagg Stompler
2020-09-26 13:39 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Dagg Stompler @ 2020-09-26 9:55 UTC (permalink / raw)
To: buildroot
dvb-apps fails to build with glibc 2.31 with the following error:
| dvbdate.c: In function set_time:
| dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration]
| 312 | if (stime(new_time)) {
| | ^~~~~
| | ctime
this patch takes from the first entry in the reference fixes it.
reference:
1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
package/dvb-apps/0006-fix-glibc-2.31.patch | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 package/dvb-apps/0006-fix-glibc-2.31.patch
diff --git a/package/dvb-apps/0006-fix-glibc-2.31.patch b/package/dvb-apps/0006-fix-glibc-2.31.patch
new file mode 100644
index 0000000000..d404212b5e
--- /dev/null
+++ b/package/dvb-apps/0006-fix-glibc-2.31.patch
@@ -0,0 +1,14 @@
+--- a/util/dvbdate/dvbdate.c
++++ b/util/dvbdate/dvbdate.c
+@@ -309,7 +309,10 @@
+ */
+ int set_time(time_t * new_time)
+ {
+- if (stime(new_time)) {
++ struct timespec s = {0};
++ s.tv_sec = new_time;
++
++ if (clock_settime(CLOCK_REALTIME, &s)) {
+ perror("Unable to set time");
+ return -1;
+ }
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
2020-09-26 9:55 [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31 Dagg Stompler
@ 2020-09-26 13:39 ` Thomas Petazzoni
2020-09-26 16:06 ` daggs
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-09-26 13:39 UTC (permalink / raw)
To: buildroot
Hello,
Thanks for the patch. There are however a few coding style issues.
First, the commit title must always have the following format:
package/<foo>: <something>
I.e you forgot the package/ prefix.
On Sat, 26 Sep 2020 12:55:50 +0300
Dagg Stompler <daggs@gmx.com> wrote:
> dvb-apps fails to build with glibc 2.31 with the following error:
> | dvbdate.c: In function set_time:
> | dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration]
> | 312 | if (stime(new_time)) {
> | | ^~~~~
> | | ctime
>
> this patch takes from the first entry in the reference fixes it.
>
> reference:
> 1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
> 2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
Please add a reference to the autobuilder failure, like this:
Fixes:
http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
> diff --git a/package/dvb-apps/0006-fix-glibc-2.31.patch b/package/dvb-apps/0006-fix-glibc-2.31.patch
> new file mode 100644
> index 0000000000..d404212b5e
> --- /dev/null
> +++ b/package/dvb-apps/0006-fix-glibc-2.31.patch
All patches must have a description and Signed-off-by.
Could you fix those details, and send an updated version? Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
2020-09-26 13:39 ` Thomas Petazzoni
@ 2020-09-26 16:06 ` daggs
2020-09-28 19:22 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: daggs @ 2020-09-26 16:06 UTC (permalink / raw)
To: buildroot
Greetings Thomas,
> Sent: Saturday, September 26, 2020 at 4:39 PM
> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> To: "Dagg Stompler" <daggs@gmx.com>
> Cc: buildroot at buildroot.org
> Subject: Re: [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
>
> Hello,
>
> Thanks for the patch. There are however a few coding style issues.
> First, the commit title must always have the following format:
>
> package/<foo>: <something>
>
> I.e you forgot the package/ prefix.
you are correct, I've forgot about this, will fix
>
> On Sat, 26 Sep 2020 12:55:50 +0300
> Dagg Stompler <daggs@gmx.com> wrote:
>
> > dvb-apps fails to build with glibc 2.31 with the following error:
> > | dvbdate.c: In function set_time:
> > | dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration]
> > | 312 | if (stime(new_time)) {
> > | | ^~~~~
> > | | ctime
> >
> > this patch takes from the first entry in the reference fixes it.
> >
> > reference:
> > 1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
> > 2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
>
> Please add a reference to the autobuilder failure, like this:
>
> Fixes:
>
> http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
frankly speaking, I had no idea this issue was marked by the autobuilder, I've encountered it when trying to build an image with dvb-apps installed.
I'll reference the failure in my next revision.
>
> > diff --git a/package/dvb-apps/0006-fix-glibc-2.31.patch b/package/dvb-apps/0006-fix-glibc-2.31.patch
> > new file mode 100644
> > index 0000000000..d404212b5e
> > --- /dev/null
> > +++ b/package/dvb-apps/0006-fix-glibc-2.31.patch
>
> All patches must have a description and Signed-off-by.
>
> Could you fix those details, and send an updated version? Thanks a lot!
>
as mentioned in the commit mail, I took the patch as is from the first reference.
I'll try to find a more detailed commit or will rewrite it.
Thanks,
Dagg.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
2020-09-26 16:06 ` daggs
@ 2020-09-28 19:22 ` Thomas Petazzoni
2020-09-29 12:31 ` daggs
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-09-28 19:22 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 26 Sep 2020 18:06:25 +0200
daggs <daggs@gmx.com> wrote:
> > Fixes:
> >
> > http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
>
> frankly speaking, I had no idea this issue was marked by the
> autobuilder, I've encountered it when trying to build an image with
> dvb-apps installed.
No problem. But when you have a failure, it makes sense to check if we
have encountered it in the autobuilders. You can easily search by doing
this:
http://autobuild.buildroot.org/?reason=dvb-apps%
The % at the end is important, as it acts as a wildcard.
And if the failure was not found by the autobuilders, it is interesting
to investigate why. Is it because the failure is related to a very
specific system configuration? Or an architecture/toolchain combination
we are not testing?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
2020-09-28 19:22 ` Thomas Petazzoni
@ 2020-09-29 12:31 ` daggs
0 siblings, 0 replies; 5+ messages in thread
From: daggs @ 2020-09-29 12:31 UTC (permalink / raw)
To: buildroot
Greetings Thomas,
> Sent: Monday, September 28, 2020 at 10:22 PM
> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> To: "daggs" <daggs@gmx.com>
> Cc: buildroot at buildroot.org
> Subject: Re: [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
>
> Hello,
>
> On Sat, 26 Sep 2020 18:06:25 +0200
> daggs <daggs@gmx.com> wrote:
>
> > > Fixes:
> > >
> > > http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
> >
> > frankly speaking, I had no idea this issue was marked by the
> > autobuilder, I've encountered it when trying to build an image with
> > dvb-apps installed.
>
> No problem. But when you have a failure, it makes sense to check if we
> have encountered it in the autobuilders. You can easily search by doing
> this:
>
> http://autobuild.buildroot.org/?reason=dvb-apps%
>
> The % at the end is important, as it acts as a wildcard.
>
> And if the failure was not found by the autobuilders, it is interesting
> to investigate why. Is it because the failure is related to a very
> specific system configuration? Or an architecture/toolchain combination
> we are not testing?
>
I'll take that under advisement for the future
Dagg
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-29 12:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26 9:55 [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31 Dagg Stompler
2020-09-26 13:39 ` Thomas Petazzoni
2020-09-26 16:06 ` daggs
2020-09-28 19:22 ` Thomas Petazzoni
2020-09-29 12:31 ` daggs
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.