* [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong
@ 2018-06-11 10:01 ` st6589 at public-files.de
0 siblings, 0 replies; 4+ messages in thread
From: st6589 @ 2018-06-11 10:01 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-amlogic
[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]
Hello with the actuel Pinning definition in pinctrl-meson-gxbb.c for the uart_c
the system crashes when activated. The seams to be a depency with mmc driver for SD cards.
according to the comment here: https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
the seams to be an error in the amlogic datasheets regarding uart_c
with the attached patch everything works as it should.
Best regards
##
# https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
#
--- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200
+++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200
@@ -198,8 +198,8 @@
static const unsigned int uart_tx_c_pins[] = { GPIOY_13 };
static const unsigned int uart_rx_c_pins[] = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 };
static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 };
@@ -443,10 +443,10 @@
GROUP(pwm_f_x, 3, 18),
/* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
GROUP(pwm_a_y, 1, 21),
GROUP(pwm_f_y, 1, 20),
GROUP(i2s_out_ch23_y, 1, 5),
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: my-diff-4.17-uac-pin.diff --]
[-- Type: text/x-patch, Size: 1160 bytes --]
##
# https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
#
--- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200
+++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200
@@ -198,8 +198,8 @@
static const unsigned int uart_tx_c_pins[] = { GPIOY_13 };
static const unsigned int uart_rx_c_pins[] = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 };
static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 };
@@ -443,10 +443,10 @@
GROUP(pwm_f_x, 3, 18),
/* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
GROUP(pwm_a_y, 1, 21),
GROUP(pwm_f_y, 1, 20),
GROUP(i2s_out_ch23_y, 1, 5),
^ permalink raw reply [flat|nested] 4+ messages in thread* [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong
@ 2018-06-11 10:01 ` st6589 at public-files.de
0 siblings, 0 replies; 4+ messages in thread
From: st6589 at public-files.de @ 2018-06-11 10:01 UTC (permalink / raw)
To: linus-amlogic
Hello with the actuel Pinning definition in? pinctrl-meson-gxbb.c for the uart_c
the system crashes when activated. The seams to be a depency with mmc driver for SD cards.
?
according to the comment here: https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
the seams to be an error in the amlogic datasheets regarding uart_c
?
with the attached patch everything works as it should.
?
Best regards
?
?
##
# https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
#
--- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200
+++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200
@@ -198,8 +198,8 @@
static const unsigned int uart_tx_c_pins[] = { GPIOY_13 };
static const unsigned int uart_rx_c_pins[] = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 };
static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 };
@@ -443,10 +443,10 @@
GROUP(pwm_f_x, 3, 18),
/* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
GROUP(pwm_a_y, 1, 21),
GROUP(pwm_f_y, 1, 20),
GROUP(i2s_out_ch23_y, 1, 5),
-------------- next part --------------
A non-text attachment was scrubbed...
Name: my-diff-4.17-uac-pin.diff
Type: text/x-patch
Size: 1160 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20180611/1d8bb112/attachment.bin>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong
2018-06-11 10:01 ` st6589 at public-files.de
@ 2018-06-11 11:35 ` Neil Armstrong
-1 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-06-11 11:35 UTC (permalink / raw)
To: st6589, linux-kernel; +Cc: linux-amlogic
Hi, "unknown user",
On 11/06/2018 12:01, st6589@public-files.de wrote:
>
> Hello with the actuel Pinning definition in pinctrl-meson-gxbb.c for the uart_c
> the system crashes when activated. The seams to be a depency with mmc driver for SD cards.
>
> according to the comment here: https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
> the seams to be an error in the amlogic datasheets regarding uart_c
>
> with the attached patch everything works as it should.
Thanks for reporting this ans submitting a fix,
but could you sign with your real name and send patch as inline text only ?
Thanks,
Neil
>
> Best regards
>
>
> ##
> # https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
> #
> --- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200
> +++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200
> @@ -198,8 +198,8 @@
>
> static const unsigned int uart_tx_c_pins[] = { GPIOY_13 };
> static const unsigned int uart_rx_c_pins[] = { GPIOY_14 };
> -static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
> -static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
> +static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
> +static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
>
> static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 };
> static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 };
> @@ -443,10 +443,10 @@
> GROUP(pwm_f_x, 3, 18),
>
> /* Bank Y */
> - GROUP(uart_cts_c, 1, 19),
> - GROUP(uart_rts_c, 1, 18),
> - GROUP(uart_tx_c, 1, 17),
> - GROUP(uart_rx_c, 1, 16),
> + GROUP(uart_cts_c, 1, 17),
> + GROUP(uart_rts_c, 1, 16),
> + GROUP(uart_tx_c, 1, 19),
> + GROUP(uart_rx_c, 1, 18),
> GROUP(pwm_a_y, 1, 21),
> GROUP(pwm_f_y, 1, 20),
> GROUP(i2s_out_ch23_y, 1, 5),
>
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong
@ 2018-06-11 11:35 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-06-11 11:35 UTC (permalink / raw)
To: linus-amlogic
Hi, "unknown user",
On 11/06/2018 12:01, st6589 at public-files.de wrote:
>
> Hello with the actuel Pinning definition in? pinctrl-meson-gxbb.c for the uart_c
> the system crashes when activated. The seams to be a depency with mmc driver for SD cards.
> ?
> according to the comment here: https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
> the seams to be an error in the amlogic datasheets regarding uart_c
> ?
> with the attached patch everything works as it should.
Thanks for reporting this ans submitting a fix,
but could you sign with your real name and send patch as inline text only ?
Thanks,
Neil
> ?
> Best regards
> ?
> ?
> ##
> # https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
> #
> --- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200
> +++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200
> @@ -198,8 +198,8 @@
>
> static const unsigned int uart_tx_c_pins[] = { GPIOY_13 };
> static const unsigned int uart_rx_c_pins[] = { GPIOY_14 };
> -static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
> -static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
> +static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
> +static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
>
> static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 };
> static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 };
> @@ -443,10 +443,10 @@
> GROUP(pwm_f_x, 3, 18),
>
> /* Bank Y */
> - GROUP(uart_cts_c, 1, 19),
> - GROUP(uart_rts_c, 1, 18),
> - GROUP(uart_tx_c, 1, 17),
> - GROUP(uart_rx_c, 1, 16),
> + GROUP(uart_cts_c, 1, 17),
> + GROUP(uart_rts_c, 1, 16),
> + GROUP(uart_tx_c, 1, 19),
> + GROUP(uart_rx_c, 1, 18),
> GROUP(pwm_a_y, 1, 21),
> GROUP(pwm_f_y, 1, 20),
> GROUP(i2s_out_ch23_y, 1, 5),
>
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-11 11:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-11 10:01 [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong st6589
2018-06-11 10:01 ` st6589 at public-files.de
2018-06-11 11:35 ` Neil Armstrong
2018-06-11 11:35 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.