[Buildroot] any comments on my patches?

[Buildroot] any comments on my patches?

[daggs]

Greetings,

I've not received any comments on the following patches:
https://patchwork.ozlabs.org/patch/633705/
https://patchwork.ozlabs.org/patch/633092/
https://patchwork.ozlabs.org/patch/633093/

I did received comments on https://patchwork.ozlabs.org/patch/633704/ which I've answered but didn't got any replay.

are there any more comments? if not, can they be committed to the repo?

Thanks,

Dagg.

[Buildroot] any comments on my patches?

[Yann E. MORIN]

Dagg, All,

On 2016-06-14 07:42 +0200, daggs spake thusly:
> Greetings,
> 
> I've not received any comments on the following patches:
> https://patchwork.ozlabs.org/patch/633705/
> https://patchwork.ozlabs.org/patch/633092/
> https://patchwork.ozlabs.org/patch/633093/
> 
> I did received comments on https://patchwork.ozlabs.org/patch/633704/ which I've answered but didn't got any replay.
> 
> are there any more comments? if not, can they be committed to the repo?

https://patchwork.ozlabs.org/project/buildroot/list/

As you may have seen on Patchwork, we have a *lot* of patches (currently
234) that are not yet applied, the older being from June 2015...

So, we'll eventually come to your patches. Sorry it takes time.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] any comments on my patches?

[daggs]

Greetings,
> Dagg, All,
> 
> On 2016-06-14 07:42 +0200, daggs spake thusly:
> > Greetings,
> > 
> > I've not received any comments on the following patches:
> > https://patchwork.ozlabs.org/patch/633705/
> > https://patchwork.ozlabs.org/patch/633092/
> > https://patchwork.ozlabs.org/patch/633093/
> > 
> > I did received comments on https://patchwork.ozlabs.org/patch/633704/ which I've answered but didn't got any replay.
> > 
> > are there any more comments? if not, can they be committed to the repo?
> 
> https://patchwork.ozlabs.org/project/buildroot/list/
> 
> As you may have seen on Patchwork, we have a *lot* of patches (currently
> 234) that are not yet applied, the older being from June 2015...
> 
> So, we'll eventually come to your patches. Sorry it takes time.
> 
> Regards,
> Yann E. MORIN.
> 
I thought that I'll have more rejects on my patches, I didn't know there were ok enough to be committed.
the situation is understandable.

Dagg.

[Buildroot] any comments on my patches?

[James Knight]

Dagg,

On Wed, Jun 15, 2016 at 2:30 AM, daggs <daggs@gmx.com> wrote:
> I didn't know there were ok enough to be committed.

Also note that a non-response doesn't mean they are ready to be
submitted as well. As mentioned by Yann, the process can take some
time (even longer for newer, complex or "rare" package additions). One
way to keep the process moving smooth is to remember to mark your
superseded patches as... superseded. Looking at your submitted patches
[1], I believe I see four (4) patches that can be marked as superseded
(if you weren't aware or just forgot to adjust after submitting your
v4 series).

That being said, I might have some additional comments for your active
patches; I'll reply on them individually. Hopefully, it will bring you
one step closer to getting your changes in.

Relevant patch submission reference - "Don't get discouraged - or
impatient." [2]

[1]: https://patchwork.ozlabs.org/project/buildroot/list/?submitter=69054
[2]: https://www.kernel.org/doc/Documentation/SubmittingPatches

[Buildroot] any comments on my patches?

[James Knight]

Dagg,

On Fri, Jun 24, 2016 at 11:41 PM, James Knight <james.d.knight@live.com> wrote:
> (if you weren't aware or just forgot to adjust after submitting your
> v4 series).

Oops; I meant to indicate v3.

---

Also, I would advise that you do not mix your odroid patches along
with your libamcodec/kodi patches (for your v3 series). Keeping them
as separate patch series might make it easier to get some patches in
before others (instead of blocking your entire patch series).

[Buildroot] any comments on my patches?

[daggs]

Greetings,
> On Wed, Jun 15, 2016 at 2:30 AM, daggs <daggs@gmx.com> wrote:
> > I didn't know there were ok enough to be committed.
> 
> Also note that a non-response doesn't mean they are ready to be
> submitted as well. As mentioned by Yann, the process can take some
> time (even longer for newer, complex or "rare" package additions). One
> way to keep the process moving smooth is to remember to mark your
> superseded patches as... superseded. Looking at your submitted patches
> [1], I believe I see four (4) patches that can be marked as superseded
> (if you weren't aware or just forgot to adjust after submitting your
> v4 series).
> 
will look into it, I didn't know I had the ability to do so.

> That being said, I might have some additional comments for your active
> patches; I'll reply on them individually. Hopefully, it will bring you
> one step closer to getting your changes in.
> 
thanks for the feedback.

> Relevant patch submission reference - "Don't get discouraged - or
> impatient." [2]
> 
as I do understand this might take time, I do saw an instance were a other odroid board got replay on patches 6 months later.
waiting 6 months for an replay is rather discouraging...

> [1]: https://patchwork.ozlabs.org/project/buildroot/list/?submitter=69054
> [2]: https://www.kernel.org/doc/Documentation/SubmittingPatches
> 

Dagg.