All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] linux: fix fbtft kernel extension
@ 2015-01-11 13:18 Peter Seiderer
  2015-01-11 18:48 ` Thomas Petazzoni
  2015-04-09 21:26 ` Thomas Petazzoni
  0 siblings, 2 replies; 5+ messages in thread
From: Peter Seiderer @ 2015-01-11 13:18 UTC (permalink / raw)
  To: buildroot

Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):

drivers/video/Kconfig:2525: can't open file
"drivers/video/fbdev/fbtft/Kconfig"

Fix: write the right fbtft/KConfig path to video/Kconfig or
video/fbdev/Kconfig (instead of hard coded one)

[1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html

Reported-by: Richard Fergusson <fergie4000@gmail.com>
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 linux/linux-ext-fbtft.mk | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/linux/linux-ext-fbtft.mk b/linux/linux-ext-fbtft.mk
index 36f4fd2..71ebdf3 100644
--- a/linux/linux-ext-fbtft.mk
+++ b/linux/linux-ext-fbtft.mk
@@ -12,15 +12,15 @@ LINUX_DEPENDENCIES += fbtft
 # for linux < 3.15 install to drivers/video/fbtft
 define FBTFT_PREPARE_KERNEL
 	if [ -e $(LINUX_DIR)/drivers/video/fbdev ]; then \
-		dest=$(LINUX_DIR)/drivers/video/fbdev ; \
+		dest=drivers/video/fbdev ; \
 	else \
-		dest=$(LINUX_DIR)/drivers/video/ ; \
+		dest=drivers/video ; \
 	fi ; \
-	mkdir -p $${dest}/fbtft; \
-	cp -dpfr $(FBTFT_DIR)/* $${dest}/fbtft/ ; \
-	echo 'source "drivers/video/fbdev/fbtft/Kconfig"' \
-		>> $${dest}/Kconfig ; \
-	echo 'obj-y += fbtft/' >> $${dest}/Makefile
+	mkdir -p $(LINUX_DIR)/$${dest}/fbtft; \
+	cp -dpfr $(FBTFT_DIR)/* $(LINUX_DIR)/$${dest}/fbtft/ ; \
+	echo "source \"$${dest}/fbtft/Kconfig\"" \
+		>> $(LINUX_DIR)/$${dest}/Kconfig ; \
+	echo 'obj-y += fbtft/' >> $(LINUX_DIR)/$${dest}/Makefile
 endef
 
 LINUX_PRE_PATCH_HOOKS += FBTFT_PREPARE_KERNEL
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] linux: fix fbtft kernel extension
  2015-01-11 13:18 [Buildroot] [PATCH] linux: fix fbtft kernel extension Peter Seiderer
@ 2015-01-11 18:48 ` Thomas Petazzoni
  2015-01-11 22:27   ` Peter Seiderer
  2015-04-09 21:26 ` Thomas Petazzoni
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2015-01-11 18:48 UTC (permalink / raw)
  To: buildroot

Dear Peter Seiderer,

On Sun, 11 Jan 2015 14:18:55 +0100, Peter Seiderer wrote:
> Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):
> 
> drivers/video/Kconfig:2525: can't open file
> "drivers/video/fbdev/fbtft/Kconfig"
> 
> Fix: write the right fbtft/KConfig path to video/Kconfig or
> video/fbdev/Kconfig (instead of hard coded one)
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html
> 
> Reported-by: Richard Fergusson <fergie4000@gmail.com>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

I only had a quick look, but I don't really see the relationship
between the bug report and this fix. Could you elaborate a bit?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] linux: fix fbtft kernel extension
  2015-01-11 18:48 ` Thomas Petazzoni
@ 2015-01-11 22:27   ` Peter Seiderer
  0 siblings, 0 replies; 5+ messages in thread
From: Peter Seiderer @ 2015-01-11 22:27 UTC (permalink / raw)
  To: buildroot

Hello Thomas,

> Gesendet: Sonntag, 11. Januar 2015 um 19:48 Uhr
> Von: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
> An: "Peter Seiderer" <ps.report@gmx.net>
> Cc: buildroot at busybox.net, "Richard Fergusson" <fergie4000@gmail.com>
> Betreff: Re: [PATCH] linux: fix fbtft kernel extension
>
> Dear Peter Seiderer,
> 
> On Sun, 11 Jan 2015 14:18:55 +0100, Peter Seiderer wrote:
> > Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):
> > 
> > drivers/video/Kconfig:2525: can't open file
> > "drivers/video/fbdev/fbtft/Kconfig"
> > 
> > Fix: write the right fbtft/KConfig path to video/Kconfig or
> > video/fbdev/Kconfig (instead of hard coded one)
> > 
> > [1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html
> > 
> > Reported-by: Richard Fergusson <fergie4000@gmail.com>
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> 
> I only had a quick look, but I don't really see the relationship
> between the bug report and this fix. Could you elaborate a bit?
> 

Without this patch (and raspberrypi_defconfig and BR2_LINUX_KERNEL_EXT_FBTFT=y)
a wrong path is added to drivers/video/Kconfig

$ tail -2 build/linux-c256eb9968c8997dce47350d2075e42f1b3991d3/drivers/video/Kconfig 
endmenu
source "drivers/video/fbdev/fbtft/Kconfig"

$ ls build/linux-c256eb9968c8997dce47350d2075e42f1b3991d3/drivers/video/fbtft/Kconfig 
build/linux-c256eb9968c8997dce47350d2075e42f1b3991d3/drivers/video/fbtft/Kconfig

The patch changes the wrong addition 'source "drivers/video/fbdev/fbtft/Kconfig"' to
the right 'source "drivers/video/fbtft/Kconfig"' in case linux < 3.15...

Hope this explenation is better?

Regards,
Peter

> Thanks,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] linux: fix fbtft kernel extension
  2015-01-11 13:18 [Buildroot] [PATCH] linux: fix fbtft kernel extension Peter Seiderer
  2015-01-11 18:48 ` Thomas Petazzoni
@ 2015-04-09 21:26 ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-04-09 21:26 UTC (permalink / raw)
  To: buildroot

Dear Peter Seiderer,

On Sun, 11 Jan 2015 14:18:55 +0100, Peter Seiderer wrote:
> Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):
> 
> drivers/video/Kconfig:2525: can't open file
> "drivers/video/fbdev/fbtft/Kconfig"
> 
> Fix: write the right fbtft/KConfig path to video/Kconfig or
> video/fbdev/Kconfig (instead of hard coded one)
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html
> 
> Reported-by: Richard Fergusson <fergie4000@gmail.com>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] linux: fix fbtft kernel extension
@ 2015-01-11 20:50 Richard Fergusson
  0 siblings, 0 replies; 5+ messages in thread
From: Richard Fergusson @ 2015-01-11 20:50 UTC (permalink / raw)
  To: buildroot

The old version of the file assumes the location of the fbtft Kconfig
to be drivers/video/fbdev/fbtft/Kconfig regardless of what is actually
determined in the check earlier in the file. The new version correctly
uses the value of $${dest} to build the correct location.

- Richard

On 12 January 2015 at 05:18, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> Dear Peter Seiderer,
>
> On Sun, 11 Jan 2015 14:18:55 +0100, Peter Seiderer wrote:
> > Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):
> >
> > drivers/video/Kconfig:2525: can't open file
> > "drivers/video/fbdev/fbtft/Kconfig"
> >
> > Fix: write the right fbtft/KConfig path to video/Kconfig or
> > video/fbdev/Kconfig (instead of hard coded one)
> >
> > [1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html
> >
> > Reported-by: Richard Fergusson <fergie4000@gmail.com>
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> I only had a quick look, but I don't really see the relationship
> between the bug report and this fix. Could you elaborate a bit?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-04-09 21:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-11 13:18 [Buildroot] [PATCH] linux: fix fbtft kernel extension Peter Seiderer
2015-01-11 18:48 ` Thomas Petazzoni
2015-01-11 22:27   ` Peter Seiderer
2015-04-09 21:26 ` Thomas Petazzoni
2015-01-11 20:50 Richard Fergusson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.