* [PATCH 36/36] net: irda: sh_sir: remove unnecessary platform_set_drvdata()
@ 2013-05-07 5:07 Jingoo Han
2013-05-07 5:39 ` Kuninori Morimoto
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 5:07 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, Jingoo Han, Samuel Ortiz, Wei Yongjun, Kuninori Morimoto
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/irda/sh_sir.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 24aefcd..89682b4 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -796,7 +796,6 @@ static int sh_sir_remove(struct platform_device *pdev)
sh_sir_remove_iobuf(self);
iounmap(self->membase);
free_netdev(ndev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 36/36] net: irda: sh_sir: remove unnecessary platform_set_drvdata()
2013-05-07 5:07 [PATCH 36/36] net: irda: sh_sir: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 5:39 ` Kuninori Morimoto
0 siblings, 0 replies; 2+ messages in thread
From: Kuninori Morimoto @ 2013-05-07 5:39 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'David S. Miller', netdev, Samuel Ortiz, Wei Yongjun
Hi
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Best regards
--
Kuninori Morimoto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 5:07 [PATCH 36/36] net: irda: sh_sir: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 5:39 ` Kuninori Morimoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.