From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org, "Sebastian Pipping" <webmaster@hartwork.org>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH 1.8.0] add: make "add -u" update full tree without pathspec
Date: Mon, 07 Feb 2011 13:09:19 +0100 [thread overview]
Message-ID: <vpq1v3kf3m8.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vsjw0v11p.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun\, 06 Feb 2011 21\:58\:10 -0800")
[ Your mailer did something strange with my name and email ]
Junio C Hamano <gitster@pobox.com> writes:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> When -u was introduced in dfdac5d (git-add -u: match the index with
>> working tree., 2007-04-20), "add -u" (without pathspec) added
>> everything. Shortly after, 2ed2c22 (git-add -u paths... now works from
>> subdirectory, 2007-08-16) broke it while fixing something related.
>
> As long as the command takes pathspecs, it should never be tree-wide.
> Making it tree-wide when there is no pathspec is even worse.
This is against the common use in Git. As I mentionned in the other
thread, pretty much any git command taking an optional pathspec is
still tree-wide when called without argument. "git add -u" is the
exception.
> If "add -p" does not limit operation to the current directory, probably
> that is the inconsistency bug to be fixed.
Add "git log", "git status", "git commit", "git show", "git diff", and
a few others I've missed to the list of "exceptions" ...
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2011-02-07 12:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 2:27 [PATCH 1.8.0] add: make "add -u" update full tree without pathspec Nguyễn Thái Ngọc Duy
2011-02-07 5:58 ` Junio C Hamano
2011-02-07 6:14 ` Nguyen Thai Ngoc Duy
2011-02-07 6:26 ` Miles Bader
2011-02-09 10:58 ` Joshua Juran
2011-02-07 12:09 ` Matthieu Moy [this message]
2011-02-27 10:46 ` Junio C Hamano
2011-02-27 11:43 ` Matthieu Moy
2011-02-27 17:04 ` Nguyen Thai Ngoc Duy
2011-02-27 13:35 ` Sverre Rabbelier
2011-02-27 17:01 ` Nguyen Thai Ngoc Duy
2011-02-27 16:52 ` Nguyen Thai Ngoc Duy
2011-02-27 19:39 ` Junio C Hamano
2011-02-28 6:37 ` Nguyen Thai Ngoc Duy
2011-02-28 6:56 ` Junio C Hamano
2011-03-01 11:22 ` Nguyen Thai Ngoc Duy
2011-03-01 13:46 ` Junio C Hamano
2011-03-01 14:15 ` Nguyen Thai Ngoc Duy
2011-03-01 14:53 ` Matthieu Moy
2011-03-01 18:40 ` Junio C Hamano
2011-03-01 18:51 ` Matthieu Moy
2011-03-01 19:36 ` Jakub Narebski
2011-03-01 20:00 ` Jeff King
2011-03-01 20:12 ` Junio C Hamano
2011-03-01 20:25 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq1v3kf3m8.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=szeder@ira.uka.de \
--cc=webmaster@hartwork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.