From: Alberto Garcia <berto@igalia.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
vsementsov@virtuozzo.com,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>,
"Laszlo Ersek" <lersek@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Greg Kurz" <groug@kaod.org>,
armbru@redhat.com, "Stefano Stabellini" <sstabellini@kernel.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org, "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [PATCH v8 01/10] error: auto propagated local_err
Date: Fri, 06 Mar 2020 12:02:22 +0100 [thread overview]
Message-ID: <w51mu8tsq4h.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20200306051536.27803-2-vsementsov@virtuozzo.com>
On Fri 06 Mar 2020 06:15:27 AM CET, Vladimir Sementsov-Ogievskiy wrote:
Sorry I just gave a quick look at these patches and noticed this:
> + * Function may use error system to return errors. In this case function
> + * defines Error **errp parameter, which should be the last one (except for
> + * functions which varidic argument list), which has the following API:
I don't think that "functions which varidic argument list" is correct
English. Perhaps something like "except for variadic functions" or
"except for functions with a variable number of arguments".
Berto
WARNING: multiple messages have this Message-ID (diff)
From: Alberto Garcia <berto@igalia.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
vsementsov@virtuozzo.com,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>,
"Laszlo Ersek" <lersek@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Greg Kurz" <groug@kaod.org>,
armbru@redhat.com, "Stefano Stabellini" <sstabellini@kernel.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org, "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [Xen-devel] [PATCH v8 01/10] error: auto propagated local_err
Date: Fri, 06 Mar 2020 12:02:22 +0100 [thread overview]
Message-ID: <w51mu8tsq4h.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20200306051536.27803-2-vsementsov@virtuozzo.com>
On Fri 06 Mar 2020 06:15:27 AM CET, Vladimir Sementsov-Ogievskiy wrote:
Sorry I just gave a quick look at these patches and noticed this:
> + * Function may use error system to return errors. In this case function
> + * defines Error **errp parameter, which should be the last one (except for
> + * functions which varidic argument list), which has the following API:
I don't think that "functions which varidic argument list" is correct
English. Perhaps something like "except for variadic functions" or
"except for functions with a variable number of arguments".
Berto
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-06 11:03 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 5:15 [PATCH v8 00/10] error: auto propagated local_err part I Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 01/10] error: auto propagated local_err Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-06 8:55 ` Paul Durrant
2020-03-06 8:55 ` [Xen-devel] " Paul Durrant
2020-03-06 10:28 ` Greg Kurz
2020-03-06 10:28 ` [Xen-devel] " Greg Kurz
2020-03-06 11:02 ` Alberto Garcia [this message]
2020-03-06 11:02 ` Alberto Garcia
2020-03-06 12:37 ` Eric Blake
2020-03-06 12:37 ` [Xen-devel] " Eric Blake
2020-03-06 13:00 ` Vladimir Sementsov-Ogievskiy
2020-03-06 13:00 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-06 12:43 ` Eric Blake
2020-03-06 12:43 ` [Xen-devel] " Eric Blake
2020-03-08 19:09 ` Christian Schoenebeck
2020-03-08 19:09 ` [Xen-devel] " Christian Schoenebeck
2020-03-10 6:47 ` Vladimir Sementsov-Ogievskiy
2020-03-10 6:47 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-09 9:56 ` Markus Armbruster
2020-03-09 9:56 ` [Xen-devel] " Markus Armbruster
2020-03-10 7:44 ` Vladimir Sementsov-Ogievskiy
2020-03-10 7:44 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-10 15:47 ` Markus Armbruster
2020-03-10 15:47 ` [Xen-devel] " Markus Armbruster
2020-03-11 6:55 ` Vladimir Sementsov-Ogievskiy
2020-03-11 6:55 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 8:32 ` Vladimir Sementsov-Ogievskiy
2020-03-11 8:32 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 9:04 ` Markus Armbruster
2020-03-11 9:04 ` [Xen-devel] " Markus Armbruster
2020-03-11 9:16 ` Vladimir Sementsov-Ogievskiy
2020-03-11 9:16 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 8:29 ` Vladimir Sementsov-Ogievskiy
2020-03-11 8:29 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 9:38 ` Markus Armbruster
2020-03-11 9:38 ` [Xen-devel] " Markus Armbruster
2020-03-11 14:05 ` Vladimir Sementsov-Ogievskiy
2020-03-11 14:05 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 14:41 ` Markus Armbruster
2020-03-11 14:41 ` [Xen-devel] " Markus Armbruster
2020-03-11 14:46 ` Vladimir Sementsov-Ogievskiy
2020-03-11 14:46 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-12 7:23 ` Markus Armbruster
2020-03-12 7:23 ` [Xen-devel] " Markus Armbruster
2020-03-12 7:42 ` Vladimir Sementsov-Ogievskiy
2020-03-12 7:42 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 8:35 ` Vladimir Sementsov-Ogievskiy
2020-03-11 8:35 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 9:33 ` Markus Armbruster
2020-03-11 9:33 ` [Xen-devel] " Markus Armbruster
2020-03-11 9:49 ` Vladimir Sementsov-Ogievskiy
2020-03-11 9:49 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-11 9:53 ` Markus Armbruster
2020-03-11 9:53 ` [Xen-devel] " Markus Armbruster
2020-03-11 10:11 ` Vladimir Sementsov-Ogievskiy
2020-03-11 10:11 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 03/10] hw/sd/ssi-sd: fix error handling in ssi_sd_realize Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 04/10] SD (Secure Card): introduce ERRP_AUTO_PROPAGATE Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 05/10] pflash: " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 06/10] fw_cfg: " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 07/10] virtio-9p: " Vladimir Sementsov-Ogievskiy
2020-03-08 18:55 ` Christian Schoenebeck
2020-03-06 5:15 ` [PATCH v8 08/10] TPM: " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 09/10] nbd: " Vladimir Sementsov-Ogievskiy
2020-03-06 12:45 ` Eric Blake
2020-03-06 5:15 ` [PATCH v8 10/10] xen: " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-06 9:12 ` Paul Durrant
2020-03-06 9:12 ` [Xen-devel] " Paul Durrant
2020-03-06 9:18 ` Vladimir Sementsov-Ogievskiy
2020-03-06 9:18 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
2020-03-06 15:21 ` [PATCH v8 00/10] error: auto propagated local_err part I Markus Armbruster
2020-03-06 15:21 ` [Xen-devel] " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51mu8tsq4h.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=groug@kaod.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=paul@xen.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.