All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition
@ 2020-09-21 11:01 Philippe Mathieu-Daudé
  2020-09-21 11:06 ` Alberto Garcia
  2020-09-23 15:18 ` Kevin Wolf
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-21 11:01 UTC (permalink / raw)
  To: qemu-devel
  Cc: Kevin Wolf, sheepdog, qemu-block, qemu-trivial, Max Reitz,
	Liu Yuan, Philippe Mathieu-Daudé

Use self-explicit NANOSECONDS_PER_SECOND definition instead
of magic value.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 block/sheepdog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/sheepdog.c b/block/sheepdog.c
index cbbebc1aaf2..cbc655a1a05 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -740,7 +740,7 @@ static coroutine_fn void reconnect_to_sdog(void *opaque)
         if (s->fd < 0) {
             trace_sheepdog_reconnect_to_sdog();
             error_report_err(local_err);
-            qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, 1000000000ULL);
+            qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, NANOSECONDS_PER_SECOND);
         }
     };
 
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition
  2020-09-21 11:01 [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition Philippe Mathieu-Daudé
@ 2020-09-21 11:06 ` Alberto Garcia
  2020-09-23 15:18 ` Kevin Wolf
  1 sibling, 0 replies; 3+ messages in thread
From: Alberto Garcia @ 2020-09-21 11:06 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Kevin Wolf, sheepdog, qemu-block, qemu-trivial, Max Reitz,
	Liu Yuan, Philippe Mathieu-Daudé

On Mon 21 Sep 2020 01:01:45 PM CEST, Philippe Mathieu-Daudé wrote:
> Use self-explicit NANOSECONDS_PER_SECOND definition instead
> of magic value.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition
  2020-09-21 11:01 [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition Philippe Mathieu-Daudé
  2020-09-21 11:06 ` Alberto Garcia
@ 2020-09-23 15:18 ` Kevin Wolf
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2020-09-23 15:18 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: sheepdog, qemu-block, qemu-trivial, qemu-devel, Max Reitz, Liu Yuan

Am 21.09.2020 um 13:01 hat Philippe Mathieu-Daudé geschrieben:
> Use self-explicit NANOSECONDS_PER_SECOND definition instead
> of magic value.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks, applied to the block branch.

Kevin



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-23 15:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 11:01 [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition Philippe Mathieu-Daudé
2020-09-21 11:06 ` Alberto Garcia
2020-09-23 15:18 ` Kevin Wolf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.