All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Consistent use of IEC 80000-13 prefix in manpage
@ 2016-03-30 19:48 Marko Hauptvogel
  2016-03-31 19:09 ` Jes Sorensen
  0 siblings, 1 reply; 5+ messages in thread
From: Marko Hauptvogel @ 2016-03-30 19:48 UTC (permalink / raw)
  To: linux-raid

From: Marko Hauptvogel <marko.hauptvogel@googlemail.com>

Added the optional K suffix for completeness, as it
is allowed by util.c's parse_size(char*).

Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
---
 mdadm.8.in | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/mdadm.8.in b/mdadm.8.in
index 50be1aa..80b0826 100644
--- a/mdadm.8.in
+++ b/mdadm.8.in
@@ -467,8 +467,8 @@ If this is not specified
 size, though if there is a variance among the drives of greater than
1%, a warning is
 issued.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
-Gigabytes respectively.
+A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
Mebibytes or
+Gibibytes respectively.

 Sometimes a replacement drive can be a little smaller than the
 original drives though this should be minimised by IDEMA standards.
@@ -534,8 +534,8 @@ problems the array can be made bigger again with no
loss with another
 .B "\-\-grow \-\-array\-size="
 command.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
-Gigabytes respectively.
+A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
Mebibytes or
+Gibibytes respectively.
 A value of
 .B max
 restores the apparent size of the array to be whatever the real
@@ -551,8 +551,8 @@ This is only meaningful for RAID0, RAID4, RAID5,
RAID6, and RAID10.
 RAID4, RAID5, RAID6, and RAID10 require the chunk size to be a power
 of 2.  In any case it must be a multiple of 4KB.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
-Gigabytes respectively.
+A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
Mebibytes or
+Gibibytes respectively.

 .TP
 .BR \-\-rounding=
@@ -729,7 +729,7 @@ beneficial.  This can be suppressed with
 .TP
 .BR \-\-bitmap\-chunk=
 Set the chunksize of the bitmap.  Each bit corresponds to that many
-Kilobytes of storage.
+Kibibytes of storage.
 When using a file based bitmap, the default is to use the smallest
 size that is at-least 4 and requires no more than 2^21 chunks.
 When using an
@@ -737,8 +737,8 @@ When using an
 bitmap, the chunksize defaults to 64Meg, or larger if necessary to
 fit the bitmap into the available space.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
-Gigabytes respectively.
+A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
Mebibytes or
+Gibibytes respectively.

 .TP
 .BR \-W ", " \-\-write\-mostly
@@ -808,7 +808,8 @@ an array which was originally created using a
different version of
 which computed a different offset.

 Setting the offset explicitly over-rides the default.  The value given
-is in Kilobytes unless an 'M' or 'G' suffix is given.
+is in Kibibytes unless a suffix of 'K', 'M' or 'G' is given to indicate
+Kibibytes, Mebibytes or Gibibytes respectively.

 Since Linux 3.4,
 .B \-\-data\-offset
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] Consistent use of IEC 80000-13 prefix in manpage
  2016-03-30 19:48 [PATCH] Consistent use of IEC 80000-13 prefix in manpage Marko Hauptvogel
@ 2016-03-31 19:09 ` Jes Sorensen
  2016-03-31 22:21   ` [PATCH v2] Consistent use of metric " Marko Hauptvogel
  2016-04-03 19:19   ` [PATCH] Consistent use of IEC 80000-13 " Anthonys Lists
  0 siblings, 2 replies; 5+ messages in thread
From: Jes Sorensen @ 2016-03-31 19:09 UTC (permalink / raw)
  To: Marko Hauptvogel; +Cc: linux-raid

Marko Hauptvogel <marko.hauptvogel@googlemail.com> writes:
> From: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
>
> Added the optional K suffix for completeness, as it
> is allowed by util.c's parse_size(char*).
>
> Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>

I am not very much in favor of this patch. Any normal sane person still
refers to megabytes and kilobytes as referring to 1024 base sizes,
despite the pointless standard trying to mess them up to accommodate the
harddrive vendors. Nobody normal knows what a kibibyte is.

Jes

> ---
>  mdadm.8.in | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/mdadm.8.in b/mdadm.8.in
> index 50be1aa..80b0826 100644
> --- a/mdadm.8.in
> +++ b/mdadm.8.in
> @@ -467,8 +467,8 @@ If this is not specified
>  size, though if there is a variance among the drives of greater than
> 1%, a warning is
>  issued.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> -Gigabytes respectively.
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
> Mebibytes or
> +Gibibytes respectively.
>
>  Sometimes a replacement drive can be a little smaller than the
>  original drives though this should be minimised by IDEMA standards.
> @@ -534,8 +534,8 @@ problems the array can be made bigger again with no
> loss with another
>  .B "\-\-grow \-\-array\-size="
>  command.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> -Gigabytes respectively.
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
> Mebibytes or
> +Gibibytes respectively.
>  A value of
>  .B max
>  restores the apparent size of the array to be whatever the real
> @@ -551,8 +551,8 @@ This is only meaningful for RAID0, RAID4, RAID5,
> RAID6, and RAID10.
>  RAID4, RAID5, RAID6, and RAID10 require the chunk size to be a power
>  of 2.  In any case it must be a multiple of 4KB.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> -Gigabytes respectively.
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
> Mebibytes or
> +Gibibytes respectively.
>
>  .TP
>  .BR \-\-rounding=
> @@ -729,7 +729,7 @@ beneficial.  This can be suppressed with
>  .TP
>  .BR \-\-bitmap\-chunk=
>  Set the chunksize of the bitmap.  Each bit corresponds to that many
> -Kilobytes of storage.
> +Kibibytes of storage.
>  When using a file based bitmap, the default is to use the smallest
>  size that is at-least 4 and requires no more than 2^21 chunks.
>  When using an
> @@ -737,8 +737,8 @@ When using an
>  bitmap, the chunksize defaults to 64Meg, or larger if necessary to
>  fit the bitmap into the available space.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> -Gigabytes respectively.
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kibibytes,
> Mebibytes or
> +Gibibytes respectively.
>
>  .TP
>  .BR \-W ", " \-\-write\-mostly
> @@ -808,7 +808,8 @@ an array which was originally created using a
> different version of
>  which computed a different offset.
>
>  Setting the offset explicitly over-rides the default.  The value given
> -is in Kilobytes unless an 'M' or 'G' suffix is given.
> +is in Kibibytes unless a suffix of 'K', 'M' or 'G' is given to indicate
> +Kibibytes, Mebibytes or Gibibytes respectively.
>
>  Since Linux 3.4,
>  .B \-\-data\-offset

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] Consistent use of metric prefix in manpage
  2016-03-31 19:09 ` Jes Sorensen
@ 2016-03-31 22:21   ` Marko Hauptvogel
  2016-04-01 20:11     ` Jes Sorensen
  2016-04-03 19:19   ` [PATCH] Consistent use of IEC 80000-13 " Anthonys Lists
  1 sibling, 1 reply; 5+ messages in thread
From: Marko Hauptvogel @ 2016-03-31 22:21 UTC (permalink / raw)
  To: Jes Sorensen; +Cc: linux-raid

On 31.03.2016 21:09, Jes Sorensen wrote:
> Marko Hauptvogel <marko.hauptvogel@googlemail.com> writes:
>> > From: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
>> >
>> > Added the optional K suffix for completeness, as it
>> > is allowed by util.c's parse_size(char*).
>> >
>> > Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
> I am not very much in favor of this patch. Any normal sane person still
> refers to megabytes and kilobytes as referring to 1024 base sizes,
> despite the pointless standard trying to mess them up to accommodate the
> harddrive vendors. Nobody normal knows what a kibibyte is.
> 
> Jes
> 

I am fine either way, but it should be used consistently throughout the man page. The mix up was what made me cringe.

Greetings

--------

From eaad00be960ff1d60861cba75cc7e5eb07f7e330 Mon Sep 17 00:00:00 2001
From: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
Date: Fri, 1 Apr 2016 00:13:44 +0200
Subject: [PATCH] Consistent use of metric prefix in manpage

Added the optional K suffix for completeness, as it
is allowed by util.c's parse_size(char*).

Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
---
 mdadm.8.in | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/mdadm.8.in b/mdadm.8.in
index 50be1aa..1a04bd1 100644
--- a/mdadm.8.in
+++ b/mdadm.8.in
@@ -459,7 +459,7 @@ number of spare devices.

 .TP
 .BR \-z ", " \-\-size=
-Amount (in Kibibytes) of space to use from each drive in RAID levels 1/4/5/6.
+Amount (in Kilobytes) of space to use from each drive in RAID levels 1/4/5/6.
 This must be a multiple of the chunk size, and must leave about 128Kb
 of space at the end of the drive for the RAID superblock.
 If this is not specified
@@ -467,7 +467,7 @@ If this is not specified
 size, though if there is a variance among the drives of greater than 1%, a warning is
 issued.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
+A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
 Gigabytes respectively.

 Sometimes a replacement drive can be a little smaller than the
@@ -534,7 +534,7 @@ problems the array can be made bigger again with no loss with another
 .B "\-\-grow \-\-array\-size="
 command.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
+A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
 Gigabytes respectively.
 A value of
 .B max
@@ -543,7 +543,7 @@ amount of available space is.

 .TP
 .BR \-c ", " \-\-chunk=
-Specify chunk size of kibibytes.  The default when creating an
+Specify chunk size of kilobytes.  The default when creating an
 array is 512KB.  To ensure compatibility with earlier versions, the
 default when building an array with no persistent metadata is 64KB.
 This is only meaningful for RAID0, RAID4, RAID5, RAID6, and RAID10.
@@ -551,7 +551,7 @@ This is only meaningful for RAID0, RAID4, RAID5, RAID6, and RAID10.
 RAID4, RAID5, RAID6, and RAID10 require the chunk size to be a power
 of 2.  In any case it must be a multiple of 4KB.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
+A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
 Gigabytes respectively.

 .TP
@@ -737,7 +737,7 @@ When using an
 bitmap, the chunksize defaults to 64Meg, or larger if necessary to
 fit the bitmap into the available space.

-A suffix of 'M' or 'G' can be given to indicate Megabytes or
+A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
 Gigabytes respectively.

 .TP
@@ -808,7 +808,8 @@ an array which was originally created using a different version of
 which computed a different offset.

 Setting the offset explicitly over-rides the default.  The value given
-is in Kilobytes unless an 'M' or 'G' suffix is given.
+is in Kilobytes unless a suffix of 'K', 'M' or 'G' is used to explicitly
+indicate Kilobytes, Megabytes or Gigabytes respectively.

 Since Linux 3.4,
 .B \-\-data\-offset
-- 
2.8.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] Consistent use of metric prefix in manpage
  2016-03-31 22:21   ` [PATCH v2] Consistent use of metric " Marko Hauptvogel
@ 2016-04-01 20:11     ` Jes Sorensen
  0 siblings, 0 replies; 5+ messages in thread
From: Jes Sorensen @ 2016-04-01 20:11 UTC (permalink / raw)
  To: Marko Hauptvogel; +Cc: linux-raid

Marko Hauptvogel <marko.hauptvogel@googlemail.com> writes:
> On 31.03.2016 21:09, Jes Sorensen wrote:
>> Marko Hauptvogel <marko.hauptvogel@googlemail.com> writes:
>>> > From: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
>>> >
>>> > Added the optional K suffix for completeness, as it
>>> > is allowed by util.c's parse_size(char*).
>>> >
>>> > Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
>> I am not very much in favor of this patch. Any normal sane person still
>> refers to megabytes and kilobytes as referring to 1024 base sizes,
>> despite the pointless standard trying to mess them up to accommodate the
>> harddrive vendors. Nobody normal knows what a kibibyte is.
>> 
>> Jes
>> 
>
> I am fine either way, but it should be used consistently throughout
> the man page. The mix up was what made me cringe.

Works for me!

Cheers,
Jes

>
> Greetings
>
> --------
>
> From eaad00be960ff1d60861cba75cc7e5eb07f7e330 Mon Sep 17 00:00:00 2001
> From: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
> Date: Fri, 1 Apr 2016 00:13:44 +0200
> Subject: [PATCH] Consistent use of metric prefix in manpage
>
> Added the optional K suffix for completeness, as it
> is allowed by util.c's parse_size(char*).
>
> Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
> ---
>  mdadm.8.in | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/mdadm.8.in b/mdadm.8.in
> index 50be1aa..1a04bd1 100644
> --- a/mdadm.8.in
> +++ b/mdadm.8.in
> @@ -459,7 +459,7 @@ number of spare devices.
>
>  .TP
>  .BR \-z ", " \-\-size=
> -Amount (in Kibibytes) of space to use from each drive in RAID levels 1/4/5/6.
> +Amount (in Kilobytes) of space to use from each drive in RAID levels 1/4/5/6.
>  This must be a multiple of the chunk size, and must leave about 128Kb
>  of space at the end of the drive for the RAID superblock.
>  If this is not specified
> @@ -467,7 +467,7 @@ If this is not specified
>  size, though if there is a variance among the drives of greater than
> 1%, a warning is
>  issued.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
>  Gigabytes respectively.
>
>  Sometimes a replacement drive can be a little smaller than the
> @@ -534,7 +534,7 @@ problems the array can be made bigger again with
> no loss with another
>  .B "\-\-grow \-\-array\-size="
>  command.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
>  Gigabytes respectively.
>  A value of
>  .B max
> @@ -543,7 +543,7 @@ amount of available space is.
>
>  .TP
>  .BR \-c ", " \-\-chunk=
> -Specify chunk size of kibibytes.  The default when creating an
> +Specify chunk size of kilobytes.  The default when creating an
>  array is 512KB.  To ensure compatibility with earlier versions, the
>  default when building an array with no persistent metadata is 64KB.
>  This is only meaningful for RAID0, RAID4, RAID5, RAID6, and RAID10.
> @@ -551,7 +551,7 @@ This is only meaningful for RAID0, RAID4, RAID5,
> RAID6, and RAID10.
>  RAID4, RAID5, RAID6, and RAID10 require the chunk size to be a power
>  of 2.  In any case it must be a multiple of 4KB.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
>  Gigabytes respectively.
>
>  .TP
> @@ -737,7 +737,7 @@ When using an
>  bitmap, the chunksize defaults to 64Meg, or larger if necessary to
>  fit the bitmap into the available space.
>
> -A suffix of 'M' or 'G' can be given to indicate Megabytes or
> +A suffix of 'K', 'M' or 'G' can be given to indicate Kilobytes, Megabytes or
>  Gigabytes respectively.
>
>  .TP
> @@ -808,7 +808,8 @@ an array which was originally created using a
> different version of
>  which computed a different offset.
>
>  Setting the offset explicitly over-rides the default.  The value given
> -is in Kilobytes unless an 'M' or 'G' suffix is given.
> +is in Kilobytes unless a suffix of 'K', 'M' or 'G' is used to explicitly
> +indicate Kilobytes, Megabytes or Gigabytes respectively.
>
>  Since Linux 3.4,
>  .B \-\-data\-offset

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Consistent use of IEC 80000-13 prefix in manpage
  2016-03-31 19:09 ` Jes Sorensen
  2016-03-31 22:21   ` [PATCH v2] Consistent use of metric " Marko Hauptvogel
@ 2016-04-03 19:19   ` Anthonys Lists
  1 sibling, 0 replies; 5+ messages in thread
From: Anthonys Lists @ 2016-04-03 19:19 UTC (permalink / raw)
  Cc: linux-raid

On 31/03/2016 20:09, Jes Sorensen wrote:
> I am not very much in favor of this patch. Any normal sane person still
> refers to megabytes and kilobytes as referring to 1024 base sizes,
> despite the pointless standard trying to mess them up to accommodate the
> harddrive vendors. Nobody normal knows what a kibibyte is.
Nobody normal knows that kilo actually means 2^10 ...

Yes I know us computer people regularly abuse the term, but nowadays the 
majority of computer lusers are familiar with the fact kilo has *always* 
meant 10^3.

After all, isn't a billion one million squared? (10^12) ... :-) It's 
only the Americans who think it's 1000^3 :-)

Cheers,
Wol

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-04-03 19:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-30 19:48 [PATCH] Consistent use of IEC 80000-13 prefix in manpage Marko Hauptvogel
2016-03-31 19:09 ` Jes Sorensen
2016-03-31 22:21   ` [PATCH v2] Consistent use of metric " Marko Hauptvogel
2016-04-01 20:11     ` Jes Sorensen
2016-04-03 19:19   ` [PATCH] Consistent use of IEC 80000-13 " Anthonys Lists

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.