* [PATCH] rtl8xxxu: Check return value of kmemdup()
@ 2016-01-12 12:26 Tobias Klauser
2016-01-12 23:34 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2016-01-12 12:26 UTC (permalink / raw)
To: Jes Sorensen, Kalle Valo; +Cc: linux-wireless
In rtl8xxxu_load_firmware() check the return value of kmemdup() and
error out with -ENOMEM in case of NULL to prevent a NULL pointer
dereference.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
index 7d820c395375..59f70513c491 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
@@ -2174,6 +2174,10 @@ static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv, char *fw_name)
}
priv->fw_data = kmemdup(fw->data, fw->size, GFP_KERNEL);
+ if (!priv->fw_data) {
+ ret = -ENOMEM;
+ goto exit;
+ }
priv->fw_size = fw->size - sizeof(struct rtl8xxxu_firmware_header);
signature = le16_to_cpu(priv->fw_data->signature);
--
2.7.0.1.g5e091f5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtl8xxxu: Check return value of kmemdup()
2016-01-12 12:26 [PATCH] rtl8xxxu: Check return value of kmemdup() Tobias Klauser
@ 2016-01-12 23:34 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2016-01-12 23:34 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Kalle Valo, linux-wireless
Tobias Klauser <tklauser@distanz.ch> writes:
> In rtl8xxxu_load_firmware() check the return value of kmemdup() and
> error out with -ENOMEM in case of NULL to prevent a NULL pointer
> dereference.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks, I'll add it to my queue!
Jes
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
> index 7d820c395375..59f70513c491 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
> @@ -2174,6 +2174,10 @@ static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv, char *fw_name)
> }
>
> priv->fw_data = kmemdup(fw->data, fw->size, GFP_KERNEL);
> + if (!priv->fw_data) {
> + ret = -ENOMEM;
> + goto exit;
> + }
> priv->fw_size = fw->size - sizeof(struct rtl8xxxu_firmware_header);
>
> signature = le16_to_cpu(priv->fw_data->signature);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-12 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 12:26 [PATCH] rtl8xxxu: Check return value of kmemdup() Tobias Klauser
2016-01-12 23:34 ` Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.