* [patch] staging: rtl8723au: fix some confusing indenting
@ 2014-05-03 20:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-05-03 20:19 UTC (permalink / raw)
To: Larry Finger
Cc: Jes Sorensen, Greg Kroah-Hartman, linux-wireless, devel,
linux-kernel, kernel-janitors
The break and the "unknown++" are at the same indent level so my static
checker complains. The if statement should be indented more.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index eb7b98e..4ad80e7 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
case WLAN_EID_ERP_INFO:
case WLAN_EID_EXT_SUPP_RATES:
case WLAN_EID_VENDOR_SPECIFIC:
- if (rtw_validate_vendor_specific_ies(pos, elen))
- unknown++;
+ if (rtw_validate_vendor_specific_ies(pos, elen))
+ unknown++;
break;
case WLAN_EID_RSN:
case WLAN_EID_PWR_CAPABILITY:
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] staging: rtl8723au: fix some confusing indenting
@ 2014-05-03 20:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-05-03 20:19 UTC (permalink / raw)
To: Larry Finger
Cc: Jes Sorensen, Greg Kroah-Hartman, linux-wireless, devel,
linux-kernel, kernel-janitors
The break and the "unknown++" are at the same indent level so my static
checker complains. The if statement should be indented more.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index eb7b98e..4ad80e7 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
case WLAN_EID_ERP_INFO:
case WLAN_EID_EXT_SUPP_RATES:
case WLAN_EID_VENDOR_SPECIFIC:
- if (rtw_validate_vendor_specific_ies(pos, elen))
- unknown++;
+ if (rtw_validate_vendor_specific_ies(pos, elen))
+ unknown++;
break;
case WLAN_EID_RSN:
case WLAN_EID_PWR_CAPABILITY:
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] staging: rtl8723au: fix some confusing indenting
2014-05-03 20:19 ` Dan Carpenter
@ 2014-05-03 21:09 ` Jes Sorensen
-1 siblings, 0 replies; 4+ messages in thread
From: Jes Sorensen @ 2014-05-03 21:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Larry Finger, Greg Kroah-Hartman, linux-wireless, devel,
linux-kernel, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains. The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Urgh yes, that should be cleaned up!
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index eb7b98e..4ad80e7 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
> case WLAN_EID_ERP_INFO:
> case WLAN_EID_EXT_SUPP_RATES:
> case WLAN_EID_VENDOR_SPECIFIC:
> - if (rtw_validate_vendor_specific_ies(pos, elen))
> - unknown++;
> + if (rtw_validate_vendor_specific_ies(pos, elen))
> + unknown++;
> break;
> case WLAN_EID_RSN:
> case WLAN_EID_PWR_CAPABILITY:
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] staging: rtl8723au: fix some confusing indenting
@ 2014-05-03 21:09 ` Jes Sorensen
0 siblings, 0 replies; 4+ messages in thread
From: Jes Sorensen @ 2014-05-03 21:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Larry Finger, Greg Kroah-Hartman, linux-wireless, devel,
linux-kernel, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains. The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Urgh yes, that should be cleaned up!
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index eb7b98e..4ad80e7 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
> case WLAN_EID_ERP_INFO:
> case WLAN_EID_EXT_SUPP_RATES:
> case WLAN_EID_VENDOR_SPECIFIC:
> - if (rtw_validate_vendor_specific_ies(pos, elen))
> - unknown++;
> + if (rtw_validate_vendor_specific_ies(pos, elen))
> + unknown++;
> break;
> case WLAN_EID_RSN:
> case WLAN_EID_PWR_CAPABILITY:
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-03 21:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-03 20:19 [patch] staging: rtl8723au: fix some confusing indenting Dan Carpenter
2014-05-03 20:19 ` Dan Carpenter
2014-05-03 21:09 ` Jes Sorensen
2014-05-03 21:09 ` Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.