All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>, Qian Cai <cai@lca.pw>,
	Andrew Morton <akpm@linux-foundation.org>,
	Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH -next] mm/hotplug: skip bad PFNs from pfn_to_online_page()
Date: Fri, 14 Jun 2019 13:08:48 -0400	[thread overview]
Message-ID: <x49ef3wytzz.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <16108dac-a4ca-aa87-e3b0-a79aebdcfafd@linux.ibm.com> (Aneesh Kumar K. V.'s message of "Fri, 14 Jun 2019 22:25:18 +0530")

"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:

> On 6/14/19 10:06 PM, Dan Williams wrote:
>> On Fri, Jun 14, 2019 at 9:26 AM Aneesh Kumar K.V
>> <aneesh.kumar@linux.ibm.com> wrote:
>
>>> Why not let the arch
>>> arch decide the SUBSECTION_SHIFT and default to one subsection per
>>> section if arch is not enabled to work with subsection.
>>
>> Because that keeps the implementation from ever reaching a point where
>> a namespace might be able to be moved from one arch to another. If we
>> can squash these arch differences then we can have a common tool to
>> initialize namespaces outside of the kernel. The one wrinkle is
>> device-dax that wants to enforce the mapping size,
>
> The fsdax have a much bigger issue right? The file system block size
> is the same as PAGE_SIZE and we can't make it portable across archs
> that support different PAGE_SIZE?

File system blocks are not tied to page size.  They can't be *bigger*
than the page size currently, but they can be smaller.

Still, I don't see that as an arugment against trying to make the
namespaces work across architectures.  Consider a user who only has
sector mode namespaces.  We'd like that to work if at all possible.

-Jeff
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Oscar Salvador <osalvador@suse.de>, Qian Cai <cai@lca.pw>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux MM <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH -next] mm/hotplug: skip bad PFNs from pfn_to_online_page()
Date: Fri, 14 Jun 2019 13:08:48 -0400	[thread overview]
Message-ID: <x49ef3wytzz.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <16108dac-a4ca-aa87-e3b0-a79aebdcfafd@linux.ibm.com> (Aneesh Kumar K. V.'s message of "Fri, 14 Jun 2019 22:25:18 +0530")

"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:

> On 6/14/19 10:06 PM, Dan Williams wrote:
>> On Fri, Jun 14, 2019 at 9:26 AM Aneesh Kumar K.V
>> <aneesh.kumar@linux.ibm.com> wrote:
>
>>> Why not let the arch
>>> arch decide the SUBSECTION_SHIFT and default to one subsection per
>>> section if arch is not enabled to work with subsection.
>>
>> Because that keeps the implementation from ever reaching a point where
>> a namespace might be able to be moved from one arch to another. If we
>> can squash these arch differences then we can have a common tool to
>> initialize namespaces outside of the kernel. The one wrinkle is
>> device-dax that wants to enforce the mapping size,
>
> The fsdax have a much bigger issue right? The file system block size
> is the same as PAGE_SIZE and we can't make it portable across archs
> that support different PAGE_SIZE?

File system blocks are not tied to page size.  They can't be *bigger*
than the page size currently, but they can be smaller.

Still, I don't see that as an arugment against trying to make the
namespaces work across architectures.  Consider a user who only has
sector mode namespaces.  We'd like that to work if at all possible.

-Jeff

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	 Oscar Salvador <osalvador@suse.de>,  Qian Cai <cai@lca.pw>,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Linux MM <linux-mm@kvack.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH -next] mm/hotplug: skip bad PFNs from pfn_to_online_page()
Date: Fri, 14 Jun 2019 13:08:48 -0400	[thread overview]
Message-ID: <x49ef3wytzz.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <16108dac-a4ca-aa87-e3b0-a79aebdcfafd@linux.ibm.com> (Aneesh Kumar K. V.'s message of "Fri, 14 Jun 2019 22:25:18 +0530")

"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:

> On 6/14/19 10:06 PM, Dan Williams wrote:
>> On Fri, Jun 14, 2019 at 9:26 AM Aneesh Kumar K.V
>> <aneesh.kumar@linux.ibm.com> wrote:
>
>>> Why not let the arch
>>> arch decide the SUBSECTION_SHIFT and default to one subsection per
>>> section if arch is not enabled to work with subsection.
>>
>> Because that keeps the implementation from ever reaching a point where
>> a namespace might be able to be moved from one arch to another. If we
>> can squash these arch differences then we can have a common tool to
>> initialize namespaces outside of the kernel. The one wrinkle is
>> device-dax that wants to enforce the mapping size,
>
> The fsdax have a much bigger issue right? The file system block size
> is the same as PAGE_SIZE and we can't make it portable across archs
> that support different PAGE_SIZE?

File system blocks are not tied to page size.  They can't be *bigger*
than the page size currently, but they can be smaller.

Still, I don't see that as an arugment against trying to make the
namespaces work across architectures.  Consider a user who only has
sector mode namespaces.  We'd like that to work if at all possible.

-Jeff


  reply	other threads:[~2019-06-14 17:08 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 19:15 [PATCH -next] mm/hotplug: skip bad PFNs from pfn_to_online_page() Qian Cai
2019-06-12 19:37 ` Dan Williams
2019-06-12 19:37   ` Dan Williams
2019-06-12 19:38   ` Dan Williams
2019-06-12 19:38     ` Dan Williams
2019-06-12 21:47     ` Qian Cai
2019-06-12 21:52       ` Dan Williams
2019-06-12 21:52         ` Dan Williams
2019-06-12 23:13         ` Dan Williams
2019-06-12 23:13           ` Dan Williams
2019-06-13  0:06       ` Dan Williams
2019-06-13  0:06         ` Dan Williams
2019-06-14  8:58       ` Aneesh Kumar K.V
2019-06-14 14:59         ` Qian Cai
2019-06-14 18:03           ` Dan Williams
2019-06-14 18:03             ` Dan Williams
2019-06-14 18:57             ` Dan Williams
2019-06-14 18:57               ` Dan Williams
2019-06-14 19:40               ` Qian Cai
2019-06-14 19:48                 ` Dan Williams
2019-06-14 19:48                   ` Dan Williams
2019-06-14 20:43                   ` Qian Cai
2019-06-16 15:42                     ` Dan Williams
2019-06-16 15:42                       ` Dan Williams
2019-06-17  2:25                       ` Qian Cai
2019-06-14 15:35         ` Oscar Salvador
2019-06-14 16:18           ` Aneesh Kumar K.V
2019-06-14 16:22             ` Dan Williams
2019-06-14 16:22               ` Dan Williams
2019-06-14 16:26               ` Aneesh Kumar K.V
2019-06-14 16:36                 ` Dan Williams
2019-06-14 16:36                   ` Dan Williams
2019-06-14 16:36                   ` Dan Williams
2019-06-14 16:50                   ` Aneesh Kumar K.V
2019-06-14 16:55                   ` Aneesh Kumar K.V
2019-06-14 17:08                     ` Jeff Moyer [this message]
2019-06-14 17:08                       ` Jeff Moyer
2019-06-14 17:08                       ` Jeff Moyer
2019-06-14 17:14                       ` Dan Williams
2019-06-14 17:14                         ` Dan Williams
2019-06-14 17:14                         ` Dan Williams
2019-06-14 17:40                       ` Aneesh Kumar K.V
2019-06-16  3:49               ` Aneesh Kumar K.V
2019-06-17 17:21                 ` Dan Williams
2019-06-17 17:21                   ` Dan Williams
2019-06-13 18:42   ` Qian Cai
2019-06-14  1:17     ` Dan Williams
2019-06-14  1:17       ` Dan Williams
2019-06-14  1:29       ` Qian Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49ef3wytzz.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=cai@lca.pw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.