From: Junio C Hamano <gitster@pobox.com>
To: Dimitriy <dimitriy.ryazantcev@gmail.com>
Cc: "Duy Nguyen" <pclouds@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3] l10n: localizable upload progress messages
Date: Mon, 24 Jun 2019 11:01:50 -0700 [thread overview]
Message-ID: <xmqq1rzij20h.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPUT4mQnsThA=ZxZD8K+J+u6tbN5PggPomuymEUO=u2GT88aUA@mail.gmail.com> (Dimitriy's message of "Sat, 22 Jun 2019 19:39:57 +0300")
Dimitriy <dimitriy.ryazantcev@gmail.com> writes:
> I just moved 'B' out of else block so it will be prepended with
> 'Gi'/'Mi'/'Ki' when needed.
> Note: I changed 'bytes' to just 'B' unit.
That makes this change more than "localizable messages", doesn't it?
As an old timer, I do not mind MiB (I'd prefer the old-fashioned MB
myself), but I think "20 bytes" (or "1 byte") spelled out is much
easier to grok and less prone to get misunderstood than "20B". Like
it or not, with scale prefixes, e.g. "20 kiB", "20 MiB", etc., it is
hard to misunderstand what 'B' means in there, but without any scale
prefix, i.e. "20 B", it is rather easy to get confused what 'B'
means.
next prev parent reply other threads:[~2019-06-24 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 9:36 [PATCH v3] l10n: localizable upload progress messages Dimitriy Ryazantcev
2019-06-22 11:42 ` Duy Nguyen
2019-06-22 16:39 ` Dimitriy
2019-06-24 18:01 ` Junio C Hamano [this message]
2019-06-22 21:42 ` Johannes Sixt
2019-06-23 1:03 ` brian m. carlson
2019-06-23 8:28 ` Dimitriy
2019-06-23 13:10 ` Johannes Sixt
2019-06-24 18:04 ` Junio C Hamano
2019-06-23 16:58 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rzij20h.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dimitriy.ryazantcev@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.